From 7c7021f3a211a3384d25b5a4175040750d50c248 Mon Sep 17 00:00:00 2001 From: Louis <35883445+louist103@users.noreply.github.com> Date: Tue, 14 Nov 2023 22:12:51 -0500 Subject: warnings --- Makefile | 4 +- src/overlays/actors/ovl_Boss_07/z_boss_07.c | 10 +- .../actors/ovl_Demo_Moonend/z_demo_moonend.c | 14 +- .../actors/ovl_Demo_Syoten/z_demo_syoten.c | 4 +- src/overlays/actors/ovl_En_Dnh/z_en_dnh.h | 2 +- src/overlays/actors/ovl_En_Fall2/z_en_fall2.c | 6 +- src/overlays/actors/ovl_En_Gm/z_en_gm.h | 2 +- tools/warnings_count/warnings_build_current.txt | 1009 +++++--------------- 8 files changed, 238 insertions(+), 813 deletions(-) diff --git a/Makefile b/Makefile index 69f7b69b5..815893290 100644 --- a/Makefile +++ b/Makefile @@ -108,7 +108,7 @@ endif # Check code syntax with host compiler ifneq ($(RUN_CC_CHECK),0) - CHECK_WARNINGS := -Wall -Wextra -Werror-implicit-function-declaration -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-variable -Wno-missing-braces -Wno-unused-but-set-variable -Wno-unused-label -Wno-sign-compare -Wno-tautological-compare + CHECK_WARNINGS := -Wall -Wextra -Werror-implicit-function-declaration -Wno-enum-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-variable -Wno-missing-braces -Wno-unused-but-set-variable -Wno-unused-label -Wno-sign-compare -Wno-tautological-compare CC_CHECK := gcc -fno-builtin -fsyntax-only -funsigned-char -fdiagnostics-color -std=gnu89 -D _LANGUAGE_C -D NON_MATCHING $(IINC) -nostdinc $(CHECK_WARNINGS) ifneq ($(WERROR), 0) CC_CHECK += -Werror @@ -130,7 +130,7 @@ ASFLAGS := -march=vr4300 -32 -Iinclude MIPS_VERSION := -mips2 # we support Microsoft extensions such as anonymous structs, which the compiler does support but warns for their usage. Suppress the warnings with -woff. -CFLAGS += -G 0 -non_shared -fullwarn -verbose -Xcpluscomm $(IINC) -nostdinc -Wab,-r4300_mul -woff 649,838,712,516 +CFLAGS += -G 0 -non_shared -fullwarn -verbose -Xcpluscomm $(IINC) -nostdinc -Wab,-r4300_mul -woff 649,838,712,516,624 # Use relocations and abi fpr names in the dump OBJDUMP_FLAGS := --disassemble --reloc --disassemble-zeroes -Mreg-names=32 diff --git a/src/overlays/actors/ovl_Boss_07/z_boss_07.c b/src/overlays/actors/ovl_Boss_07/z_boss_07.c index 3f8e7b500..c227ac821 100644 --- a/src/overlays/actors/ovl_Boss_07/z_boss_07.c +++ b/src/overlays/actors/ovl_Boss_07/z_boss_07.c @@ -1606,7 +1606,7 @@ void Boss07_Wrath_Grab(Boss07* this, PlayState* play) { } void Boss07_Wrath_GrabPlayer(Boss07* this, PlayState* play) { - s32 sp2C; + PlayerImpactType sp2C; Player* player = GET_PLAYER(play); SkelAnime_Update(&this->skelAnime); @@ -1632,7 +1632,7 @@ void Boss07_Wrath_ThrowPlayer(Boss07* this, PlayState* play) { Player* player = GET_PLAYER(play); f32 phi_f0; f32 phi_f2; - s32 sp30; + PlayerImpactType sp30; SkelAnime_Update(&this->skelAnime); this->whipCollisionTimer = 20; @@ -1867,7 +1867,7 @@ void Boss07_Wrath_Damaged(Boss07* this, PlayState* play) { void Boss07_Wrath_WhipCollisionCheck(Vec3f* whipPos, f32 tension, Boss07* this, PlayState* play) { s32 i; - s32 sp98 = -1; + PlayerImpactType sp98 = -1; Player* player = GET_PLAYER(play); f32 dx; f32 dy; @@ -3199,7 +3199,7 @@ void Boss07_Incarnation_SetupRun(Boss07* this, PlayState* play) { void Boss07_Incarnation_Run(Boss07* this, PlayState* play) { f32 sp34; f32 sp30; - s32 sp2C; + PlayerImpactType sp2C; Actor_PlaySfx(&this->actor, NA_SE_EN_LAST2_WALK_OLD - SFX_FLAG); this->timer_AB40++; @@ -5747,7 +5747,7 @@ void Boss07_Top_Collide(Boss07* this, PlayState* play) { } void Boss07_Top_CollisionCheck(Boss07* this, PlayState* play) { - s32 sp3C; + PlayerImpactType sp3C; s32 sp38 = false; Player* player = GET_PLAYER(play); s32 pad[3]; diff --git a/src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c b/src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c index b40707f64..ee0c33e09 100644 --- a/src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c +++ b/src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c @@ -46,9 +46,9 @@ void DemoMoonend_Init(Actor* thisx, PlayState* play) { this->actionFunc = func_80C17B60; } else { Actor_SetScale(&this->actor, 0.095f); - func_80183430(&this->skeletonInfo, &object_moonend_Blob_00B5A0, &object_moonend_Blob_001214, this->jointTable, + func_80183430(&this->skeletonInfo, (void*)object_moonend_Blob_00B5A0, (void*)object_moonend_Blob_001214, this->jointTable, this->morphTable, NULL); - func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); + func_801834A8(&this->skeletonInfo, (void*)object_moonend_Blob_001214); this->cueType = CS_CMD_ACTOR_CUE_560; this->actionFunc = func_80C17C48; this->actor.home.rot.z = 0; @@ -110,13 +110,13 @@ void func_80C17C48(DemoMoonend* this, PlayState* play) { switch (this->cueId) { case 1: this->actor.draw = DemoMoonend_Draw; - func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); + func_801834A8(&this->skeletonInfo, (void*)object_moonend_Blob_001214); this->skeletonInfo.frameCtrl.unk_C = 0.0f; break; case 2: this->actor.draw = DemoMoonend_Draw; - func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); + func_801834A8(&this->skeletonInfo, (void*)object_moonend_Blob_001214); this->skeletonInfo.frameCtrl.unk_C = 2.0f / 3.0f; Actor_PlaySfx(&this->actor, NA_SE_EV_MOON_EXPLOSION); this->actor.home.rot.z = 1; @@ -166,7 +166,7 @@ void DemoMoonend_Update(Actor* thisx, PlayState* play) { this->actionFunc(this, play); } -s32 func_80C17E70(PlayState* play, SkeletonInfo* skeletonInfo, s32 limbIndex, Gfx** dList, u8* flags, Actor* thisx, +s32 func_80C17E70(PlayState* play, SkeletonInfo* skeletonInfo, s32 limbIndex, Gfx** dList, u8* flags, void* thisx, Vec3f* scale, Vec3s* rot, Vec3f* pos) { DemoMoonend* this = THIS; @@ -178,7 +178,7 @@ s32 func_80C17E70(PlayState* play, SkeletonInfo* skeletonInfo, s32 limbIndex, Gf return true; } -s32 func_80C17EE0(PlayState* play, SkeletonInfo* skeleton, s32 limbIndex, Gfx** dList, u8* flags, Actor* thisx, +s32 func_80C17EE0(PlayState* play, SkeletonInfo* skeleton, s32 limbIndex, Gfx** dList, u8* flags, void* thisx, Vec3f* scale, Vec3s* rot, Vec3f* pos) { DemoMoonend* this = THIS; @@ -208,7 +208,7 @@ void func_80C17FCC(Actor* thisx, PlayState* play) { OPEN_DISPS(play->state.gfxCtx); Gfx_SetupDL25_Xlu(play->state.gfxCtx); - AnimatedMat_DrawXlu(play, Lib_SegmentedToVirtual(object_moonend_Matanimheader_0129F0)); + AnimatedMat_DrawXlu(play, Lib_SegmentedToVirtual((void*)object_moonend_Matanimheader_0129F0)); gSPMatrix(POLY_XLU_DISP++, Matrix_NewMtx(play->state.gfxCtx), G_MTX_NOPUSH | G_MTX_LOAD | G_MTX_MODELVIEW); gSPDisplayList(POLY_XLU_DISP++, object_moonend_DL_010C40); diff --git a/src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c b/src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c index bdae31ac9..5b4341e2e 100644 --- a/src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c +++ b/src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c @@ -73,9 +73,9 @@ void DemoSyoten_Init(Actor* thisx, PlayState* play) { switch (DEMOSYOTEN_GET_F(&this->actor)) { case DEMOSYOTEN_F_0: - func_80183430(&this->unk_144, &object_syoten_Blob_001328, &object_syoten_Blob_00023C, this->unk_174, + func_80183430(&this->unk_144, (void*)object_syoten_Blob_001328, (void*)object_syoten_Blob_00023C, this->unk_174, this->unk_2A6, NULL); - func_801835EC(&this->unk_144, &object_syoten_Blob_00023C); + func_801835EC(&this->unk_144, (void*)object_syoten_Blob_00023C); this->actor.draw = NULL; this->actionFunc = func_80C16A74; this->actor.child = diff --git a/src/overlays/actors/ovl_En_Dnh/z_en_dnh.h b/src/overlays/actors/ovl_En_Dnh/z_en_dnh.h index 997c5f702..c59a002ca 100644 --- a/src/overlays/actors/ovl_En_Dnh/z_en_dnh.h +++ b/src/overlays/actors/ovl_En_Dnh/z_en_dnh.h @@ -15,7 +15,7 @@ typedef struct EnDnh { /* 0x144 */ EnDnhActionFunc actionFunc; /* 0x148 */ SkelAnime skelAnime; /* 0x18C */ u16 unk18C; - /* 0x190 */ s32* msgEventScript; + /* 0x190 */ MsgScript* msgEventScript; /* 0x194 */ s32 unk194; /* 0x198 */ s16 unk198; /* 0x19A */ UNK_TYPE1 pad19A[0x2]; diff --git a/src/overlays/actors/ovl_En_Fall2/z_en_fall2.c b/src/overlays/actors/ovl_En_Fall2/z_en_fall2.c index 68f9d4dab..ad34a8487 100644 --- a/src/overlays/actors/ovl_En_Fall2/z_en_fall2.c +++ b/src/overlays/actors/ovl_En_Fall2/z_en_fall2.c @@ -35,10 +35,10 @@ void EnFall2_Init(Actor* thisx, PlayState* play) { Actor_SetScale(&this->actor, 1.0f); this->actionFunc = EnFall2_DoNothing; - func_80183430(&this->skeletonInfo, object_fall2_Blob_008898, object_fall2_Blob_005EF4, this->unk174, this->unk228, + func_80183430(&this->skeletonInfo, (void*)object_fall2_Blob_008898, (void*)object_fall2_Blob_005EF4, this->unk174, this->unk228, NULL); - func_801835EC(&this->skeletonInfo, object_fall2_Blob_005EF4); - this->unk2DC = Lib_SegmentedToVirtual(object_fall2_Matanimheader_008840); + func_801835EC(&this->skeletonInfo, (void*)object_fall2_Blob_005EF4); + this->unk2DC = Lib_SegmentedToVirtual((void*)object_fall2_Matanimheader_008840); Actor_SetScale(&this->actor, 0.02f); this->actionFunc = EnFall2_HandleCutscene; this->cueType = CS_CMD_ACTOR_CUE_561; diff --git a/src/overlays/actors/ovl_En_Gm/z_en_gm.h b/src/overlays/actors/ovl_En_Gm/z_en_gm.h index e74013ec9..20ba410ce 100644 --- a/src/overlays/actors/ovl_En_Gm/z_en_gm.h +++ b/src/overlays/actors/ovl_En_Gm/z_en_gm.h @@ -33,7 +33,7 @@ typedef struct EnGm { /* 0x260 */ s8 unk_260; /* 0x261 */ s8 unk_261; /* 0x262 */ s8 objectSlot; - /* 0x264 */ s32* unk_264; + /* 0x264 */ MsgScript* unk_264; /* 0x268 */ Actor* unk_268; /* 0x26C */ UNK_TYPE1 unk_26C[0xC]; /* 0x278 */ Vec3f unk_278; diff --git a/tools/warnings_count/warnings_build_current.txt b/tools/warnings_count/warnings_build_current.txt index d255b279b..f48ac2b61 100644 --- a/tools/warnings_count/warnings_build_current.txt +++ b/tools/warnings_count/warnings_build_current.txt @@ -1,177 +1,99 @@ -cc: Warning: -mips3 should not be used for ucode 32-bit compiles -cc: Warning: -mips3 should not be used for ucode 32-bit compiles -src/audio/voice_internal.c: In function 'func_801A5228': -src/audio/voice_internal.c:88:51: warning: passing argument 2 of 'osVoiceSetWord' from incompatible pointer type [-Wincompatible-pointer-types] - 88 | errorCode = osVoiceSetWord(&gVoiceHandle, &dict->words[i]); - | ^~~~~~~~~~~~~~~ - | | - | u16 (*)[15] {aka short unsigned int (*)[15]} -In file included from include/PR/controller_voice.h:5, - from include/ultra64.h:9, - from include/z64.h:11, - from include/global.h:4, - from src/audio/voice_internal.c:1: -include/PR/os_voice.h:60:43: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'u16 (*)[15]' {aka 'short unsigned int (*)[15]'} - 60 | s32 osVoiceSetWord(OSVoiceHandle* hd, u8* word); - | ~~~~^~~~ -src/audio/voice_internal.c:92:27: warning: passing argument 1 of 'func_801A5A1C' from incompatible pointer type [-Wincompatible-pointer-types] - 92 | func_801A5A1C(&dict->words[i]); - | ^~~~~~~~~~~~~~~ - | | - | u16 (*)[15] {aka short unsigned int (*)[15]} -src/audio/voice_internal.c:5:23: note: expected 's8 *' {aka 'signed char *'} but argument is of type 'u16 (*)[15]' {aka 'short unsigned int (*)[15]'} - 5 | u8* func_801A5A1C(s8* words); - | ~~~~^~~~~ -src/audio/voice_internal.c: In function 'func_801A5A1C': -src/audio/voice_internal.c:324:23: warning: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] - 324 | u8 numSyllables = strlen(words); // technically twice the num of syllables - | ^~~~~~ -src/audio/voice_internal.c:3:1: note: 'strlen' is defined in header ''; did you forget to '#include '? - 2 | #include "z64voice.h" - +++ |+#include  - 3 | -src/audio/voice_internal.c:348:12: warning: pointer targets in returning 'char *' from a function with return type 'u8 *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign] - 348 | return D_801FD610; - | ^~~~~~~~~~ -cfe: Warning 709: src/audio/voice_internal.c, line 88: Incompatible pointer type assignment - errorCode = osVoiceSetWord(&gVoiceHandle, &dict->words[i]); - --------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/audio/voice_internal.c, line 92: Incompatible pointer type assignment - func_801A5A1C(&dict->words[i]); - --------------------------^ +src/overlays/actors/ovl_En_An/z_en_an.c: In function 'EnAn_CheckTalk': +src/overlays/actors/ovl_En_An/z_en_an.c:1755:30: warning: assignment to 'MsgScript *' {aka 'unsigned char *'} from incompatible pointer type 's32 *' {aka 'int *'} [-Wincompatible-pointer-types] + 1755 | this->msgEventScript = EnAn_GetMsgEventScript(this, play); + | ^ +cfe: Warning 709: src/overlays/actors/ovl_En_An/z_en_an.c, line 1755: Incompatible pointer type assignment + this->msgEventScript = EnAn_GetMsgEventScript(this, play); + -----------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 835: src/audio/voice_internal.c, line 324: No prototype for the call to an anonymous function - u8 numSyllables = strlen(words); - ----------------------------^ -To achieve better type-checking, there should be a full prototype for -the function being called. -src/overlays/actors/ovl_Eff_Change/z_eff_change.c: In function 'EffChange_Init': -src/overlays/actors/ovl_Eff_Change/z_eff_change.c:53:40: warning: passing argument 2 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 53 | func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, - | ^~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 * {aka unsigned char *} -In file included from include/global.h:5, - from src/overlays/actors/ovl_Eff_Change/z_eff_change.h:4, - from src/overlays/actors/ovl_Eff_Change/z_eff_change.c:7: -include/functions.h:1155:66: note: expected 'Struct_801BFA14_Arg1 *' but argument is of type 'u8 *' {aka 'unsigned char *'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Eff_Change/z_eff_change.c:53:67: warning: passing argument 3 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 53 | func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, - | ^~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 * {aka unsigned char *} -include/functions.h:1155:89: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 *' {aka 'unsigned char *'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Eff_Change/z_eff_change.c:54:23: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 54 | this->morphTable, NULL); - | ~~~~^~~~~~~~~~~~ +src/overlays/actors/ovl_En_Test/z_en_test.c: In function 'EnTest_Init': +src/overlays/actors/ovl_En_Test/z_en_test.c:190:23: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] + 190 | this->unk_1C0, NULL); + | ~~~~^~~~~~~~~ | | - | Vec3s * -include/functions.h:1155:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); + | Vec3s * {aka struct *} +In file included from include/global.h:5, + from src/overlays/actors/ovl_En_Test/z_en_test.h:4, + from src/overlays/actors/ovl_En_Test/z_en_test.c:7: +include/functions.h:1122:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' {aka 'struct *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); | ~~~~~^~~~ -src/overlays/actors/ovl_Eff_Change/z_eff_change.c:55:40: warning: passing argument 2 of 'func_801834A8' from incompatible pointer type [-Wincompatible-pointer-types] - 55 | func_801834A8(&this->skeletonInfo, gameplay_keep_Blob_0281DC); - | ^~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 * {aka unsigned char *} -include/functions.h:1157:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 *' {aka 'unsigned char *'} - 1157 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); - | ~~~~~~~~~~~~~~~~~^~~~ -cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 53: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, - ---------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 53: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, - ------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 54: Incompatible pointer type assignment - this->morphTable, (void*)0 ); +cfe: Warning 709: src/overlays/actors/ovl_En_Test/z_en_test.c, line 190: Incompatible pointer type assignment + this->unk_1C0, (void*)0 ); ----------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 55: Incompatible pointer type assignment - func_801834A8(&this->skeletonInfo, gameplay_keep_Blob_0281DC); - ---------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -src/overlays/actors/ovl_En_Jso2/z_en_jso2.c: In function 'func_80A778F8': -src/overlays/actors/ovl_En_Jso2/z_en_jso2.c:385:37: warning: passing argument 2 of 'func_80122744' from incompatible pointer type [-Wincompatible-pointer-types] - 385 | func_80122744(play, &this->unk_27C, 1, &D_80A7B6F4); - | ^~~~~~~~~~~~~~ - | | - | char (*)[8] +src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c: In function 'DemoSyoten_Init': +src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c:77:31: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] + 77 | this->unk_2A6, NULL); + | ~~~~^~~~~~~~~ + | | + | Vec3s * {aka struct *} In file included from include/global.h:5, - from src/overlays/actors/ovl_En_Jso2/z_en_jso2.h:4, - from src/overlays/actors/ovl_En_Jso2/z_en_jso2.c:7: -include/functions.h:807:58: note: expected 'struct_80122744_arg1 *' but argument is of type 'char (*)[8]' - 807 | s32 func_80122744(PlayState* play, struct_80122744_arg1* arg1, u32 arg2, Vec3s* arg3); - | ~~~~~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_En_Jso2/z_en_jso2.c:411:37: warning: passing argument 2 of 'func_80122760' from incompatible pointer type [-Wincompatible-pointer-types] - 411 | if (func_80122760(play, &this->unk_27C, 60.0f) != 0) { - | ^~~~~~~~~~~~~~ - | | - | char (*)[8] -include/functions.h:808:58: note: expected 'struct_80122744_arg1 *' but argument is of type 'char (*)[8]' - 808 | s32 func_80122760(PlayState* play, struct_80122744_arg1* arg1, f32 arg2); - | ~~~~~~~~~~~~~~~~~~~~~~^~~~ -cfe: Warning 709: src/overlays/actors/ovl_En_Jso2/z_en_jso2.c, line 385: Incompatible pointer type assignment - func_80122744(play, &this->unk_27C, 1, &D_80A7B6F4); - ------------------------------------^ + from src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.h:4, + from src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c:7: +include/functions.h:1122:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' {aka 'struct *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); + | ~~~~~^~~~ +cfe: Warning 709: src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c, line 77: Incompatible pointer type assignment + this->unk_2A6, (void*)0 ); + ------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Jso2/z_en_jso2.c, line 411: Incompatible pointer type assignment - if (func_80122760(play, &this->unk_27C, 60.0f) != 0) { - ------------------------------------^ +src/overlays/actors/ovl_En_Fall2/z_en_fall2.c: In function 'EnFall2_Init': +src/overlays/actors/ovl_En_Fall2/z_en_fall2.c:38:124: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] + 38 | func_80183430(&this->skeletonInfo, (void*)object_fall2_Blob_008898, (void*)object_fall2_Blob_005EF4, this->unk174, this->unk228, + | ~~~~^~~~~~~~ + | | + | Vec3s * {aka struct *} +In file included from include/global.h:5, + from src/overlays/actors/ovl_En_Fall2/z_en_fall2.h:4, + from src/overlays/actors/ovl_En_Fall2/z_en_fall2.c:7: +include/functions.h:1122:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' {aka 'struct *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); + | ~~~~~^~~~ +cfe: Warning 709: src/overlays/actors/ovl_En_Fall2/z_en_fall2.c, line 38: Incompatible pointer type assignment + func_80183430(&this->skeletonInfo, (void*)object_fall2_Blob_008898, (void*)object_fall2_Blob_005EF4, this->unk174, this->unk228, + ---------------------------------------------------------------------------------------------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. src/overlays/actors/ovl_En_Bsb/z_en_bsb.c: In function 'func_80C0DB18': src/overlays/actors/ovl_En_Bsb/z_en_bsb.c:1129:41: warning: left-hand operand of comma expression has no effect [-Wunused-value] 1129 | CutsceneManager_Queue(((NULL, this->unk_02CC))[3]); | ^ -cfe: Warning 624: src/overlays/actors/ovl_En_Test4/z_en_test4.c, line 37: Trailing comma in enumerator list - TIME_NIGHT, - ----------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: /home/louist103/mm-hm/src/overlays/actors/ovl_Boss_05/z_boss_05.h, line 16: Trailing comma in enumerator list - BIO_DEKU_BABA_TYPE_10 = 10, - --------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -src/overlays/actors/ovl_En_Gm/z_en_gm.c: In function 'func_8094EE84': -src/overlays/actors/ovl_En_Gm/z_en_gm.c:964:23: warning: assignment to 's32 *' {aka 'int *'} from incompatible pointer type 'MsgScript *' {aka 'unsigned char *'} [-Wincompatible-pointer-types] - 964 | this->unk_264 = func_8094EDBC(this, play); - | ^ -src/overlays/actors/ovl_En_Gm/z_en_gm.c: In function 'func_80950DB8': -src/overlays/actors/ovl_En_Gm/z_en_gm.c:1838:52: warning: passing argument 3 of 'MsgEvent_RunScript' from incompatible pointer type [-Wincompatible-pointer-types] - 1838 | if (MsgEvent_RunScript(&this->actor, play, this->unk_264, this->unk_3E4, &this->unk_25C)) { - | ~~~~^~~~~~~~~ - | | - | s32 * {aka int *} +src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c: In function 'DemoMoonend_Init': +src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:50:27: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] + 50 | this->morphTable, NULL); + | ~~~~^~~~~~~~~~~~ + | | + | Vec3s * {aka struct *} In file included from include/global.h:5, - from src/overlays/actors/ovl_En_Gm/z_en_gm.h:4, - from src/overlays/actors/ovl_En_Gm/z_en_gm.c:7: -include/functions.h:778:66: note: expected 'MsgScript *' {aka 'unsigned char *'} but argument is of type 's32 *' {aka 'int *'} - 778 | s32 MsgEvent_RunScript(Actor* actor, PlayState* play, MsgScript* script, MsgEventCallback callback, s32* pos); - | ~~~~~~~~~~~^~~~~~ -cfe: Warning 709: src/overlays/actors/ovl_En_Gm/z_en_gm.c, line 964: Incompatible pointer type assignment - this->unk_264 = func_8094EDBC(this, play); - ----------------------^ + from src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.h:4, + from src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:7: +include/functions.h:1122:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' {aka 'struct *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); + | ~~~~~^~~~ +src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c: In function 'DemoMoonend_Draw': +src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:203:70: warning: passing argument 5 of 'func_8018450C' from incompatible pointer type [-Wincompatible-pointer-types] + 203 | func_8018450C(play, &this->skeletonInfo, mtx, func_80C17E70, func_80C17EE0, &this->actor); + | ^~~~~~~~~~~~~ + | | + | s32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, void *, Vec3f *, Vec3s *, Vec3f *) {aka int (*)(struct PlayState *, struct SkeletonInfo *, int, union **, unsigned char *, void *, struct *, struct *, struct *)} +In file included from include/global.h:5, + from src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.h:4, + from src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:7: +include/functions.h:1139:143: note: expected 'PostKeyframeDrawScaled' {aka 'void (*)(struct PlayState *, struct SkeletonInfo *, int, union **, unsigned char *, void *, struct *, struct *, struct *)'} but argument is of type 's32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, void *, Vec3f *, Vec3s *, Vec3f *)' {aka 'int (*)(struct PlayState *, struct SkeletonInfo *, int, union **, unsigned char *, void *, struct *, struct *, struct *)'} + 1139 | void func_8018450C(PlayState* play, SkeletonInfo* skeleton, Mtx* mtx, OverrideKeyframeDrawScaled overrideKeyframeDraw, PostKeyframeDrawScaled postKeyframeDraw, void* arg); + | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ +cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 50: Incompatible pointer type assignment + this->morphTable, (void*)0 ); + --------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Gm/z_en_gm.c, line 1838: Incompatible pointer type assignment - if (MsgEvent_RunScript(&this->actor, play, this->unk_264, this->unk_3E4, &this->unk_25C)) { - ---------------------------------------------------^ +cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 203: Incompatible pointer type assignment + func_8018450C(play, &this->skeletonInfo, mtx, func_80C17E70, func_80C17EE0, &this->actor); + ---------------------------------------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. src/overlays/actors/ovl_En_Test7/z_en_test7.c: In function 'EnTest7_Init': @@ -183,41 +105,53 @@ statement is incompatible with the type pointed to by the right-hand side. In file included from include/global.h:5, from src/overlays/actors/ovl_En_Test7/z_en_test7.h:4, from src/overlays/actors/ovl_En_Test7/z_en_test7.c:8: -include/functions.h:1155:66: note: expected 'Struct_801BFA14_Arg1 *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); +include/functions.h:1122:66: note: expected 'Struct_801BFA14_Arg1 *' {aka 'struct *'} but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); | ~~~~~~~~~~~~~~~~~~~~~~^~~~ src/overlays/actors/ovl_En_Test7/z_en_test7.c:400:64: warning: passing argument 3 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] 400 | func_80183430(&this->unk_18CC, &gameplay_keep_Blob_085640, &gameplay_keep_Blob_083534, this->unk_18FC, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ | | | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1155:89: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); +In file included from include/global.h:5, + from src/overlays/actors/ovl_En_Test7/z_en_test7.h:4, + from src/overlays/actors/ovl_En_Test7/z_en_test7.c:8: +include/functions.h:1122:89: note: expected 'SkeletonInfo_1C *' {aka 'struct *'} but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); | ~~~~~~~~~~~~~~~~~^~~~ src/overlays/actors/ovl_En_Test7/z_en_test7.c:401:23: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] 401 | this->unk_1BA8, NULL); | ~~~~^~~~~~~~~~ | | - | Vec3s * -include/functions.h:1155:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); + | Vec3s * {aka struct *} +In file included from include/global.h:5, + from src/overlays/actors/ovl_En_Test7/z_en_test7.h:4, + from src/overlays/actors/ovl_En_Test7/z_en_test7.c:8: +include/functions.h:1122:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' {aka 'struct *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); | ~~~~~^~~~ src/overlays/actors/ovl_En_Test7/z_en_test7.c:402:36: warning: passing argument 2 of 'func_801834A8' from incompatible pointer type [-Wincompatible-pointer-types] 402 | func_801834A8(&this->unk_18CC, &gameplay_keep_Blob_083534); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ | | | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1157:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1157 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); +In file included from include/global.h:5, + from src/overlays/actors/ovl_En_Test7/z_en_test7.h:4, + from src/overlays/actors/ovl_En_Test7/z_en_test7.c:8: +include/functions.h:1124:61: note: expected 'SkeletonInfo_1C *' {aka 'struct *'} but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} + 1124 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); | ~~~~~~~~~~~~~~~~~^~~~ src/overlays/actors/ovl_En_Test7/z_en_test7.c: In function 'EnTest7_Draw': src/overlays/actors/ovl_En_Test7/z_en_test7.c:969:55: warning: passing argument 4 of 'func_8018450C' from incompatible pointer type [-Wincompatible-pointer-types] 969 | func_8018450C(play, &this->unk_18CC, mtx, func_80AF31D0, NULL, &this->actor); | ^~~~~~~~~~~~~ | | - | s32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *) {aka int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)} -include/functions.h:1172:98: note: expected 'OverrideKeyframeDrawScaled' {aka 'int (*)(struct PlayState *, struct SkeletonInfo *, int, Gfx **, unsigned char *, void *, Vec3f *, Vec3s *, Vec3f *)'} but argument is of type 's32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *)' {aka 'int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)'} - 1172 | void func_8018450C(PlayState* play, SkeletonInfo* skeleton, Mtx* mtx, OverrideKeyframeDrawScaled overrideKeyframeDraw, PostKeyframeDrawScaled postKeyframeDraw, void* arg); + | s32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *) {aka int (*)(struct PlayState *, struct SkeletonInfo *, int, union **, unsigned char *, struct Actor *, struct *, struct *, struct *)} +In file included from include/global.h:5, + from src/overlays/actors/ovl_En_Test7/z_en_test7.h:4, + from src/overlays/actors/ovl_En_Test7/z_en_test7.c:8: +include/functions.h:1139:98: note: expected 'OverrideKeyframeDrawScaled' {aka 'int (*)(struct PlayState *, struct SkeletonInfo *, int, union **, unsigned char *, void *, struct *, struct *, struct *)'} but argument is of type 's32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *)' {aka 'int (*)(struct PlayState *, struct SkeletonInfo *, int, union **, unsigned char *, struct Actor *, struct *, struct *, struct *)'} + 1139 | void func_8018450C(PlayState* play, SkeletonInfo* skeleton, Mtx* mtx, OverrideKeyframeDrawScaled overrideKeyframeDraw, PostKeyframeDrawScaled postKeyframeDraw, void* arg); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ cfe: Warning 709: src/overlays/actors/ovl_En_Test7/z_en_test7.c, line 400: Incompatible pointer type assignment func_80183430(&this->unk_18CC, &gameplay_keep_Blob_085640, &gameplay_keep_Blob_083534, this->unk_18FC, @@ -244,650 +178,121 @@ cfe: Warning 709: src/overlays/actors/ovl_En_Test7/z_en_test7.c, line 969: Incom ------------------------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 624: /home/louist103/mm-hm/src/overlays/actors/ovl_En_Invadepoh/z_en_invadepoh.h, line 181: Trailing comma in enumerator list - ENINVADEPOH_ALIEN_ABDUCTOR, - --------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -src/overlays/actors/ovl_En_Test/z_en_test.c: In function 'EnTest_Init': -src/overlays/actors/ovl_En_Test/z_en_test.c:189:40: warning: passing argument 2 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 189 | func_80183430(&this->skeletonInfo, &gameplay_keep_Blob_06EB70, &gameplay_keep_Blob_06BB0C, this->unk_178, - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ +src/overlays/actors/ovl_Eff_Change/z_eff_change.c: In function 'EffChange_Init': +src/overlays/actors/ovl_Eff_Change/z_eff_change.c:53:40: warning: passing argument 2 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] + 53 | func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, + | ^~~~~~~~~~~~~~~~~~~~~~~~~ | | - | u8 (*)[] {aka unsigned char (*)[]} + | u8 * {aka unsigned char *} In file included from include/global.h:5, - from src/overlays/actors/ovl_En_Test/z_en_test.h:4, - from src/overlays/actors/ovl_En_Test/z_en_test.c:7: -include/functions.h:1155:66: note: expected 'Struct_801BFA14_Arg1 *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); + from src/overlays/actors/ovl_Eff_Change/z_eff_change.h:4, + from src/overlays/actors/ovl_Eff_Change/z_eff_change.c:7: +include/functions.h:1122:66: note: expected 'Struct_801BFA14_Arg1 *' {aka 'struct *'} but argument is of type 'u8 *' {aka 'unsigned char *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); | ~~~~~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_En_Test/z_en_test.c:189:68: warning: passing argument 3 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 189 | func_80183430(&this->skeletonInfo, &gameplay_keep_Blob_06EB70, &gameplay_keep_Blob_06BB0C, this->unk_178, - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1155:89: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); +src/overlays/actors/ovl_Eff_Change/z_eff_change.c:53:67: warning: passing argument 3 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] + 53 | func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, + | ^~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | u8 * {aka unsigned char *} +In file included from include/global.h:5, + from src/overlays/actors/ovl_Eff_Change/z_eff_change.h:4, + from src/overlays/actors/ovl_Eff_Change/z_eff_change.c:7: +include/functions.h:1122:89: note: expected 'SkeletonInfo_1C *' {aka 'struct *'} but argument is of type 'u8 *' {aka 'unsigned char *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_En_Test/z_en_test.c:190:23: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 190 | this->unk_1C0, NULL); - | ~~~~^~~~~~~~~ +src/overlays/actors/ovl_Eff_Change/z_eff_change.c:54:23: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] + 54 | this->morphTable, NULL); + | ~~~~^~~~~~~~~~~~ | | - | Vec3s * -include/functions.h:1155:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~^~~~ -src/overlays/actors/ovl_En_Test/z_en_test.c:191:40: warning: passing argument 2 of 'func_801834A8' from incompatible pointer type [-Wincompatible-pointer-types] - 191 | func_801834A8(&this->skeletonInfo, &gameplay_keep_Blob_06BB0C); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1157:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1157 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_En_Test/z_en_test.c: In function 'EnTest_Draw': -src/overlays/actors/ovl_En_Test/z_en_test.c:271:55: warning: passing argument 4 of 'func_8018450C' from incompatible pointer type [-Wincompatible-pointer-types] - 271 | func_8018450C(play, &this->skeletonInfo, mtx, EnTest_OverrideKeyframeDraw, NULL, thisx); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | s32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *) {aka int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)} -include/functions.h:1172:98: note: expected 'OverrideKeyframeDrawScaled' {aka 'int (*)(struct PlayState *, struct SkeletonInfo *, int, Gfx **, unsigned char *, void *, Vec3f *, Vec3s *, Vec3f *)'} but argument is of type 's32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *)' {aka 'int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)'} - 1172 | void func_8018450C(PlayState* play, SkeletonInfo* skeleton, Mtx* mtx, OverrideKeyframeDrawScaled overrideKeyframeDraw, PostKeyframeDrawScaled postKeyframeDraw, void* arg); - | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ -cfe: Warning 709: src/overlays/actors/ovl_En_Test/z_en_test.c, line 189: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, &gameplay_keep_Blob_06EB70, &gameplay_keep_Blob_06BB0C, this->unk_178, - ---------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Test/z_en_test.c, line 189: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, &gameplay_keep_Blob_06EB70, &gameplay_keep_Blob_06BB0C, this->unk_178, - -------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Test/z_en_test.c, line 190: Incompatible pointer type assignment - this->unk_1C0, (void*)0 ); - ----------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Test/z_en_test.c, line 191: Incompatible pointer type assignment - func_801834A8(&this->skeletonInfo, &gameplay_keep_Blob_06BB0C); - ---------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Test/z_en_test.c, line 271: Incompatible pointer type assignment - func_8018450C(play, &this->skeletonInfo, mtx, EnTest_OverrideKeyframeDraw, (void*)0 , thisx); - ------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -src/overlays/actors/ovl_En_Fall2/z_en_fall2.c: In function 'EnFall2_Init': -src/overlays/actors/ovl_En_Fall2/z_en_fall2.c:38:40: warning: passing argument 2 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 38 | func_80183430(&this->skeletonInfo, object_fall2_Blob_008898, object_fall2_Blob_005EF4, this->unk174, this->unk228, - | ^~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 * {aka unsigned char *} + | Vec3s * {aka struct *} In file included from include/global.h:5, - from src/overlays/actors/ovl_En_Fall2/z_en_fall2.h:4, - from src/overlays/actors/ovl_En_Fall2/z_en_fall2.c:7: -include/functions.h:1155:66: note: expected 'Struct_801BFA14_Arg1 *' but argument is of type 'u8 *' {aka 'unsigned char *'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_En_Fall2/z_en_fall2.c:38:66: warning: passing argument 3 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 38 | func_80183430(&this->skeletonInfo, object_fall2_Blob_008898, object_fall2_Blob_005EF4, this->unk174, this->unk228, - | ^~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 * {aka unsigned char *} -include/functions.h:1155:89: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 *' {aka 'unsigned char *'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_En_Fall2/z_en_fall2.c:38:110: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 38 | func_80183430(&this->skeletonInfo, object_fall2_Blob_008898, object_fall2_Blob_005EF4, this->unk174, this->unk228, - | ~~~~^~~~~~~~ - | | - | Vec3s * -include/functions.h:1155:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); + from src/overlays/actors/ovl_Eff_Change/z_eff_change.h:4, + from src/overlays/actors/ovl_Eff_Change/z_eff_change.c:7: +include/functions.h:1122:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' {aka 'struct *'} + 1122 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); | ~~~~~^~~~ -src/overlays/actors/ovl_En_Fall2/z_en_fall2.c:40:40: warning: passing argument 2 of 'func_801835EC' from incompatible pointer type [-Wincompatible-pointer-types] - 40 | func_801835EC(&this->skeletonInfo, object_fall2_Blob_005EF4); - | ^~~~~~~~~~~~~~~~~~~~~~~~ +src/overlays/actors/ovl_Eff_Change/z_eff_change.c:55:40: warning: passing argument 2 of 'func_801834A8' from incompatible pointer type [-Wincompatible-pointer-types] + 55 | func_801834A8(&this->skeletonInfo, gameplay_keep_Blob_0281DC); + | ^~~~~~~~~~~~~~~~~~~~~~~~~ | | | u8 * {aka unsigned char *} -include/functions.h:1160:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 *' {aka 'unsigned char *'} - 1160 | void func_801835EC(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); +In file included from include/global.h:5, + from src/overlays/actors/ovl_Eff_Change/z_eff_change.h:4, + from src/overlays/actors/ovl_Eff_Change/z_eff_change.c:7: +include/functions.h:1124:61: note: expected 'SkeletonInfo_1C *' {aka 'struct *'} but argument is of type 'u8 *' {aka 'unsigned char *'} + 1124 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); | ~~~~~~~~~~~~~~~~~^~~~ -cfe: Warning 709: src/overlays/actors/ovl_En_Fall2/z_en_fall2.c, line 38: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, object_fall2_Blob_008898, object_fall2_Blob_005EF4, this->unk174, this->unk228, +cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 53: Incompatible pointer type assignment + func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, ---------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Fall2/z_en_fall2.c, line 38: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, object_fall2_Blob_008898, object_fall2_Blob_005EF4, this->unk174, this->unk228, - -----------------------------------------------------------------^ +cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 53: Incompatible pointer type assignment + func_80183430(&this->skeletonInfo, gameplay_keep_Blob_02900C, gameplay_keep_Blob_0281DC, this->jointTable, + ------------------------------------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Fall2/z_en_fall2.c, line 38: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, object_fall2_Blob_008898, object_fall2_Blob_005EF4, this->unk174, this->unk228, - -------------------------------------------------------------------------------------------------------------^ +cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 54: Incompatible pointer type assignment + this->morphTable, (void*)0 ); + ----------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Fall2/z_en_fall2.c, line 40: Incompatible pointer type assignment - func_801835EC(&this->skeletonInfo, object_fall2_Blob_005EF4); +cfe: Warning 709: src/overlays/actors/ovl_Eff_Change/z_eff_change.c, line 55: Incompatible pointer type assignment + func_801834A8(&this->skeletonInfo, gameplay_keep_Blob_0281DC); ---------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -src/overlays/actors/ovl_En_Dt/z_en_dt.c:90:37: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 90 | static TexturePtr* D_80BEB348[] = { &gDotourEyeShockTex, &gDotourEyeOpenTex, &gDotourEyeClosedTex, - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:90:37: note: (near initialization for 'D_80BEB348[0]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c:90:58: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 90 | static TexturePtr* D_80BEB348[] = { &gDotourEyeShockTex, &gDotourEyeOpenTex, &gDotourEyeClosedTex, - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:90:58: note: (near initialization for 'D_80BEB348[1]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c:90:78: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 90 | static TexturePtr* D_80BEB348[] = { &gDotourEyeShockTex, &gDotourEyeOpenTex, &gDotourEyeClosedTex, - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:90:78: note: (near initialization for 'D_80BEB348[2]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c:91:37: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 91 | &gDotourEyeLookDownTex, &gDotourEyeSquintTex }; - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:91:37: note: (near initialization for 'D_80BEB348[3]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c:91:61: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 91 | &gDotourEyeLookDownTex, &gDotourEyeSquintTex }; - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:91:61: note: (near initialization for 'D_80BEB348[4]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c:93:37: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 93 | static TexturePtr* D_80BEB35C[] = { &gDotourEyebrowHighTex, &gDotourEyebrowMidTex, &gDotourEyebrowLowTex }; - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:93:37: note: (near initialization for 'D_80BEB35C[0]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c:93:61: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 93 | static TexturePtr* D_80BEB35C[] = { &gDotourEyebrowHighTex, &gDotourEyebrowMidTex, &gDotourEyebrowLowTex }; - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:93:61: note: (near initialization for 'D_80BEB35C[1]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c:93:84: warning: initialization of 'void **' from incompatible pointer type 'u64 (*)[]' {aka 'long long unsigned int (*)[]'} [-Wincompatible-pointer-types] - 93 | static TexturePtr* D_80BEB35C[] = { &gDotourEyebrowHighTex, &gDotourEyebrowMidTex, &gDotourEyebrowLowTex }; - | ^ -src/overlays/actors/ovl_En_Dt/z_en_dt.c:93:84: note: (near initialization for 'D_80BEB35C[2]') -src/overlays/actors/ovl_En_Dt/z_en_dt.c: In function 'EnDt_Update': -src/overlays/actors/ovl_En_Dt/z_en_dt.c:649:50: warning: passing argument 3 of 'CollisionCheck_SetOC' from incompatible pointer type [-Wincompatible-pointer-types] - 649 | CollisionCheck_SetOC(play, &play->colChkCtx, &this->collider); - | ^~~~~~~~~~~~~~~ - | | - | ColliderCylinder * -In file included from include/z64actor.h:9, - from include/z64.h:31, +cc: Warning: -mips3 should not be used for ucode 32-bit compiles +cc: Warning: -mips3 should not be used for ucode 32-bit compiles +src/audio/voice_internal.c: In function 'func_801A5228': +src/audio/voice_internal.c:89:51: warning: passing argument 2 of 'osVoiceSetWord' from incompatible pointer type [-Wincompatible-pointer-types] + 89 | errorCode = osVoiceSetWord(&gVoiceHandle, &dict->words[i]); + | ^~~~~~~~~~~~~~~ + | | + | u16 (*)[15] {aka short unsigned int (*)[15]} +In file included from include/PR/controller_voice.h:5, + from include/ultra64.h:9, + from include/z64.h:11, from include/global.h:4, - from src/overlays/actors/ovl_En_Dt/z_en_dt.h:4, - from src/overlays/actors/ovl_En_Dt/z_en_dt.c:7: -include/z64collision_check.h:576:92: note: expected 'Collider *' but argument is of type 'ColliderCylinder *' - 576 | s32 CollisionCheck_SetOC(struct PlayState* play, CollisionCheckContext* colCtxt, Collider* collider); - | ~~~~~~~~~~^~~~~~~~ -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 90: Incompatible pointer type assignment - static TexturePtr* D_80BEB348[] = { &gDotourEyeShockTex, &gDotourEyeOpenTex, &gDotourEyeClosedTex, - ------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 90: Incompatible pointer type assignment - static TexturePtr* D_80BEB348[] = { &gDotourEyeShockTex, &gDotourEyeOpenTex, &gDotourEyeClosedTex, - ---------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 90: Incompatible pointer type assignment - static TexturePtr* D_80BEB348[] = { &gDotourEyeShockTex, &gDotourEyeOpenTex, &gDotourEyeClosedTex, - -----------------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 91: Incompatible pointer type assignment - &gDotourEyeLookDownTex, &gDotourEyeSquintTex }; - ------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 91: Incompatible pointer type assignment - &gDotourEyeLookDownTex, &gDotourEyeSquintTex }; - ------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 93: Incompatible pointer type assignment - static TexturePtr* D_80BEB35C[] = { &gDotourEyebrowHighTex, &gDotourEyebrowMidTex, &gDotourEyebrowLowTex }; - ------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 93: Incompatible pointer type assignment - static TexturePtr* D_80BEB35C[] = { &gDotourEyebrowHighTex, &gDotourEyebrowMidTex, &gDotourEyebrowLowTex }; - ------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 93: Incompatible pointer type assignment - static TexturePtr* D_80BEB35C[] = { &gDotourEyebrowHighTex, &gDotourEyebrowMidTex, &gDotourEyebrowLowTex }; - -----------------------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_En_Dt/z_en_dt.c, line 649: Incompatible pointer type assignment - CollisionCheck_SetOC(play, &play->colChkCtx, &this->collider); - -------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -src/overlays/actors/ovl_En_An/z_en_an.c: In function 'EnAn_Talk': -src/overlays/actors/ovl_En_An/z_en_an.c:3220:52: warning: passing argument 3 of 'MsgEvent_RunScript' from incompatible pointer type [-Wincompatible-pointer-types] - 3220 | if (MsgEvent_RunScript(&this->actor, play, this->msgEventScript, this->msgEventFunc, &this->msgScriptResumePos)) { - | ~~~~^~~~~~~~~~~~~~~~ - | | - | s32 * {aka int *} -In file included from include/global.h:5, - from src/overlays/actors/ovl_En_An/z_en_an.h:4, - from src/overlays/actors/ovl_En_An/z_en_an.c:7: -include/functions.h:778:66: note: expected 'MsgScript *' {aka 'unsigned char *'} but argument is of type 's32 *' {aka 'int *'} - 778 | s32 MsgEvent_RunScript(Actor* actor, PlayState* play, MsgScript* script, MsgEventCallback callback, s32* pos); - | ~~~~~~~~~~~^~~~~~ -cfe: Warning 709: src/overlays/actors/ovl_En_An/z_en_an.c, line 3220: Incompatible pointer type assignment - if (MsgEvent_RunScript(&this->actor, play, this->msgEventScript, this->msgEventFunc, &this->msgScriptResumePos)) { - ---------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c: In function 'DemoMoonend_Init': -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:49:44: warning: passing argument 2 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 49 | func_80183430(&this->skeletonInfo, &object_moonend_Blob_00B5A0, &object_moonend_Blob_001214, this->jointTable, - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -In file included from include/global.h:5, - from src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.h:4, - from src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:7: -include/functions.h:1155:66: note: expected 'Struct_801BFA14_Arg1 *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:49:73: warning: passing argument 3 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 49 | func_80183430(&this->skeletonInfo, &object_moonend_Blob_00B5A0, &object_moonend_Blob_001214, this->jointTable, - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1155:89: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:50:27: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 50 | this->morphTable, NULL); - | ~~~~^~~~~~~~~~~~ + from src/audio/voice_internal.c:1: +include/PR/os_voice.h:60:43: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'u16 (*)[15]' {aka 'short unsigned int (*)[15]'} + 60 | s32 osVoiceSetWord(OSVoiceHandle* hd, u8* word); + | ~~~~^~~~ +src/audio/voice_internal.c:93:27: warning: passing argument 1 of 'func_801A5A1C' from incompatible pointer type [-Wincompatible-pointer-types] + 93 | func_801A5A1C(&dict->words[i]); + | ^~~~~~~~~~~~~~~ | | - | Vec3s * -include/functions.h:1155:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~^~~~ -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:51:44: warning: passing argument 2 of 'func_801834A8' from incompatible pointer type [-Wincompatible-pointer-types] - 51 | func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1157:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1157 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c: In function 'func_80C17C48': -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:113:56: warning: passing argument 2 of 'func_801834A8' from incompatible pointer type [-Wincompatible-pointer-types] - 113 | func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1157:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1157 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:119:56: warning: passing argument 2 of 'func_801834A8' from incompatible pointer type [-Wincompatible-pointer-types] - 119 | func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1157:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1157 | void func_801834A8(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c: In function 'DemoMoonend_Draw': -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:203:55: warning: passing argument 4 of 'func_8018450C' from incompatible pointer type [-Wincompatible-pointer-types] - 203 | func_8018450C(play, &this->skeletonInfo, mtx, func_80C17E70, func_80C17EE0, &this->actor); - | ^~~~~~~~~~~~~ - | | - | s32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *) {aka int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)} -include/functions.h:1172:98: note: expected 'OverrideKeyframeDrawScaled' {aka 'int (*)(struct PlayState *, struct SkeletonInfo *, int, Gfx **, unsigned char *, void *, Vec3f *, Vec3s *, Vec3f *)'} but argument is of type 's32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *)' {aka 'int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)'} - 1172 | void func_8018450C(PlayState* play, SkeletonInfo* skeleton, Mtx* mtx, OverrideKeyframeDrawScaled overrideKeyframeDraw, PostKeyframeDrawScaled postKeyframeDraw, void* arg); - | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ -src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c:203:70: warning: passing argument 5 of 'func_8018450C' from incompatible pointer type [-Wincompatible-pointer-types] - 203 | func_8018450C(play, &this->skeletonInfo, mtx, func_80C17E70, func_80C17EE0, &this->actor); - | ^~~~~~~~~~~~~ - | | - | s32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *) {aka int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)} -include/functions.h:1172:143: note: expected 'PostKeyframeDrawScaled' {aka 'void (*)(struct PlayState *, struct SkeletonInfo *, int, Gfx **, unsigned char *, void *, Vec3f *, Vec3s *, Vec3f *)'} but argument is of type 's32 (*)(PlayState *, SkeletonInfo *, s32, Gfx **, u8 *, Actor *, Vec3f *, Vec3s *, Vec3f *)' {aka 'int (*)(PlayState *, SkeletonInfo *, int, Gfx **, unsigned char *, Actor *, Vec3f *, Vec3s *, Vec3f *)'} - 1172 | void func_8018450C(PlayState* play, SkeletonInfo* skeleton, Mtx* mtx, OverrideKeyframeDrawScaled overrideKeyframeDraw, PostKeyframeDrawScaled postKeyframeDraw, void* arg); - | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 49: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, &object_moonend_Blob_00B5A0, &object_moonend_Blob_001214, this->jointTable, - -------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 49: Incompatible pointer type assignment - func_80183430(&this->skeletonInfo, &object_moonend_Blob_00B5A0, &object_moonend_Blob_001214, this->jointTable, - ------------------------------------------------------------------------^ + | u16 (*)[15] {aka short unsigned int (*)[15]} +src/audio/voice_internal.c:6:5: note: expected 's8 *' {aka 'signed char *'} but argument is of type 'u16 (*)[15]' {aka 'short unsigned int (*)[15]'} + 6 | u8* func_801A5A1C(s8* words); + | ^~~~~~~~~~~~~ +src/audio/voice_internal.c: In function 'func_801A5A1C': +src/audio/voice_internal.c:325:30: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness [-Wpointer-sign] + 325 | u8 numSyllables = strlen(words); // technically twice the num of syllables + | ^~~~~ + | | + | s8 * {aka signed char *} +In file included from src/audio/voice_internal.c:3: +include/libc/string.h:8:27: note: expected 'const char *' but argument is of type 's8 *' {aka 'signed char *'} + 8 | size_t strlen(const char* s); + | ~~~~~~~~~~~~^ +src/audio/voice_internal.c:349:12: warning: pointer targets in returning 'char *' from a function with return type 'u8 *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign] + 349 | return D_801FD610; + | ^~~~~~~~~~ +cfe: Warning 709: src/audio/voice_internal.c, line 89: Incompatible pointer type assignment + errorCode = osVoiceSetWord(&gVoiceHandle, &dict->words[i]); + --------------------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 50: Incompatible pointer type assignment - this->morphTable, (void*)0 ); +cfe: Warning 709: src/audio/voice_internal.c, line 93: Incompatible pointer type assignment + func_801A5A1C(&dict->words[i]); --------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 51: Incompatible pointer type assignment - func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); - -------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 113: Incompatible pointer type assignment - func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); - -------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 119: Incompatible pointer type assignment - func_801834A8(&this->skeletonInfo, &object_moonend_Blob_001214); - -------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 203: Incompatible pointer type assignment - func_8018450C(play, &this->skeletonInfo, mtx, func_80C17E70, func_80C17EE0, &this->actor); - ------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Moonend/z_demo_moonend.c, line 203: Incompatible pointer type assignment - func_8018450C(play, &this->skeletonInfo, mtx, func_80C17E70, func_80C17EE0, &this->actor); - ---------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c: In function 'DemoSyoten_Init': -src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c:76:43: warning: passing argument 2 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 76 | func_80183430(&this->unk_144, &object_syoten_Blob_001328, &object_syoten_Blob_00023C, this->unk_174, - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -In file included from include/global.h:5, - from src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.h:4, - from src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c:7: -include/functions.h:1155:66: note: expected 'Struct_801BFA14_Arg1 *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c:76:71: warning: passing argument 3 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 76 | func_80183430(&this->unk_144, &object_syoten_Blob_001328, &object_syoten_Blob_00023C, this->unk_174, - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1155:89: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c:77:31: warning: passing argument 5 of 'func_80183430' from incompatible pointer type [-Wincompatible-pointer-types] - 77 | this->unk_2A6, NULL); - | ~~~~^~~~~~~~~ - | | - | Vec3s * -include/functions.h:1155:118: note: expected 's16 *' {aka 'short int *'} but argument is of type 'Vec3s *' - 1155 | void func_80183430(SkeletonInfo* skeleton, Struct_801BFA14_Arg1* arg1, SkeletonInfo_1C* arg2, Vec3s* frameData, s16* arg4, UnkKeyframeCallback* callbacks); - | ~~~~~^~~~ -src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c:78:43: warning: passing argument 2 of 'func_801835EC' from incompatible pointer type [-Wincompatible-pointer-types] - 78 | func_801835EC(&this->unk_144, &object_syoten_Blob_00023C); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | u8 (*)[] {aka unsigned char (*)[]} -include/functions.h:1160:61: note: expected 'SkeletonInfo_1C *' but argument is of type 'u8 (*)[]' {aka 'unsigned char (*)[]'} - 1160 | void func_801835EC(SkeletonInfo* skeleton, SkeletonInfo_1C* arg1); - | ~~~~~~~~~~~~~~~~~^~~~ -cfe: Warning 709: src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c, line 76: Incompatible pointer type assignment - func_80183430(&this->unk_144, &object_syoten_Blob_001328, &object_syoten_Blob_00023C, this->unk_174, - ------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c, line 76: Incompatible pointer type assignment - func_80183430(&this->unk_144, &object_syoten_Blob_001328, &object_syoten_Blob_00023C, this->unk_174, - ----------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c, line 77: Incompatible pointer type assignment - this->unk_2A6, (void*)0 ); - ------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Demo_Syoten/z_demo_syoten.c, line 78: Incompatible pointer type assignment - func_801835EC(&this->unk_144, &object_syoten_Blob_00023C); - ------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -In file included from include/PR/mbi.h:61, - from include/PR/gbi.h:1, - from include/ultra64.h:5, - from include/z64.h:11, - from include/global.h:4, - from src/overlays/actors/ovl_Boss_07/z_boss_07.h:4, - from src/overlays/actors/ovl_Boss_07/z_boss_07.c:7: -include/PR/gbi.h:3449:54: warning: comparison between 'enum MajorasIncarnationLimb' and 'enum MajorasWrathLimb' [-Wenum-compare] - 3449 | #define MAX(a, b) ((a) > (b) ? (a) : (b)) - | ^ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:28: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:55: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:82:35: note: in expansion of macro 'MAJORAS_LIMB_COUNT' - 82 | /* 0x01DC */ Vec3s jointTable[MAJORAS_LIMB_COUNT]; - | ^~~~~~~~~~~~~~~~~~ -include/PR/gbi.h:3449:54: warning: comparison between 'enum MajorasIncarnationLimb' and 'enum MajorasWrathLimb' [-Wenum-compare] - 3449 | #define MAX(a, b) ((a) > (b) ? (a) : (b)) - | ^ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:28: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:55: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:82:35: note: in expansion of macro 'MAJORAS_LIMB_COUNT' - 82 | /* 0x01DC */ Vec3s jointTable[MAJORAS_LIMB_COUNT]; - | ^~~~~~~~~~~~~~~~~~ -include/PR/gbi.h:3449:54: warning: comparison between 'enum MajorasIncarnationLimb' and 'enum MajorasWrathLimb' [-Wenum-compare] - 3449 | #define MAX(a, b) ((a) > (b) ? (a) : (b)) - | ^ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:28: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:55: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:83:35: note: in expansion of macro 'MAJORAS_LIMB_COUNT' - 83 | /* 0x0284 */ Vec3s morphTable[MAJORAS_LIMB_COUNT]; - | ^~~~~~~~~~~~~~~~~~ -include/PR/gbi.h:3449:54: warning: comparison between 'enum MajorasIncarnationLimb' and 'enum MajorasWrathLimb' [-Wenum-compare] - 3449 | #define MAX(a, b) ((a) > (b) ? (a) : (b)) - | ^ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:28: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:14:55: note: in expansion of macro 'MAX' - 14 | #define MAJORAS_LIMB_COUNT MAX(MAJORAS_MASK_LIMB_MAX, MAX(MAJORAS_INCARNATION_LIMB_MAX, MAJORAS_WRATH_LIMB_MAX)) - | ^~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.h:83:35: note: in expansion of macro 'MAJORAS_LIMB_COUNT' - 83 | /* 0x0284 */ Vec3s morphTable[MAJORAS_LIMB_COUNT]; - | ^~~~~~~~~~~~~~~~~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.c: In function 'Boss07_Wrath_GrabPlayer': -src/overlays/actors/ovl_Boss_07/z_boss_07.c:1626:71: warning: passing argument 4 of 'Actor_GetPlayerImpact' from incompatible pointer type [-Wincompatible-pointer-types] - 1626 | if ((Actor_GetPlayerImpact(play, 1000.0f, &this->actor.world.pos, &sp2C) >= 0.0f) && (sp2C == 1)) { - | ^~~~~ - | | - | s32 * {aka int *} -In file included from include/global.h:5: -include/functions.h:303:85: note: expected 'PlayerImpactType *' but argument is of type 's32 *' {aka 'int *'} - 303 | f32 Actor_GetPlayerImpact(PlayState* play, f32 range, Vec3f* pos, PlayerImpactType* type); - | ~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.c: In function 'Boss07_Wrath_ThrowPlayer': -src/overlays/actors/ovl_Boss_07/z_boss_07.c:1663:75: warning: passing argument 4 of 'Actor_GetPlayerImpact' from incompatible pointer type [-Wincompatible-pointer-types] - 1663 | if ((Actor_GetPlayerImpact(play, 1000.0f, &this->actor.world.pos, &sp30) >= 0.0f) && (sp30 == 1)) { - | ^~~~~ - | | - | s32 * {aka int *} -include/functions.h:303:85: note: expected 'PlayerImpactType *' but argument is of type 's32 *' {aka 'int *'} - 303 | f32 Actor_GetPlayerImpact(PlayState* play, f32 range, Vec3f* pos, PlayerImpactType* type); - | ~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.c: In function 'Boss07_Wrath_WhipCollisionCheck': -src/overlays/actors/ovl_Boss_07/z_boss_07.c:1898:75: warning: passing argument 4 of 'Actor_GetPlayerImpact' from incompatible pointer type [-Wincompatible-pointer-types] - 1898 | if ((Actor_GetPlayerImpact(play, 1000.0f, &this->actor.world.pos, &sp98) >= 0.0f) && (sp98 != 1)) { - | ^~~~~ - | | - | s32 * {aka int *} -include/functions.h:303:85: note: expected 'PlayerImpactType *' but argument is of type 's32 *' {aka 'int *'} - 303 | f32 Actor_GetPlayerImpact(PlayState* play, f32 range, Vec3f* pos, PlayerImpactType* type); - | ~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.c: In function 'Boss07_Incarnation_Run': -src/overlays/actors/ovl_Boss_07/z_boss_07.c:3211:68: warning: passing argument 4 of 'Actor_GetPlayerImpact' from incompatible pointer type [-Wincompatible-pointer-types] - 3211 | if ((Actor_GetPlayerImpact(play, 5.0f, &this->actor.world.pos, &sp2C) >= 0.0f) && (sp2C == 0)) { - | ^~~~~ - | | - | s32 * {aka int *} -include/functions.h:303:85: note: expected 'PlayerImpactType *' but argument is of type 's32 *' {aka 'int *'} - 303 | f32 Actor_GetPlayerImpact(PlayState* play, f32 range, Vec3f* pos, PlayerImpactType* type); - | ~~~~~~~~~~~~~~~~~~^~~~ -src/overlays/actors/ovl_Boss_07/z_boss_07.c: In function 'Boss07_Top_CollisionCheck': -src/overlays/actors/ovl_Boss_07/z_boss_07.c:5795:72: warning: passing argument 4 of 'Actor_GetPlayerImpact' from incompatible pointer type [-Wincompatible-pointer-types] - 5795 | if ((Actor_GetPlayerImpact(play, 5.0f, &this->actor.world.pos, &sp3C) >= 0.0f) && (sp3C == 0)) { - | ^~~~~ - | | - | s32 * {aka int *} -include/functions.h:303:85: note: expected 'PlayerImpactType *' but argument is of type 's32 *' {aka 'int *'} - 303 | f32 Actor_GetPlayerImpact(PlayState* play, f32 range, Vec3f* pos, PlayerImpactType* type); - | ~~~~~~~~~~~~~~~~~~^~~~ -cfe: Warning 624: /home/louist103/mm-hm/src/overlays/actors/ovl_Boss_07/z_boss_07.h, line 29: Trailing comma in enumerator list - MAJORAS_REMAINS = 200, - ---------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 51: Trailing comma in enumerator list - MAJORAS_WRATH_DMGEFF_F, - ----------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 64: Trailing comma in enumerator list - MAJORAS_INCARNATION_DMGEFF_F, - ----------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 73: Trailing comma in enumerator list - MAJORAS_MASK_DMGEFF_F = 0xF, - ---------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 86: Trailing comma in enumerator list - MAJORAS_REMAINS_DMGEFF_F, - ------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 96: Trailing comma in enumerator list - MAJORAS_TOP_DMGEFF_F, - --------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 121: Trailing comma in enumerator list - MAJORAS_WRATH_ATTACK_MAX, - ------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 128: Trailing comma in enumerator list - MAJORAS_INCARNATION_STATE_MAX, - -----------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 135: Trailing comma in enumerator list - MAJORAS_MASK_SPIN_STATE_MAX, - ---------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 145: Trailing comma in enumerator list - MAJORAS_MASK_BEAM_STATE_MAX, - ---------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 151: Trailing comma in enumerator list - MAJORAS_PROJECTILE_STATE_MAX, - ----------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 160: Trailing comma in enumerator list - MAJORAS_REMAINS_ACTIVATE = 20, - -----------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 167: Trailing comma in enumerator list - MAJORAS_REMAINS_CS_ATTACH, - -------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 173: Trailing comma in enumerator list - MAJORAS_TOP_STATE_MAX, - ---------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 181: Trailing comma in enumerator list - MAJORAS_MASK_INTRO_STATE_4, - --------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 189: Trailing comma in enumerator list - MAJORAS_MASK_DEATH_STATE_4, - --------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 198: Trailing comma in enumerator list - MAJORAS_INCARNATION_INTRO_STATE_5, - ---------------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 207: Trailing comma in enumerator list - MAJORAS_INCARNATION_DEATH_STATE_10 = 10, - ---------------------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 212: Trailing comma in enumerator list - MAJORAS_WRATH_INTRO_STATE_1, - ---------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 220: Trailing comma in enumerator list - MAJORAS_WRATH_DEATH_STATE_4, - ---------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 233: Trailing comma in enumerator list - MAJORAS_DAMAGE_STATE_41, +cfe: Warning 709: src/audio/voice_internal.c, line 325: Incompatible pointer type assignment + u8 numSyllables = strlen(words); -----------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 243: Trailing comma in enumerator list - MAJORAS_STATIC_CS_STATE_6, - -------------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 709: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 1626: Incompatible pointer type assignment - if ((Actor_GetPlayerImpact(play, 1000.0f, &this->actor.world.pos, &sp2C) >= 0.0f) && (sp2C == 1)) { - ----------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 1663: Incompatible pointer type assignment - if ((Actor_GetPlayerImpact(play, 1000.0f, &this->actor.world.pos, &sp30) >= 0.0f) && (sp30 == 1)) { - --------------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 1898: Incompatible pointer type assignment - if ((Actor_GetPlayerImpact(play, 1000.0f, &this->actor.world.pos, &sp98) >= 0.0f) && (sp98 != 1)) { - --------------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 624: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 2522: Trailing comma in enumerator list - MAJORAS_WRATH_PART_MAX, - --------------------------^ -The use of a trailing comma in an enumerator list is not standard C. There -may be portability problems. -cfe: Warning 709: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 3211: Incompatible pointer type assignment - if ((Actor_GetPlayerImpact(play, 5.0f, &this->actor.world.pos, &sp2C) >= 0.0f) && (sp2C == 0)) { - -------------------------------------------------------------------^ -The type pointed to by the left-hand side of simple assignment -statement is incompatible with the type pointed to by the right-hand side. -cfe: Warning 709: src/overlays/actors/ovl_Boss_07/z_boss_07.c, line 5795: Incompatible pointer type assignment - if ((Actor_GetPlayerImpact(play, 5.0f, &this->actor.world.pos, &sp3C) >= 0.0f) && (sp3C == 0)) { - -----------------------------------------------------------------------^ The type pointed to by the left-hand side of simple assignment statement is incompatible with the type pointed to by the right-hand side. cfe: Warning 835: src/code/speed_meter.c, line 225: No prototype for the call to ZeldaArena_IsInitialized @@ -895,12 +300,32 @@ cfe: Warning 835: src/code/speed_meter.c, line 225: No prototype for the call to ------------------------------------^ To achieve better type-checking, there should be a full prototype for the function being called. -src/code/z_map_disp.c: In function 'MapDisp_AwaitGameplayDangeonKeep': -src/code/z_map_disp.c:539:9: warning: the comparison will always evaluate as 'true' for the address of 'objectCtx' will never be NULL [-Waddress] - 539 | if (&play->objectCtx) {} - | ^ -In file included from include/global.h:4, - from src/code/z_map_disp.c:1: -include/z64.h:224:33: note: 'objectCtx' declared here - 224 | /* 0x17D88 */ ObjectContext objectCtx; - | ^~~~~~~~~ +src/code/z_map_disp.c: In function 'MapDisp_AllocDungeonMap': +src/code/z_map_disp.c:1200:72: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] + 1200 | sPauseDungeonMap.mapI_roomTextures[dungeonMapRoomIter + 1] = + | ^ +src/code/z_map_disp.c:1204:22: warning: assignment to 'void *' from 's32' {aka 'int'} makes pointer from integer without a cast [-Wint-conversion] + 1204 | heapNext = (intptr_t)sPauseDungeonMap.mapI_roomTextures[dungeonMapRoomIter] + + | ^ +src/code/c_keyframe.c: In function 'func_8018410C': +src/code/c_keyframe.c:419:59: warning: passing argument 3 of '*(skeleton->unk_20 + (sizetype)((unsigned int)limb->unk_6 * 4))' makes pointer from integer without a cast [-Wint-conversion] + 419 | skeleton->unk_20[limb->unk_6](play, skeleton, *limbIndex, &newDList, &flags, arg) != 0) { + | ^~~~~~~~~~ + | | + | s32 {aka int} +src/code/c_keyframe.c:419:59: note: expected 's32 *' {aka 'int *'} but argument is of type 's32' {aka 'int'} +src/code/c_keyframe.c: In function 'func_80184914': +src/code/c_keyframe.c:544:22: warning: assignment to 'Vec3s *' {aka 'struct *'} from 's32' {aka 'int'} makes pointer from integer without a cast [-Wint-conversion] + 544 | skeleton->unk_2C = arg9; + | ^ +src/code/z_parameter.c: In function 'Interface_LoadAButtonDoActionLabel': +src/code/z_parameter.c:3276:67: warning: passing argument 2 of 'DmaMgr_SendRequestImpl' makes pointer from integer without a cast [-Wint-conversion] + 3276 | (u32)interfaceCtx->doActionSegment + (loadOffset * DO_ACTION_TEX_SIZE), + | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | unsigned int +In file included from include/global.h:5, + from src/code/z_parameter.c:1: +include/functions.h:17:55: note: expected 'void *' but argument is of type 'unsigned int' + 17 | s32 DmaMgr_SendRequestImpl(DmaRequest* request, void* vramStart, uintptr_t vromStart, size_t size, UNK_TYPE4 unused, OSMesgQueue* queue, void* msg); + | ~~~~~~^~~~~~~~~ -- cgit v1.2.3