summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOtherBlue <93625085+OtherBlue@users.noreply.github.com>2025-07-03 01:35:49 -0300
committerGitHub <noreply@github.com>2025-07-02 21:35:49 -0700
commitdfa10383e400d06f1100082c1ca786a743f6ac79 (patch)
tree54dbba2d9fc03456168fa6c76bb6829a25c704b0
parent32683e2a748da238250de1f192d2fe36eee976d3 (diff)
Split Skip Pickup Messages (#5648)
* Split Skip Pickup Messages following ZFG's comment https://youtube.com/clip/UgkxF-LDaR-zyTkqSkqtP3dkLrCca_KGScIw?si=RJY9SIG8QKSiWgVl splits the Skip Pickup Messages time saver for consumables and bottle pickups * CVar updates I missed * another cvar I missed
-rw-r--r--soh/soh/SohGui/SohMenuEnhancements.cpp7
-rw-r--r--soh/src/overlays/actors/ovl_player_actor/z_player.c6
2 files changed, 8 insertions, 5 deletions
diff --git a/soh/soh/SohGui/SohMenuEnhancements.cpp b/soh/soh/SohGui/SohMenuEnhancements.cpp
index 8e1e94c08..c08e9c7ba 100644
--- a/soh/soh/SohGui/SohMenuEnhancements.cpp
+++ b/soh/soh/SohGui/SohMenuEnhancements.cpp
@@ -353,9 +353,12 @@ void SohMenu::AddMenuEnhancements() {
"Door Switch CS, Water Temple Dragon Switch CS, and the Box Skip One Point in Jabu."));
AddWidget(path, "Text", WIDGET_SEPARATOR_TEXT);
- AddWidget(path, "Skip Pickup Messages", WIDGET_CVAR_CHECKBOX)
+ AddWidget(path, "Skip Bottle Pickup Messages", WIDGET_CVAR_CHECKBOX)
+ .CVar(CVAR_ENHANCEMENT("FastBottles"))
+ .Options(CheckboxOptions().Tooltip("Skip Pickup Messages for Bottle Swipes."));
+ AddWidget(path, "Skip Consumable Item Pickup Messages", WIDGET_CVAR_CHECKBOX)
.CVar(CVAR_ENHANCEMENT("FastDrops"))
- .Options(CheckboxOptions().Tooltip("Skip Pickup Messages for new Consumable Items and Bottle Swipes."));
+ .Options(CheckboxOptions().Tooltip("Skip Pickup Messages for new Consumable Items."));
AddWidget(path, "Skip Forced Dialog", WIDGET_CVAR_COMBOBOX)
.CVar(CVAR_ENHANCEMENT("TimeSavers.SkipForcedDialog"))
.Options(ComboboxOptions()
diff --git a/soh/src/overlays/actors/ovl_player_actor/z_player.c b/soh/src/overlays/actors/ovl_player_actor/z_player.c
index b2ebcbb88..777de3e59 100644
--- a/soh/src/overlays/actors/ovl_player_actor/z_player.c
+++ b/soh/src/overlays/actors/ovl_player_actor/z_player.c
@@ -14697,7 +14697,7 @@ void Player_Action_SwingBottle(Player* this, PlayState* play) {
if (LinkAnimation_Update(play, &this->skelAnime)) {
if (this->av1.bottleCatchType != BOTTLE_CATCH_NONE) {
if (!this->av2.startedTextbox) {
- if (CVarGetInteger(CVAR_ENHANCEMENT("FastDrops"), 0)) {
+ if (CVarGetInteger(CVAR_ENHANCEMENT("FastBottles"), 0)) {
this->av1.bottleCatchType = BOTTLE_CATCH_NONE;
} else {
// 1 is subtracted because `sBottleCatchInfo` does not have an entry for `BOTTLE_CATCH_NONE`
@@ -14740,13 +14740,13 @@ void Player_Action_SwingBottle(Player* this, PlayState* play) {
this->av1.bottleCatchType = i + 1;
this->av2.startedTextbox = false;
- if (!CVarGetInteger(CVAR_ENHANCEMENT("FastDrops"), 0)) {
+ if (!CVarGetInteger(CVAR_ENHANCEMENT("FastBottles"), 0)) {
this->stateFlags1 |= PLAYER_STATE1_IN_ITEM_CS | PLAYER_STATE1_IN_CUTSCENE;
}
this->interactRangeActor->parent = &this->actor;
Player_UpdateBottleHeld(play, this, catchInfo->itemId, ABS(catchInfo->itemAction));
- if (!CVarGetInteger(CVAR_ENHANCEMENT("FastDrops"), 0)) {
+ if (!CVarGetInteger(CVAR_ENHANCEMENT("FastBottles"), 0)) {
Player_AnimPlayOnceAdjusted(play, this, swingEntry->catchAnimation);
func_80835EA4(play, 4);
}