diff options
| author | coco875 <59367621+coco875@users.noreply.github.com> | 2024-01-01 03:56:14 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-31 19:56:14 -0700 |
| commit | 98474c5b94e453fcee4d332657e45b2f626c62a3 (patch) | |
| tree | f68be5a0abfb02c0dbd25d6297c67f041ca18598 /src/audio | |
| parent | 2727a5e5ddc3bc439b2d0b7f2e681650b79b2fb5 (diff) | |
fix todo, bug not appears and change theme (#525)
* fix todo, bug not appears and change theme
* fix warning
Diffstat (limited to 'src/audio')
| -rw-r--r-- | src/audio/data.c | 4 | ||||
| -rw-r--r-- | src/audio/internal.h | 4 | ||||
| -rw-r--r-- | src/audio/load.c | 10 | ||||
| -rw-r--r-- | src/audio/port_eu.c | 2 | ||||
| -rw-r--r-- | src/audio/seqplayer.c | 8 |
5 files changed, 16 insertions, 12 deletions
diff --git a/src/audio/data.c b/src/audio/data.c index 1beb1378f..cc08fd832 100644 --- a/src/audio/data.c +++ b/src/audio/data.c @@ -213,7 +213,7 @@ s16 gUnknownWave7[256] = { s16 *gWaveSamples[6] = { sSawtoothWaves, sTriangleWaves, sSineWaves, sSquareWaves, sUnknownWave6, gUnknownWave7 }; -// TODO: file boundary? +//! @todo file boundary? u32 fill[2] = {0x00000000, 0x00000000}; // Transforms a pitch scale factor in -127..127 into a frequency scale factor @@ -343,7 +343,7 @@ struct AdsrEnvelope gDefaultEnvelope[] = { { BSWAP16(ADSR_HANG), 0 } // then continue staying there }; -// TODO 0x00000000800f624c fill2 +//! @todo 0x00000000800f624c fill2 u32 fill2 = 0x00000000; struct NoteSubEu gZeroNoteSub = { 0 }; diff --git a/src/audio/internal.h b/src/audio/internal.h index a8b4da076..33665af01 100644 --- a/src/audio/internal.h +++ b/src/audio/internal.h @@ -38,7 +38,7 @@ #define TEMPO_SCALE TATUMS_PER_BEAT -// TODO: US_FLOAT should probably be renamed to JP_DOUBLE since eu seems to use floats too +//! @todo US_FLOAT should probably be renamed to JP_DOUBLE since eu seems to use floats too #define US_FLOAT(x) x ## f #define US_FLOAT2(x) x @@ -440,7 +440,7 @@ struct Note { // that results in messy US/EU ifdefs. Instead we cast to a struct pointer // when needed... This breaks alignment on non-N64 platforms, which we hack // around by skipping the padding in that case. - // TODO: use macros or something instead. + //! @todo use macros or something instead. #ifdef TARGET_N64 u8 pad0[12]; #endif diff --git a/src/audio/load.c b/src/audio/load.c index 0580d89c7..e71a0a66c 100644 --- a/src/audio/load.c +++ b/src/audio/load.c @@ -669,7 +669,7 @@ void preload_sequence(u32 seqId, u8 preloadMask) { } if (preloadMask & PRELOAD_SEQUENCE) { - // @bug should be IS_SEQ_LOAD_COMPLETE + //! @bug should be IS_SEQ_LOAD_COMPLETE if (IS_BANK_LOAD_COMPLETE(seqId) == TRUE) { sequenceData = get_bank_or_seq(0, 2, seqId); } else { @@ -716,9 +716,11 @@ void load_sequence_internal(u32 player, u32 seqId, s32 loadAsync) { if (bank_load_async(bankId, 2, seqPlayer) == NULL) { return; } - // @bug This should set the last bank (i.e. the first in the JSON) - // as default, not the missing one. This code path never gets - // taken, though -- all sequence loading is synchronous. + /** + * @bug This should set the last bank (i.e. the first in the JSON) + * as default, not the missing one. This code path never gets + * taken, though -- all sequence loading is synchronous. + */ seqPlayer->defaultBank[0] = bankId; } else { if (load_banks_immediate(seqId, &seqPlayer->defaultBank[0]) == NULL) { diff --git a/src/audio/port_eu.c b/src/audio/port_eu.c index 6aee38579..7c1629696 100644 --- a/src/audio/port_eu.c +++ b/src/audio/port_eu.c @@ -255,7 +255,7 @@ void func_800CBBE8(u32 arg0, s8 arg1) { func_800CBB48(arg0, &sp34); } -// TODO: clenanup, something's weird with the variables. D_800EA4A4 is probably EuAudioCmd bc of the + 0x100 +//! @todo clenanup, something's weird with the variables. D_800EA4A4 is probably EuAudioCmd bc of the + 0x100 void func_800CBC24(void) { s32 temp_t6; diff --git a/src/audio/seqplayer.c b/src/audio/seqplayer.c index c91fb67b1..5deae9765 100644 --- a/src/audio/seqplayer.c +++ b/src/audio/seqplayer.c @@ -1578,9 +1578,11 @@ void init_sequence_players(void) { for (i = 0; i < ARRAY_COUNT(gSequenceChannels); i++) { gSequenceChannels[i].seqPlayer = NULL; gSequenceChannels[i].enabled = FALSE; - // @bug Size of wrong array. Zeroes out second half of gSequenceChannels[0], - // all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. - // However, this is only called at startup, so it's harmless. + /** + * @bug Size of wrong array. Zeroes out second half of gSequenceChannels[0], + * all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. + * However, this is only called at startup, so it's harmless. + */ #ifdef AVOID_UB #define LAYERS_SIZE LAYERS_MAX #else |
