diff options
| author | MegaMech <MegaMech@users.noreply.github.com> | 2024-08-02 17:04:08 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-02 17:04:08 -0600 |
| commit | 016b16a4845d51d32bbff97c29dbcf5509471e55 (patch) | |
| tree | 3268591e9cfb3f31ba66ffaed88bd6d97d68513a /src/spawn_players.c | |
| parent | 00067c03f66985ab894221f390cc92894be04945 (diff) | |
Fix menu bug & kart textures (#32)
* Fix menu bug
* Fix undefined behaviour
* Fix kart textures
* Fix boost texture
* Rename as per review
* Fix buffer overflows
---------
Co-authored-by: MegaMech <7255464+MegaMech@users.noreply.github.com>
Diffstat (limited to 'src/spawn_players.c')
| -rw-r--r-- | src/spawn_players.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/spawn_players.c b/src/spawn_players.c index 4eb4732c2..7f1547f02 100644 --- a/src/spawn_players.c +++ b/src/spawn_players.c @@ -1087,13 +1087,15 @@ void func_8003CD98(Player *player, Camera *camera, s8 playerId, s8 screenId) { load_kart_palette(player, playerId, screenId, 1); load_kart_texture(player, playerId, screenId, screenId, 0); //mio0decode((u8 *) &D_802DFB80[0][arg3][playerId], (u8 *) &D_802BFB80.arraySize8[0][arg3][playerId]); - memcpy(&D_802BFB80.arraySize8[0][screenId][playerId], &D_802DFB80[0][screenId][playerId], 0x1000); + // This memcpy does not seem to be required for some reason + //memcpy(&D_802BFB80.arraySize8[0][screenId][playerId], &D_802DFB80[0][screenId][playerId], 0x1000); } else { load_kart_palette(player, playerId, screenId, 0); load_kart_palette(player, playerId, screenId, 1); load_kart_texture(player, (s8) (playerId + 4), screenId, (s8) (screenId - 2), 0); //mio0decode((u8 *) &D_802DFB80[0][arg3 - 2][playerId + 4], (u8 *) &D_802BFB80.arraySize8[0][arg3 - 2][playerId + 4]); - memcpy(&D_802BFB80.arraySize8[0][screenId - 2][playerId + 4], &D_802DFB80[0][screenId - 2][playerId + 4], 0x1000); + // This memcpy does not seem to be required for some reason + //memcpy(&D_802BFB80.arraySize8[0][screenId - 2][playerId + 4], &D_802DFB80[0][screenId - 2][playerId + 4], 0x1000); } D_801650D0[screenId][playerId] = player->animFrameSelector[screenId]; |