summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKiritoDv <kiritodev01@gmail.com>2024-03-20 21:53:00 -0600
committerKiritoDv <kiritodev01@gmail.com>2024-03-20 21:53:00 -0600
commit98b3458d02163af517ed4c95c258217f889d937f (patch)
tree7f94ca5a91e8df224f9c22f6b5c3478edf34234c
parent8331218c72dd1fa72bbbb8004704c62821340795 (diff)
Added missing returns
-rw-r--r--src/factories/DisplayListFactory.cpp1
-rw-r--r--src/factories/sf64/MessageFactory.cpp1
-rw-r--r--src/factories/sf64/MessageLookupFactory.cpp1
-rw-r--r--src/factories/sf64/ObjInitFactory.cpp1
-rw-r--r--src/factories/sf64/SkeletonFactory.cpp2
-rw-r--r--src/factories/sm64/GeoLayoutFactory.cpp1
6 files changed, 6 insertions, 1 deletions
diff --git a/src/factories/DisplayListFactory.cpp b/src/factories/DisplayListFactory.cpp
index 8f55f3e..88965ad 100644
--- a/src/factories/DisplayListFactory.cpp
+++ b/src/factories/DisplayListFactory.cpp
@@ -293,6 +293,7 @@ ExportResult DListBinaryExporter::Export(std::ostream &write, std::shared_ptr<IP
}
writer.Finish(write);
+ return std::nullopt;
}
std::optional<std::shared_ptr<IParsedData>> DListFactory::parse(std::vector<uint8_t>& raw_buffer, YAML::Node& node) {
diff --git a/src/factories/sf64/MessageFactory.cpp b/src/factories/sf64/MessageFactory.cpp
index 9aa2c5b..8ac966f 100644
--- a/src/factories/sf64/MessageFactory.cpp
+++ b/src/factories/sf64/MessageFactory.cpp
@@ -146,6 +146,7 @@ ExportResult SF64::MessageBinaryExporter::Export(std::ostream &write, std::share
writer.Write(m);
}
writer.Finish(write);
+ return std::nullopt;
}
std::optional<std::shared_ptr<IParsedData>> SF64::MessageFactory::parse(std::vector<uint8_t>& buffer, YAML::Node& node) {
diff --git a/src/factories/sf64/MessageLookupFactory.cpp b/src/factories/sf64/MessageLookupFactory.cpp
index 5e8c38a..6a7b221 100644
--- a/src/factories/sf64/MessageLookupFactory.cpp
+++ b/src/factories/sf64/MessageLookupFactory.cpp
@@ -66,6 +66,7 @@ ExportResult SF64::MessageLookupBinaryExporter::Export(std::ostream &write, std:
writer.Write(m.ptr);
}
writer.Finish(write);
+ return std::nullopt;
}
std::optional<std::shared_ptr<IParsedData>> SF64::MessageLookupFactory::parse(std::vector<uint8_t>& buffer, YAML::Node& node) {
diff --git a/src/factories/sf64/ObjInitFactory.cpp b/src/factories/sf64/ObjInitFactory.cpp
index 3e6694e..791535c 100644
--- a/src/factories/sf64/ObjInitFactory.cpp
+++ b/src/factories/sf64/ObjInitFactory.cpp
@@ -65,6 +65,7 @@ ExportResult SF64::ObjInitBinaryExporter::Export(std::ostream &write, std::share
writer.Write(obj.id);
}
writer.Finish(write);
+ return std::nullopt;
}
std::optional<std::shared_ptr<IParsedData>> SF64::ObjInitFactory::parse(std::vector<uint8_t>& buffer, YAML::Node& node) {
diff --git a/src/factories/sf64/SkeletonFactory.cpp b/src/factories/sf64/SkeletonFactory.cpp
index 3701abe..8394ef3 100644
--- a/src/factories/sf64/SkeletonFactory.cpp
+++ b/src/factories/sf64/SkeletonFactory.cpp
@@ -92,7 +92,7 @@ ExportResult SF64::SkeletonCodeExporter::Export(std::ostream &write, std::shared
return OffsetEntry {
limbs[0].mAddr,
- (IS_SEGMENTED(limbs[0].mAddr) ? SEGMENT_OFFSET(limbs[0].mAddr) : limbs[0].mAddr) + skeleton->mSkeleton.size() * 0x24 + 4
+ static_cast<uint32_t>((IS_SEGMENTED(limbs[0].mAddr) ? SEGMENT_OFFSET(limbs[0].mAddr) : limbs[0].mAddr) + skeleton->mSkeleton.size() * 0x24 + 4)
};
}
diff --git a/src/factories/sm64/GeoLayoutFactory.cpp b/src/factories/sm64/GeoLayoutFactory.cpp
index f8bbc02..5f23254 100644
--- a/src/factories/sm64/GeoLayoutFactory.cpp
+++ b/src/factories/sm64/GeoLayoutFactory.cpp
@@ -185,6 +185,7 @@ ExportResult SM64::GeoBinaryExporter::Export(std::ostream&write, std::shared_ptr
output.Write(buffer.data(), buffer.size());
output.Finish(write);
output.Close();
+ return std::nullopt;
}
ExportResult SM64::GeoHeaderExporter::Export(std::ostream&write, std::shared_ptr<IParsedData> data, std::string&entryName, YAML::Node&node, std::string* replacement) {