From d2ac4a4500217ed31b7705cfb92b4255860521d9 Mon Sep 17 00:00:00 2001 From: Jeod <47716344+JeodC@users.noreply.github.com> Date: Sat, 11 Jul 2026 22:05:48 -0400 Subject: BK: Honor runtime dialog-pack flag in addition to modder flag (#226) --- src/factories/bk64/BKAssetFactory.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/factories/bk64/BKAssetFactory.cpp b/src/factories/bk64/BKAssetFactory.cpp index 6a0d903..ff346cc 100644 --- a/src/factories/bk64/BKAssetFactory.cpp +++ b/src/factories/bk64/BKAssetFactory.cpp @@ -704,12 +704,16 @@ std::optional> BKAssetFactory::parse(std::vector.o2r when no explicit binary name is -// given. Inert unless the rom config sets dialog_pack, so it's safe to call for any rom. +// given. Inert unless dialog-pack mode is requested, so it's safe to call for any rom. void BKAssetFactory::PreprocessConfig(YAML::Node& cfg, N64::Cartridge* cart) { - if (!cfg || !cfg["dialog_pack"] || !cfg["dialog_pack"].as()) { + const bool requested = (cfg && cfg["dialog_pack"] && cfg["dialog_pack"].as()) || + (Companion::Instance != nullptr && Companion::Instance->GetConfig().dialogPack); + if (!cfg || !requested) { return; } + cfg["dialog_pack"] = true; + std::string name; if (cfg["output"] && cfg["output"]["binary"]) { name = fs::path(cfg["output"]["binary"].as()).filename().string(); -- cgit v1.2.3