From 726ff528a3ab66afde92b5b6e70a96f168fee041 Mon Sep 17 00:00:00 2001
From: Anghelo Carvajal <angheloalf95@gmail.com>
Date: Fri, 4 Jun 2021 12:52:38 -0400
Subject: Optimize RAM usage and performance by removing redundant `rawData`
 (#148)

* Remove rawData from ZResource

* Remove dlistRawData and some leftovers extra params

* Run format

* Unused variable warning
---
 ZAPD/ZResource.cpp | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

(limited to 'ZAPD/ZResource.cpp')

diff --git a/ZAPD/ZResource.cpp b/ZAPD/ZResource.cpp
index 55e142f..f64ce4a 100644
--- a/ZAPD/ZResource.cpp
+++ b/ZAPD/ZResource.cpp
@@ -21,10 +21,8 @@ ZResource::ZResource(ZFile* nParent)
 	RegisterOptionalAttribute("Custom");
 }
 
-void ZResource::ExtractFromXML(tinyxml2::XMLElement* reader, const std::vector<uint8_t>& nRawData,
-                               const uint32_t nRawDataIndex)
+void ZResource::ExtractFromXML(tinyxml2::XMLElement* reader, uint32_t nRawDataIndex)
 {
-	rawData = nRawData;
 	rawDataIndex = nRawDataIndex;
 
 	if (reader != nullptr)
@@ -34,9 +32,8 @@ void ZResource::ExtractFromXML(tinyxml2::XMLElement* reader, const std::vector<u
 	CalcHash();
 }
 
-void ZResource::ExtractFromFile(const std::vector<uint8_t>& nRawData, uint32_t nRawDataIndex)
+void ZResource::ExtractFromFile(uint32_t nRawDataIndex)
 {
-	rawData = nRawData;
 	rawDataIndex = nRawDataIndex;
 
 	ParseRawData();
@@ -160,16 +157,6 @@ std::string ZResource::GetExternalExtension() const
 	return "";
 }
 
-const std::vector<uint8_t>& ZResource::GetRawData() const
-{
-	return rawData;
-}
-
-void ZResource::SetRawData(const std::vector<uint8_t>& nData)
-{
-	rawData = nData;
-}
-
 bool ZResource::WasDeclaredInXml() const
 {
 	return declaredInXml;
-- 
cgit v1.2.3