dolphin/Source/Core/AudioCommon/WaveFile.cpp, branch master

Remove unused imports

2026-01-25T15:12:15+00:00

Yellow squiggly lines begone!
Done automatically on .cpp files through `run-clang-tidy`, with manual corrections to the mistakes.
If an import is directly used, but is technically unnecessary since it's recursively imported by something else, it is *not* removed.
The tool doesn't touch .h files, so I did some of them by hand while fixing errors due to old recursive imports.
Not everything is removed, but the cleanup should be substantial enough.
Because this done on Linux, code that isn't used on it is mostly untouched.
(Hopefully no open PR is depending on these imports...)

WaveFile: Add m_ prefix to member variables

2025-06-01T18:41:09+00:00

Adjust order and spacing of various #includes

2024-07-26T21:28:34+00:00

Move some #includes around to match the Contributing guidelines.

Replace std::ostringstream usage with fmt::format

2023-06-18T23:37:32+00:00

WaveFile: Fix size check

2022-10-22T18:44:38+00:00

`count` is the number of stereo samples to write (where each stereo sample is two shorts), while `BUFFER_SIZE` is the size of the buffer in shorts.  So `count` needs to be multiplied by `2`, not `BUFFER_SIZE`.  Also, when this check was failed, the previous code just clobbered whatever was past the end of the buffer after logging the warning, which corrupted `basename`, eventually resulting in Dolphin crashing.

This affected Datel's Wii-compatible Action Replay, which uses a block size of 2298, or 18384 stereo samples, which is 36768 shorts, which is bigger than the buffer size of 32768. (However, the previous commit means that only one block is transfered at a time, eliminating this issue; fixing the bounds check is just a general safety thing instead of an actual bugfix now.)

Do not directly store input sample rate, rather just store a divisor for that sample rate, with it using a fixed dividend of 54000000 * 2.

2022-07-03T22:07:06+00:00

This should reduce (but not completely eliminate) gradual audio desyncs in dumps. This also allows for accurate sample rates for the GameCube.
Completely eliminating gradual audio desyncs will require resampling to an integer sample rate, as nothing seems to support a non-integer sample rate.

have audio dumps apply volume (fixes cases of audio dumps being "too loud" and in game audio controls having no effect)

2022-06-11T04:27:10+00:00

IOFile: Make origin parameter to Seek() an enum class.

2022-01-29T05:49:21+00:00

Port Main.DSP to MainSettings

2021-10-16T03:24:46+00:00

While trying to work on adding audiodump support for CLI, I was alerted that it was important to first try moving the DSP configs to the new config before continuing, as that makes it substantially easier to write clean code to add such a feature.

This commit aims to allow for Dolphin to only rely on the new config for DSP-related settings.

treewide: convert GPLv2+ license info to SPDX tags

2021-07-05T02:35:56+00:00

SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.