dolphin/Source/Core/DiscIO/WIABlob.cpp, branch release-prep-2506a

DiscIO: Pass parameters by constant reference

2025-04-20T06:26:09+00:00

Modernize `std::sort` with ranges and projections

2025-03-09T20:26:38+00:00

In PPCTables.cpp, the code is currently unused so I was unable to test it.

In CustomPipeline.cpp, a pointer to member function cannot be used due to 16.4.5.2.1 of the C++ Standard regarding "addressable functions". https://eel.is/c++draft/namespace.std#6

In Fs.cpp and DirectoryBlob.cpp, these examples used projections in a previous iteration of this commit, but no longer do. Still, they remain in this commit because the PR they would actually belong to is already merged.

Simplify `std::find_if` with `std::ranges::find` and projections

2025-03-09T20:26:35+00:00

In LabelMap.cpp, the code is currently unused so I was unable to test it.

In WiiUtils.cpp, the magic value `1u` was replaced by the constant value `DiscIO::PARTITION_UPDATE`.

Modernize `std::all_of` with ranges

2024-12-16T03:50:34+00:00

In DITSpecification.cpp, MaterialAsset.cpp, and ShaderAsset.cpp, lambda predicates were replaced by pointers to member functions because ranges algorithms are able invoke those.

In NetPlayClient.cpp, the non-trivial `NetPlay::Player` elements were being passed by value in `NetPlayClient::DoAllPlayersHaveGame()`. This has been fixed.

In WIABlob.cpp, the second example's predicate was returning the `std::optional` by value instead of implicitly converting it to a bool. This has been fixed.

Simplify `std::copy` with `std::copy_n`

2024-10-07T22:34:56+00:00

+ a surprise `std::memcpy` in VolumeVerifier.cpp.

DiscIO: Fix a typo in an RVZPack comment

2024-09-08T10:38:10+00:00

RVZ: Fix undefined behaviour when copying 0 bytes to a null pointer

2024-08-27T16:16:43+00:00

A vector of length 0 can have a null data pointer, which causes UB when
passed to memcpy, so only copy when we actually have data to copy. This
caused crashes in certain cases when compiling Dolphin with Clang and
LTO enabled.

Remove redundant semicolons

2024-08-20T12:59:54+00:00

Added CopyReader to BlobReader and all subclasses

2023-10-01T13:04:06+00:00

A deep-copy method CopyReader has been added to BlobReader (virtual) and all of its subclasses (override). This should create a second BlobReader to open the same set of data but with an independent read pointer so that it doesn't interfere with any reads done on the original Reader.

As part of this, IOFile has added code to create a deep copy IOFile pointer onto the same file, with code based on the platform in question to find the file ID from the file pointer and open a new one. There has also been a small piece added to FileInfo to enable a deep copy, but its only subclass at this time already had a copy constructor so this was relatively minor.

DiscIO: Improve comments in WIARVZFileReader::Convert

2023-05-16T16:58:07+00:00

Just some clarifications and typo fixes.