<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dolphin/Source/Core/DolphinQt/Achievements/AchievementsWindow.cpp, branch master</title>
<subtitle>GameCube and Wii emulator</subtitle>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/'/>
<entry>
<title>Improve usage of std::move and const references parameters</title>
<updated>2026-04-17T10:39:46+00:00</updated>
<author>
<name>Martino Fontana</name>
<email>tinozzo123@gmail.com</email>
</author>
<published>2026-04-06T09:37:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=95dec132030e72b74da6bc46966e4fe5e4e239c0'/>
<id>95dec132030e72b74da6bc46966e4fe5e4e239c0</id>
<content type='text'>
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
</pre>
</div>
</content>
</entry>
<entry>
<title>Common: Remove the string parameters from the HookableEvent interface.</title>
<updated>2025-11-07T04:34:40+00:00</updated>
<author>
<name>Jordan Woyak</name>
<email>jordan.woyak@gmail.com</email>
</author>
<published>2025-11-07T04:08:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=da6c65bf3b83fa1cfe5da5dc5e43ec49b2786b52'/>
<id>da6c65bf3b83fa1cfe5da5dc5e43ec49b2786b52</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Common: Make HookableEvent use non-static data.</title>
<updated>2025-11-02T23:30:43+00:00</updated>
<author>
<name>Jordan Woyak</name>
<email>jordan.woyak@gmail.com</email>
</author>
<published>2025-05-03T07:48:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=f289b06e0db8bba6a3491d6e3cf0c2dd1b7a29fa'/>
<id>f289b06e0db8bba6a3491d6e3cf0c2dd1b7a29fa</id>
<content type='text'>
Co-authored-by: Dentomologist &lt;dentomologist@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Co-authored-by: Dentomologist &lt;dentomologist@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>AchievementManager: Use HookableEvent instead of std::function callbacks</title>
<updated>2025-08-24T12:47:13+00:00</updated>
<author>
<name>JosJuice</name>
<email>josjuice@gmail.com</email>
</author>
<published>2025-08-22T19:02:25+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=de98c3b96ff19650421511b1c5e5c34390dc18fc'/>
<id>de98c3b96ff19650421511b1c5e5c34390dc18fc</id>
<content type='text'>
The callback mechanism AchievementManager had until now only supported
one caller registering a callback, and it didn't have any
synchronization. This isn't a problem for DolphinQt, but the PR to add
Android support for RetroAchievements exposes these problems. Let's
replace it with HookableEvent, which can handle all of this.

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The callback mechanism AchievementManager had until now only supported
one caller registering a callback, and it didn't have any
synchronization. This isn't a problem for DolphinQt, but the PR to add
Android support for RetroAchievements exposes these problems. Let's
replace it with HookableEvent, which can handle all of this.

</pre>
</div>
</content>
</entry>
<entry>
<title>DolphinQt: Remove redundant window hints</title>
<updated>2025-06-07T02:35:13+00:00</updated>
<author>
<name>Dentomologist</name>
<email>dentomologist@gmail.com</email>
</author>
<published>2025-05-27T23:52:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=2a7e8a40037a1690287dcf47fa99b32513418bd0'/>
<id>2a7e8a40037a1690287dcf47fa99b32513418bd0</id>
<content type='text'>
Remove window hints clearing the flag Qt::WindowContextHelpButtonHint,
which is already off by default in Qt 6.

In Qt 5 this flag was set by default for QDialogs, and on Windows put a
? button in the corner of the title bar allowing users to activate Qt's
QWhatsThis help system for a given widget. Since we don't set that text
the ? button was useless and so we hid it manually.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove window hints clearing the flag Qt::WindowContextHelpButtonHint,
which is already off by default in Qt 6.

In Qt 5 this flag was set by default for QDialogs, and on Windows put a
? button in the corner of the title bar allowing users to activate Qt's
QWhatsThis help system for a given widget. Since we don't set that text
the ? button was useless and so we hid it manually.
</pre>
</div>
</content>
</entry>
<entry>
<title>DolphinQt: Make WrapInScrollArea and GetWrappedWidget less hacky.</title>
<updated>2025-05-27T01:58:48+00:00</updated>
<author>
<name>Jordan Woyak</name>
<email>jordan.woyak@gmail.com</email>
</author>
<published>2025-05-13T03:17:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=543b85a4513d2d1da8b0220529c28de1a989a51e'/>
<id>543b85a4513d2d1da8b0220529c28de1a989a51e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add RAIntegration event handler</title>
<updated>2025-04-13T17:36:15+00:00</updated>
<author>
<name>LillyJadeKatrin</name>
<email>lilly.kitty.1988@gmail.com</email>
</author>
<published>2024-07-22T06:17:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=90a4be4b369768d186793f6c7efad2445f13bc20'/>
<id>90a4be4b369768d186793f6c7efad2445f13bc20</id>
<content type='text'>
Some refactoring done to hardcore toggling so that it's more readily available for the toggle hardcore event.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some refactoring done to hardcore toggling so that it's more readily available for the toggle hardcore event.
</pre>
</div>
</content>
</entry>
<entry>
<title>Properly Notify when Achievements Login Fails</title>
<updated>2024-10-01T22:03:46+00:00</updated>
<author>
<name>LillyJadeKatrin</name>
<email>lilly.kitty.1988@gmail.com</email>
</author>
<published>2024-07-25T00:50:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=2f40bc25aef191cc6551aa977e38ac0325c16bb2'/>
<id>2f40bc25aef191cc6551aa977e38ac0325c16bb2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Re-enable Leaderboards Tab</title>
<updated>2024-07-18T02:51:43+00:00</updated>
<author>
<name>LillyJadeKatrin</name>
<email>lilly.kitty.1988@gmail.com</email>
</author>
<published>2024-07-18T02:51:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=5ccd157c944a24de13975661a62e6d46a3a5bb44'/>
<id>5ccd157c944a24de13975661a62e6d46a3a5bb44</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Disable Leaderboards Tab</title>
<updated>2024-07-12T11:45:04+00:00</updated>
<author>
<name>LillyJadeKatrin</name>
<email>lilly.kitty.1988@gmail.com</email>
</author>
<published>2024-07-12T11:45:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=193c863f20d7645e728b1df8ac7abdb8ffd0eda8'/>
<id>193c863f20d7645e728b1df8ac7abdb8ffd0eda8</id>
<content type='text'>
Emergency PR to disable the leaderboards tab for launch if we are not satisfied with its testing yet.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Emergency PR to disable the leaderboards tab for launch if we are not satisfied with its testing yet.
</pre>
</div>
</content>
</entry>
</feed>
