<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dolphin/Source/Core/DolphinQt/CheatSearchWidget.cpp, branch release-prep-2503a</title>
<subtitle>GameCube and Wii emulator</subtitle>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/'/>
<entry>
<title>Fix random crash when using the cheat search</title>
<updated>2024-09-24T05:47:44+00:00</updated>
<author>
<name>Pokechu22</name>
<email>Pokechu022@gmail.com</email>
</author>
<published>2024-09-24T05:47:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=b34b7f63eeb784d36444514955a26a045f491c9b'/>
<id>b34b7f63eeb784d36444514955a26a045f491c9b</id>
<content type='text'>
Before, Dolphin would randomly crash when updating the cheat search when automatic refresh was enabled. (Having a large number of addresses listed, e.g. by starting with an "any value" search, may contribute). The crash was due to QTableWidget::item returning nullptr in RefreshGUICurrentValues, presumably due to the table being resized on the UI thread while the emulated CPU thread was updating the values. I've fixed this by pausing the CPU thread for the entirety of OnNextScanClicked; this eliminated crashes in my testing.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before, Dolphin would randomly crash when updating the cheat search when automatic refresh was enabled. (Having a large number of addresses listed, e.g. by starting with an "any value" search, may contribute). The crash was due to QTableWidget::item returning nullptr in RefreshGUICurrentValues, presumably due to the table being resized on the UI thread while the emulated CPU thread was updating the values. I've fixed this by pausing the CPU thread for the entirety of OnNextScanClicked; this eliminated crashes in my testing.
</pre>
</div>
</content>
</entry>
<entry>
<title>Adjust order and spacing of various #includes</title>
<updated>2024-07-26T21:28:34+00:00</updated>
<author>
<name>Dentomologist</name>
<email>dentomologist@gmail.com</email>
</author>
<published>2024-07-26T21:24:16+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=d627b78c46ef752211a0aa7f259cd9f7e2415985'/>
<id>d627b78c46ef752211a0aa7f259cd9f7e2415985</id>
<content type='text'>
Move some #includes around to match the Contributing guidelines.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move some #includes around to match the Contributing guidelines.
</pre>
</div>
</content>
</entry>
<entry>
<title>DolphinQt: Properly Delete (Some) Widgets</title>
<updated>2024-04-30T18:17:28+00:00</updated>
<author>
<name>mitaclaw</name>
<email>140017135+mitaclaw@users.noreply.github.com</email>
</author>
<published>2024-04-30T17:58:16+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=0397339ab1fbdf6309ab14dbf48946853c608522'/>
<id>0397339ab1fbdf6309ab14dbf48946853c608522</id>
<content type='text'>
This is not every memory leak, just the ones that were obvious.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is not every memory leak, just the ones that were obvious.
</pre>
</div>
</content>
</entry>
<entry>
<title>Core::GetState: Avoid Global System Accessor</title>
<updated>2024-04-08T23:23:23+00:00</updated>
<author>
<name>mitaclaw</name>
<email>140017135+mitaclaw@users.noreply.github.com</email>
</author>
<published>2024-03-28T18:35:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=eb92d6f0a8c930692de64bd41c5ddee403771023'/>
<id>eb92d6f0a8c930692de64bd41c5ddee403771023</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>CheatsManager: Allow making the window smaller</title>
<updated>2024-03-31T20:17:56+00:00</updated>
<author>
<name>Dentomologist</name>
<email>dentomologist@gmail.com</email>
</author>
<published>2024-03-31T19:54:47+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=ac4fd2297fda3b1e560b40e3e2e27fb9e5eb4d2e'/>
<id>ac4fd2297fda3b1e560b40e3e2e27fb9e5eb4d2e</id>
<content type='text'>
Move CheatManager's child widgets into scroll areas to allow making the
window smaller than the default.

In CheatSearchWidget, enable word wrapping for the label describing the
address space and search type to help it fit better inside a narrower
window.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move CheatManager's child widgets into scroll areas to allow making the
window smaller than the default.

In CheatSearchWidget, enable word wrapping for the label describing the
address space and search type to help it fit better inside a narrower
window.
</pre>
</div>
</content>
</entry>
<entry>
<title>DolphinQt: Allow Cheat Search to create multiple AR codes when selecting multiple lines.</title>
<updated>2024-03-17T06:29:39+00:00</updated>
<author>
<name>Jordan Woyak</name>
<email>jordan.woyak@gmail.com</email>
</author>
<published>2024-03-17T06:21:22+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=c202b55bd43544de9b9301e10e81e473ee47bd16'/>
<id>c202b55bd43544de9b9301e10e81e473ee47bd16</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>CheatsManager/CheatSearchWidget: Avoid Global System Accessor</title>
<updated>2024-03-12T03:51:15+00:00</updated>
<author>
<name>mitaclaw</name>
<email>140017135+mitaclaw@users.noreply.github.com</email>
</author>
<published>2024-03-01T16:07:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=c377c1e21ea64435a4e0fb2d08c03cabb4ec981d'/>
<id>c377c1e21ea64435a4e0fb2d08c03cabb4ec981d</id>
<content type='text'>
OnResetClicked and GenerateARCode appear to have been using the CPUThreadGuard in error.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
OnResetClicked and GenerateARCode appear to have been using the CPUThreadGuard in error.
</pre>
</div>
</content>
</entry>
<entry>
<title>CheatSearch: Remove redundant lambdas</title>
<updated>2024-02-02T03:54:47+00:00</updated>
<author>
<name>mitaclaw</name>
<email>140017135+mitaclaw@users.noreply.github.com</email>
</author>
<published>2024-02-02T03:01:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=085c4d154e6debc1a73d22dbcf451ac328334b2a'/>
<id>085c4d154e6debc1a73d22dbcf451ac328334b2a</id>
<content type='text'>
Core::RunAsCPUThread is obsoleted by CPUThreadGuard reference already passed into the function. The nonsense lambda in CheatSearchWidget is from changes in fdb7328c737f2bba148b903491b66fa62cc03703.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Core::RunAsCPUThread is obsoleted by CPUThreadGuard reference already passed into the function. The nonsense lambda in CheatSearchWidget is from changes in fdb7328c737f2bba148b903491b66fa62cc03703.
</pre>
</div>
</content>
</entry>
<entry>
<title>CheatSearchWidget: Make use of CPUThreadGuard parameter in UpdateTableRows</title>
<updated>2023-12-12T21:41:00+00:00</updated>
<author>
<name>Lioncash</name>
<email>mai.iam2048@gmail.com</email>
</author>
<published>2023-12-12T21:40:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=915e43dfba5807f9cd381005ad9b427197a679b3'/>
<id>915e43dfba5807f9cd381005ad9b427197a679b3</id>
<content type='text'>
Previously, the parameter wasn't being used, because it was being
shadowed by another CPUThreadGuard at its only would-be usage point.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, the parameter wasn't being used, because it was being
shadowed by another CPUThreadGuard at its only would-be usage point.
</pre>
</div>
</content>
</entry>
<entry>
<title>CheatSearchWidget: Add checkbox to toggle Current Value autoupdate</title>
<updated>2023-11-01T00:35:14+00:00</updated>
<author>
<name>Dentomologist</name>
<email>dentomologist@gmail.com</email>
</author>
<published>2023-10-29T22:20:23+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=9230266529ff70981a89a9cf95e9665a479f1168'/>
<id>9230266529ff70981a89a9cf95e9665a479f1168</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
