dolphin/Source/Core/DolphinQt/Config/ConfigControls/ConfigChoice.cpp, branch master

Improve usage of std::move and const references parameters

2026-04-17T10:39:46+00:00

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

Use more std::span arguments

2026-03-23T22:55:09+00:00

WiiPane: Use ConfigControls where applicable

2025-10-27T15:22:02+00:00

Settings: Bugfix. Fix some combo boxes setting a value without user input. Prevents initial Load from calling the connection to save value.

2025-05-03T01:21:45+00:00

linter: Add and apply new formatting rules

2025-04-23T09:19:57+00:00

New rules:
`InsertNewlineAtEOF: true`
`RemoveSemicolon: true`
`RequiresClausePosition: WithPreceding`

ConfigControl fix: Add invalid index check to ConfigComplexChoice. Resolve with a default index that can be set.

2025-03-26T20:15:57+00:00

If more control is needed,  it could be changed to allow multiple states to point to the same index.

DolphinQt: Allow ConfigComplexChoice to handle DefaultState values.

2025-03-18T01:46:24+00:00

Merge pull request #13259 from TryTwo/PR_Config_signals

2025-01-18T23:11:04+00:00

Qt: Fix some options not changing enabled status on game start.

Qt, Config controls system: Remove signal block so signals can refresh the enabled status of certain options when a new config is loaded (such as on starting a game). Blocks previously unwanted behavior with a new safety check.

2025-01-07T10:02:39+00:00

QCheckBox::toggled and other similar signals are used to save changes and to update widget status (such as enabled).. OnConfigChanged needs to load new values and trigger widget updates, but the new value shouldn't trigger a save. A save is unnecessary (the config has the correct values and the UI is being updated to those values) and it'd trigger another ConfigChanged signal.   This commit blocks the save without blocking the signal entirely.

Fix several minor warnings

2025-01-06T10:31:39+00:00