dolphin/Source/Core/DolphinQt/Config/Graphics, branch 2412 GameCube and Wii emulator GeneralWidget: Recommend default video backend in tooltip 2024-11-03T20:28:30+00:00 Dentomologist dentomologist@gmail.com 2024-11-03T19:35:47+00:00 47a86d920f965a3799fa5f46734497b88e8eba0a Recommend the platform's default video backend in the Backend tooltip instead of always recommending OpenGL. 
Recommend the platform's default video backend in the Backend tooltip
instead of always recommending OpenGL.
GraphicsSettings: EFBAccessEnable=false by default 2024-10-22T19:28:14+00:00 dreamsyntax dreamsyntax@gmail.com 2024-10-20T00:17:10+00:00 9dacefcbf1790564c5432de1f7dfadfc3d5c4be7 Makes Graphics -> Hacks -> Skip EFB Access from CPU enabled by default. Some GPU drivers stall when EFB access occurs in games where EFB is not used. Most games that require this setting set to 'true' already have this defined in their game inis. 
Makes Graphics -> Hacks -> Skip EFB Access from CPU enabled by default. Some GPU drivers stall when EFB access occurs in games where EFB is not used. Most games that require this setting set to 'true' already have this defined in their game inis.
Partially revert "Revert "Audit uses of IsRunning and GetState"" 2024-10-04T16:35:41+00:00 JosJuice josjuice@gmail.com 2024-07-02T15:27:04+00:00 6ca2da53e86766f54df1ae79e65bb220b41ed7ef This reverts the revert commit bc67fc97c39628c76a4dbca411b0e8a9bfaf726a, except for the changes in BaseConfigLoader.cpp, which caused the bug that made us revert 72cf2bdb87f09deff22e1085de3290126aa4ad05. PR 12917 contains an improved change to BaseConfigLoader.cpp, which can be merged (or rejected) independently. A few changes have also been made based on review comments. 
This reverts the revert commit bc67fc97c39628c76a4dbca411b0e8a9bfaf726a,
except for the changes in BaseConfigLoader.cpp, which caused the bug
that made us revert 72cf2bdb87f09deff22e1085de3290126aa4ad05. PR 12917
contains an improved change to BaseConfigLoader.cpp, which can be merged
(or rejected) independently.

A few changes have also been made based on review comments.
Merge pull request #13062 from Dentomologist/graphics_clarify_relationship_between_incompatible_settings 2024-09-27T04:40:30+00:00 Tilka tilkax@gmail.com 2024-09-27T04:40:30+00:00 2cb124bd3ae0392a3fd7b683b55790d2fe826da8 Graphics: Clarify relationship between incompatible settings 
Graphics: Clarify relationship between incompatible settings
 VideoBackendBase: Check Core state in PopulateBackendInfo 2024-09-27T00:12:26+00:00 Dentomologist dentomologist@gmail.com 2024-09-26T22:11:26+00:00 0a1084fad58ca6e340802021bd2e0d48ad7180ed Remove the PopulateBackendInfoFromUI function, which had a single caller (GraphicsWindow::OnBackendChanged) and checked that the core wasn't running or starting before calling PopulateBackendInfo. Move the core state check into PopulateBackendInfo and have OnBackendChanged call that instead. This guarantees the check is performed by all callers of PopulateBackendInfo, preventing potential reintroduction of the crash fixed in 3d4ae63f if another call to PopulateBackendInfo is added. As of the previous commit the only other caller of PopulateBackendInfo is Core::Init shortly before s_state is set to Starting, so it will always pass the check and so maintain its current behavior. 
Remove the PopulateBackendInfoFromUI function, which had a single caller
(GraphicsWindow::OnBackendChanged) and checked that the core wasn't
running or starting before calling PopulateBackendInfo.

Move the core state check into PopulateBackendInfo and have
OnBackendChanged call that instead. This guarantees the check is
performed by all callers of PopulateBackendInfo, preventing
potential reintroduction of the crash fixed in 3d4ae63f if another call
to PopulateBackendInfo is added.

As of the previous commit the only other caller of PopulateBackendInfo
is Core::Init shortly before s_state is set to Starting, so it will
always pass the check and so maintain its current behavior.
Graphics: Clarify relationship between incompatible settings 2024-09-10T18:35:15+00:00 Dentomologist dentomologist@gmail.com 2024-09-10T17:44:22+00:00 694f2ee9959cc349cf128fe031cdf0756bf7df0c Explicitly state that Manual Texture Sampling disables Anisotropic Filtering and that GPU Texture Decoding disables Arbitrary Mipmap Detection. 
Explicitly state that Manual Texture Sampling disables Anisotropic
Filtering and that GPU Texture Decoding disables Arbitrary Mipmap
Detection.
Graphics: Adapt aspect ratio when SBS/TAB 3D is used 2024-08-21T21:11:43+00:00 Bryan Jacobs b@q3q.us 2024-08-15T07:20:00+00:00 7ec6d116e8ee94bee8bdecf2bf2801ea45f09432 Adds support for choosing to present the full resolution independently to each eye when using side-by-side or top-and-bottom 3D. 
Adds support for choosing to present the full resolution
independently to each eye when using side-by-side or
top-and-bottom 3D.
Fix postprocessing shader not changing when setting stereo mode 2024-08-18T05:09:12+00:00 Pokechu22 Pokechu022@gmail.com 2024-08-18T05:09:12+00:00 307c8c273e01a564cc7e9f0bac6e6c2b7333d8f4 Fixes https://bugs.dolphin-emu.org/issues/13593. Before, it would attempt to use the old shader, which did not exist for the new stereo mode. Changing the postprocessing shader afterwards would work properly, although passive 3D only has one option, so it was just broken without restarting Dolphin. This also fixes the UI not updating when using one of the stereo toggle hotkeys. 
Fixes https://bugs.dolphin-emu.org/issues/13593. Before, it would attempt to
use the old shader, which did not exist for the new stereo mode. Changing the
postprocessing shader afterwards would work properly, although passive 3D only
has one option, so it was just broken without restarting Dolphin.

This also fixes the UI not updating when using one of the stereo toggle hotkeys.
Revert "Audit uses of IsRunning and GetState" 2024-06-26T18:36:46+00:00 JosJuice josjuice@gmail.com 2024-06-26T18:34:16+00:00 bc67fc97c39628c76a4dbca411b0e8a9bfaf726a This reverts commit 72cf2bdb87f09deff22e1085de3290126aa4ad05. SYSCONF settings are getting cleared when they shouldn't be. Let's revert the change until I get proper time to figure out why it's broken. 
This reverts commit 72cf2bdb87f09deff22e1085de3290126aa4ad05.

SYSCONF settings are getting cleared when they shouldn't be. Let's
revert the change until I get proper time to figure out why it's broken.
Audit uses of IsRunning and GetState 2024-06-21T18:52:55+00:00 JosJuice josjuice@gmail.com 2024-06-02T14:45:30+00:00 72cf2bdb87f09deff22e1085de3290126aa4ad05 Some pieces of code are calling IsRunning because there's some particular action that only makes sense when emulation is running, for instance showing the state of the emulated CPU. IsRunning is appropriate to use for this. Then there are pieces of code that are calling IsRunning because there's some particular thing they must avoid doing e.g. when the CPU thread is running or IOS is running. IsRunning isn't quite appropriate for this. Such code should also be checking for the states Starting and Stopping. Keep in mind that: * When the state is Starting, the state can asynchronously change to Running at any time. * When we try to stop the core, the state gets set to Stopping before we take any action to actually stop things. This commit adds a new method Core::IsUninitialized, and changes all callers of IsRunning and GetState that look to me like they should be changed. 
Some pieces of code are calling IsRunning because there's some
particular action that only makes sense when emulation is running, for
instance showing the state of the emulated CPU. IsRunning is appropriate
to use for this. Then there are pieces of code that are calling
IsRunning because there's some particular thing they must avoid doing
e.g. when the CPU thread is running or IOS is running. IsRunning isn't
quite appropriate for this. Such code should also be checking for the
states Starting and Stopping. Keep in mind that:

* When the state is Starting, the state can asynchronously change to
  Running at any time.
* When we try to stop the core, the state gets set to Stopping before we
  take any action to actually stop things.

This commit adds a new method Core::IsUninitialized, and changes all
callers of IsRunning and GetState that look to me like they should be
changed.