dolphin/Source/Core/DolphinQt/FIFO/FIFOPlayerWindow.cpp, branch 2412 GameCube and Wii emulator Partially revert "Revert "Audit uses of IsRunning and GetState"" 2024-10-04T16:35:41+00:00 JosJuice josjuice@gmail.com 2024-07-02T15:27:04+00:00 6ca2da53e86766f54df1ae79e65bb220b41ed7ef This reverts the revert commit bc67fc97c39628c76a4dbca411b0e8a9bfaf726a, except for the changes in BaseConfigLoader.cpp, which caused the bug that made us revert 72cf2bdb87f09deff22e1085de3290126aa4ad05. PR 12917 contains an improved change to BaseConfigLoader.cpp, which can be merged (or rejected) independently. A few changes have also been made based on review comments. 
This reverts the revert commit bc67fc97c39628c76a4dbca411b0e8a9bfaf726a,
except for the changes in BaseConfigLoader.cpp, which caused the bug
that made us revert 72cf2bdb87f09deff22e1085de3290126aa4ad05. PR 12917
contains an improved change to BaseConfigLoader.cpp, which can be merged
(or rejected) independently.

A few changes have also been made based on review comments.
i18n: Add comments and improve source strings 2024-07-28T12:38:20+00:00 JosJuice josjuice@gmail.com 2024-07-28T12:24:38+00:00 9d2f5245f49a7bdcc265001c420bc9f61e629a34 Most of these changes are to improve consistency in capitalization. 
Most of these changes are to improve consistency in capitalization.
Revert "Audit uses of IsRunning and GetState" 2024-06-26T18:36:46+00:00 JosJuice josjuice@gmail.com 2024-06-26T18:34:16+00:00 bc67fc97c39628c76a4dbca411b0e8a9bfaf726a This reverts commit 72cf2bdb87f09deff22e1085de3290126aa4ad05. SYSCONF settings are getting cleared when they shouldn't be. Let's revert the change until I get proper time to figure out why it's broken. 
This reverts commit 72cf2bdb87f09deff22e1085de3290126aa4ad05.

SYSCONF settings are getting cleared when they shouldn't be. Let's
revert the change until I get proper time to figure out why it's broken.
Audit uses of IsRunning and GetState 2024-06-21T18:52:55+00:00 JosJuice josjuice@gmail.com 2024-06-02T14:45:30+00:00 72cf2bdb87f09deff22e1085de3290126aa4ad05 Some pieces of code are calling IsRunning because there's some particular action that only makes sense when emulation is running, for instance showing the state of the emulated CPU. IsRunning is appropriate to use for this. Then there are pieces of code that are calling IsRunning because there's some particular thing they must avoid doing e.g. when the CPU thread is running or IOS is running. IsRunning isn't quite appropriate for this. Such code should also be checking for the states Starting and Stopping. Keep in mind that: * When the state is Starting, the state can asynchronously change to Running at any time. * When we try to stop the core, the state gets set to Stopping before we take any action to actually stop things. This commit adds a new method Core::IsUninitialized, and changes all callers of IsRunning and GetState that look to me like they should be changed. 
Some pieces of code are calling IsRunning because there's some
particular action that only makes sense when emulation is running, for
instance showing the state of the emulated CPU. IsRunning is appropriate
to use for this. Then there are pieces of code that are calling
IsRunning because there's some particular thing they must avoid doing
e.g. when the CPU thread is running or IOS is running. IsRunning isn't
quite appropriate for this. Such code should also be checking for the
states Starting and Stopping. Keep in mind that:

* When the state is Starting, the state can asynchronously change to
  Running at any time.
* When we try to stop the core, the state gets set to Stopping before we
  take any action to actually stop things.

This commit adds a new method Core::IsUninitialized, and changes all
callers of IsRunning and GetState that look to me like they should be
changed.
Core::IsRunning: Avoid Global System Accessor 2024-05-01T15:54:17+00:00 mitaclaw 140017135+mitaclaw@users.noreply.github.com 2024-04-09T03:33:55+00:00 0df401b164bbe2b0314b74f1fd6385e852bbe098 






FifoRecorder: Move instance to System.
2024-01-12T14:06:06+00:00

Admiral H. Curtiss
pikachu025@gmail.com

2024-01-12T12:35:47+00:00

637fd4990914831ae164c2f410cf60fe4f0d28c4












FifoPlayer: Move instance to System.
2024-01-05T19:15:18+00:00

Admiral H. Curtiss
pikachu025@gmail.com

2024-01-05T08:31:59+00:00

fc2ec826d462881f94b324fb6971cc920200f093












DolphinQt: Remove unnecessary qOverloads
2023-11-04T21:14:14+00:00

Dentomologist
dentomologist@gmail.com

2023-11-04T21:01:39+00:00

43e69d3e6ab699d2ae09dab377e11651e799f995

qOverload is used to disambiguate pointers to overloaded functions, but
most of the usages in the code base were with non-overloaded functions.





qOverload is used to disambiguate pointers to overloaded functions, but
most of the usages in the code base were with non-overloaded functions.







FifoPlayer: Add missing call to LoadSettings()
2022-01-17T19:00:13+00:00

Pokechu22
Pokechu022@gmail.com

2022-01-17T18:59:57+00:00

75cdcd5ac27c136407003703424d03a235606505

This resulted in the loop checkbox appearing unchecked, even though loop was enabled.





This resulted in the loop checkbox appearing unchecked, even though loop was enabled.







FifoPlayer: Allow changing loop option at runtime
2022-01-07T03:08:16+00:00

Pokechu22
Pokechu022@gmail.com

2022-01-06T22:47:36+00:00

29df17d422bd4912987eda501e7d68c312763106

This option has always existed since it's used by FifoCI, but now it can be changed at runtime.  Looping is something that should almost always be on, but it can be useful to turn it off when frame-dumping is enabled so that hundreds of copies of the same frame aren't created.  Before, turning it off required restarting Dolphin.





This option has always existed since it's used by FifoCI, but now it can be changed at runtime.  Looping is something that should almost always be on, but it can be useful to turn it off when frame-dumping is enabled so that hundreds of copies of the same frame aren't created.  Before, turning it off required restarting Dolphin.