dolphin/Source/Core/DolphinQt/Settings/AudioPane.cpp, branch 2409 GameCube and Wii emulator Revert "Audit uses of IsRunning and GetState" 2024-06-26T18:36:46+00:00 JosJuice josjuice@gmail.com 2024-06-26T18:34:16+00:00 bc67fc97c39628c76a4dbca411b0e8a9bfaf726a This reverts commit 72cf2bdb87f09deff22e1085de3290126aa4ad05. SYSCONF settings are getting cleared when they shouldn't be. Let's revert the change until I get proper time to figure out why it's broken. 
This reverts commit 72cf2bdb87f09deff22e1085de3290126aa4ad05.

SYSCONF settings are getting cleared when they shouldn't be. Let's
revert the change until I get proper time to figure out why it's broken.
Audit uses of IsRunning and GetState 2024-06-21T18:52:55+00:00 JosJuice josjuice@gmail.com 2024-06-02T14:45:30+00:00 72cf2bdb87f09deff22e1085de3290126aa4ad05 Some pieces of code are calling IsRunning because there's some particular action that only makes sense when emulation is running, for instance showing the state of the emulated CPU. IsRunning is appropriate to use for this. Then there are pieces of code that are calling IsRunning because there's some particular thing they must avoid doing e.g. when the CPU thread is running or IOS is running. IsRunning isn't quite appropriate for this. Such code should also be checking for the states Starting and Stopping. Keep in mind that: * When the state is Starting, the state can asynchronously change to Running at any time. * When we try to stop the core, the state gets set to Stopping before we take any action to actually stop things. This commit adds a new method Core::IsUninitialized, and changes all callers of IsRunning and GetState that look to me like they should be changed. 
Some pieces of code are calling IsRunning because there's some
particular action that only makes sense when emulation is running, for
instance showing the state of the emulated CPU. IsRunning is appropriate
to use for this. Then there are pieces of code that are calling
IsRunning because there's some particular thing they must avoid doing
e.g. when the CPU thread is running or IOS is running. IsRunning isn't
quite appropriate for this. Such code should also be checking for the
states Starting and Stopping. Keep in mind that:

* When the state is Starting, the state can asynchronously change to
  Running at any time.
* When we try to stop the core, the state gets set to Stopping before we
  take any action to actually stop things.

This commit adds a new method Core::IsUninitialized, and changes all
callers of IsRunning and GetState that look to me like they should be
changed.
Core::GetState: Avoid Global System Accessor 2024-04-08T23:23:23+00:00 mitaclaw 140017135+mitaclaw@users.noreply.github.com 2024-03-28T18:35:13+00:00 eb92d6f0a8c930692de64bd41c5ddee403771023 






DolphinQt: Remove unnecessary qOverloads
2023-11-04T21:14:14+00:00

Dentomologist
dentomologist@gmail.com

2023-11-04T21:01:39+00:00

43e69d3e6ab699d2ae09dab377e11651e799f995

qOverload is used to disambiguate pointers to overloaded functions, but
most of the usages in the code base were with non-overloaded functions.





qOverload is used to disambiguate pointers to overloaded functions, but
most of the usages in the code base were with non-overloaded functions.







AudioPane: Fix inconsistent initial state of audio stretching labels
2023-02-18T02:51:41+00:00

Pokechu22
Pokechu022@gmail.com

2023-02-18T02:51:41+00:00

c94aacc9687af3cc3505f4b42a235352c47684fc

This resulted in the labels being solid black even when audio stretching is disabled the first time the settings are opened, but then properly being greyed out after changing a setting (even the audio backend or DSP emulation engine, not just whether audio stretching is enabled).





This resulted in the labels being solid black even when audio stretching is disabled the first time the settings are opened, but then properly being greyed out after changing a setting (even the audio backend or DSP emulation engine, not just whether audio stretching is enabled).







AudioCommon: Pass Core::System to AudioCommon functions.
2022-11-06T01:13:58+00:00

Admiral H. Curtiss
pikachu025@gmail.com

2022-10-13T19:01:55+00:00

1c633499842646d7069db067f9c26954c3de144a












Resolve "implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20" warning
2022-08-08T01:25:19+00:00

Zopolis4
creatorsmithmdt@gmail.com

2022-08-08T01:25:19+00:00

e54818e60dc820962290ef3600fc77a7882ba98e












Port Main.DSP to MainSettings
2021-10-16T03:24:46+00:00

sowens99
seanowens@comcast.net

2021-10-14T00:29:04+00:00

8ea6bef98f535301d23aa1c81d4080c208527705

While trying to work on adding audiodump support for CLI, I was alerted that it was important to first try moving the DSP configs to the new config before continuing, as that makes it substantially easier to write clean code to add such a feature.

This commit aims to allow for Dolphin to only rely on the new config for DSP-related settings.





While trying to work on adding audiodump support for CLI, I was alerted that it was important to first try moving the DSP configs to the new config before continuing, as that makes it substantially easier to write clean code to add such a feature.

This commit aims to allow for Dolphin to only rely on the new config for DSP-related settings.







Revert "Revert "DolphinQt: Minor consistency fixes for the Settings window""
2021-09-08T20:09:19+00:00

JosJuice
josjuice@gmail.com

2021-09-08T20:08:43+00:00

5ea121eeb5397932750279d11bcd8fa8e4cc5f43

This reverts commit e376a985e435b15ef6518003a2810acdfbc4e0b6.

A beta build has been released now, so there's no reason to keep
it reverted anymore.





This reverts commit e376a985e435b15ef6518003a2810acdfbc4e0b6.

A beta build has been released now, so there's no reason to keep
it reverted anymore.







Revert "DolphinQt: Minor consistency fixes for the Settings window"
2021-08-31T07:15:03+00:00

JosJuice
josjuice@gmail.com

2021-08-31T07:15:03+00:00

e376a985e435b15ef6518003a2810acdfbc4e0b6

This reverts commit 9d45bac17538bf0e64cfad025bd82109c971f9d6.





This reverts commit 9d45bac17538bf0e64cfad025bd82109c971f9d6.