If Dolphin crashes, changes that have been made to settings are often lost. This has been a minor annoyance for me when developing, but it has become a much bigger issue recently due to the problem where Dolphin freezes on shutdown for ROG Ally users. Instead of saving the config when certain arbitrary settings are changed, let's save the config when the user closes the settings window.
Yellow squiggly lines begone! Done automatically on .cpp files through `run-clang-tidy`, with manual corrections to the mistakes. If an import is directly used, but is technically unnecessary since it's recursively imported by something else, it is *not* removed. The tool doesn't touch .h files, so I did some of them by hand while fixing errors due to old recursive imports. Not everything is removed, but the cleanup should be substantial enough. Because this done on Linux, code that isn't used on it is mostly untouched. (Hopefully no open PR is depending on these imports...)
GeneralPane: Add Hardcore Mode tooltip clarifications
Dual Core is primarily known as one of the first troubleshooting steps when emulation or NetPlay misbehave. I believe(?) the original intent with having it on by default was likely to support users with weaker machines. However, I believe it would be a lot more reasonable for users to manually enable dual core if they really need the performance boost, rather than it is for them to have come ask us in support channel why their cleanly-installed Dolphin is not emulating their games properly. Instead, this creates a fragile first impression where a clean install of Dolphin is already set up in a way that leads to inexplicable crashes, subtle timing bugs, and NetPlay desyncs. Note: This changes only applies to the Desktop application, since mobile devices *do* really need the performance boost.
When Hardcore Mode is active, clarify in the Speed Limit tooltip that values less than 100% won't slow emulation.
Now that patches and codes are enabled on a case by case basis, remove patcher code blocking codes entirely in hardcore mode, and reword the warning to be more accurate.
The description of the Speed Limit setting currently uses a lot of complicated terms, like "emulated time" (known to many Dolphin developers, but in my experience not known by even advanced emulator users) and "maximum time scale" (I have never heard it before). The meaning of "sustainable" is also unclear in context. This commit rewords the description to be easier to understand.