dolphin/Source/Core/VideoCommon/Assets/CustomAsset.cpp, branch master

Improve usage of std::move and const references parameters

2026-04-17T10:39:46+00:00

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

VideoCommon: remove 'GetByteSizeInMemory()' from custom asset, it is not needed anymore

2025-06-07T04:03:02+00:00

VideoCommon: avoid race conditions with asset load/unload by moving the lock to the entire function, favor atomics for the memory/time getters

2025-06-07T04:03:02+00:00

VideoCommon: rename m_bytes_loaded in asset library to bytes_loaded

2025-06-07T04:03:02+00:00

VideoCommon: update CustomAsset's load time to be before the load occurs (this prevents issues where the load time might be incorrectly inflated by long load operations)

2025-06-07T04:03:02+00:00

Co-authored-by: Jordan Woyak

VideoCommon: remove 'GetLastAssetWriteTime' and switch to a steady_clock for asset times

2025-06-07T04:03:02+00:00

VideoCommon: change asset loading to return the number of bytes loaded instead of a pass/fail

2025-06-07T04:03:02+00:00

VideoCommon: add 'Unload' functionality to CustomAsset

2025-06-07T04:03:02+00:00

VideoCommon: add a handle to custom asset, this is an id that is only relevant for a particular game session but is slightly faster as a numeric value for lookups than the traditional asset id

2025-06-07T00:20:25+00:00

VideoCommon: add additional locks around asset access and usage to ensure thread safety

2023-06-05T21:19:46+00:00