dolphin/Source/Core/VideoCommon/VertexShaderGen.cpp, branch 2609

Optimize vertex_shader_uid_data down to 28 bytes

2026-08-07T06:42:52+00:00

This started as a fixing a misalignment issue, but I got carried away.
Was originally 41 bytes (overflowing it's expected 40 bytes by 1 bit).

Now it's 27 bytes plus 8 bits of padding (ready for future expansion).

The savings come from:
 - Removing UV usage from components, it can be reconstructed from
   texcoord_elem_count (saved 8 bits)
 - Removed the 8 unused bits from texMtxInfo_n_projection (saved 8 bits)
 - Removing unused bit from from start of components (saved 1 bit)
 - Removed extra bit from inputform, texgentype and sourcerow
 - packed texMtxInfo_n_projection and texcoord_elem_count back into
   the per texgen info space freed up above. (saved 24 bits)
 - Overlayed postMtx index and Emboss mode shifts into a union based on
   texgentype (saved 56 bits)
 - Move to a single-bit union tag, freeing up an extra bit for regular
   texgens.
 - Move PotMtx normalize into the freed up space (saved 8 bits)

Total savings: 105 bits of data

EDIT: Even worse, MSVC wasn't respecting pack(1) for bitfields at all,
      so on windows this struct was actually quite a bit larger.
      Something like 80 bytes, if not more.

      Fixed this by dropping the size of any enums used in these
      bit structs to u8. Our Common::BitField allows for the underlying
      type to be explicitly specified to something larger.

      msvc's bitfield packing appears to be completely braindead, can't
      mix sizes at all.

Fix various typos and spelling mistakes

2026-01-17T19:11:38+00:00

VideoCommon: fix regression where scenes with expanded lines or points would cause issues if doing per-vertex transformations in the vertex shader

2025-06-10T00:08:21+00:00

VideoCommon: move vertex shader gen logic to a 'process_vertex()' function, to eventually allow for custom shaders to override vertex logic

2025-05-24T06:27:58+00:00

VideoCommon: move position/normal matrices to be gettable by function in VertexShaderGen

2025-05-03T21:51:34+00:00

VideoCommon: move lighting shader logic to callable functions

2025-03-14T04:56:04+00:00

VideoCommon: mark 'WriteTexCoordTransforms' as 'static'

2025-03-02T17:27:54+00:00

VideoCommon: move texcoord calculations to accessible functions in VertexShaderGen

2025-02-15T04:44:49+00:00

Cache normals in addition to binormals and tangents

2024-10-12T17:32:41+00:00

Fixes LIT (https://bugs.dolphin-emu.org/issues/13635). The text does not include normals, but has lighting enabled. With the previous default of (0, 0, 0), lighting was always black (as dot(X, (0, 0, 0)) is always 0). It seems like the normal from the map in the background (0, 0, 1) is re-used.

LIT also has the vertex color enabled while vertex color is not specified, the same as SMS's debug cubes; the default MissingColorValue GameINI value of solid white seems to work correctly in this case.

VideoCommon: Fix VS point/line on older GLSL

2023-10-25T04:18:01+00:00