<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dolphin/Source/UnitTests/Common/SettingsHandlerTest.cpp, branch 2503a</title>
<subtitle>GameCube and Wii emulator</subtitle>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/'/>
<entry>
<title>Merge pull request #12744 from nlebeck/settingshandler-split-2</title>
<updated>2024-10-27T23:23:05+00:00</updated>
<author>
<name>JMC47</name>
<email>JMC4789@gmail.com</email>
</author>
<published>2024-10-27T23:23:05+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=aa8226fa88586a17feac5c2aff228e9e8175d369'/>
<id>aa8226fa88586a17feac5c2aff228e9e8175d369</id>
<content type='text'>
Split `SettingsHandler` into separate reader and writer classes</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Split `SettingsHandler` into separate reader and writer classes</pre>
</div>
</content>
</entry>
<entry>
<title>Add missing algorithm header in SettingsHandlerTest.cpp</title>
<updated>2024-10-22T21:48:43+00:00</updated>
<author>
<name>Admiral H. Curtiss</name>
<email>pikachu025@gmail.com</email>
</author>
<published>2024-10-22T21:48:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=c13c11d230718a99c271027c580490e84cfab4f7'/>
<id>c13c11d230718a99c271027c580490e84cfab4f7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Split `SettingsHandler` into separate reader and writer classes</title>
<updated>2024-10-22T03:20:15+00:00</updated>
<author>
<name>Niel Lebeck</name>
<email>niel.lebeck@gmail.com</email>
</author>
<published>2024-04-28T03:07:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=1d79991ec4b4fa62df619e9352cd2f4f4c68156d'/>
<id>1d79991ec4b4fa62df619e9352cd2f4f4c68156d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Modernize `std::equal` with ranges</title>
<updated>2024-10-10T07:53:48+00:00</updated>
<author>
<name>mitaclaw</name>
<email>140017135+mitaclaw@users.noreply.github.com</email>
</author>
<published>2024-09-22T06:46:43+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=249defa72b1da2a806a18cd93c7300c3aa1a844f'/>
<id>249defa72b1da2a806a18cd93c7300c3aa1a844f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Eliminate SettingsHandler's `SetBytes` and `Reset` methods</title>
<updated>2024-04-24T00:19:01+00:00</updated>
<author>
<name>Niel Lebeck</name>
<email>niel.lebeck@gmail.com</email>
</author>
<published>2024-04-23T04:51:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=36cdb4a544341e45155ff750c5f67ece71348a52'/>
<id>36cdb4a544341e45155ff750c5f67ece71348a52</id>
<content type='text'>
Also make the `Decrypt` method private.

As far as I can tell, the only motivation for exposing the `SetBytes`
and `Reset` methods is to allow `CBoot::SetupWiiMemory` to use the same
`SettingsHandler` instance to read settings data and then write it back.
It seems cleaner to just use two separate instances, and require a given
`SettingsHandler` instance to be used for either writing data to a
buffer or reading data from a buffer, but not both.

A natural next step is to split the `SettingsHandler` class into two
classes, one for writing data and one for reading data. I've deferred
that change for a future PR.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also make the `Decrypt` method private.

As far as I can tell, the only motivation for exposing the `SetBytes`
and `Reset` methods is to allow `CBoot::SetupWiiMemory` to use the same
`SettingsHandler` instance to read settings data and then write it back.
It seems cleaner to just use two separate instances, and require a given
`SettingsHandler` instance to be used for either writing data to a
buffer or reading data from a buffer, but not both.

A natural next step is to split the `SettingsHandler` class into two
classes, one for writing data and one for reading data. I've deferred
that change for a future PR.
</pre>
</div>
</content>
</entry>
<entry>
<title>Pass SettingsHandler buffers by const ref instead of rvalue ref</title>
<updated>2024-04-13T01:50:21+00:00</updated>
<author>
<name>Niel Lebeck</name>
<email>niel.lebeck@gmail.com</email>
</author>
<published>2024-04-13T01:50:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=d2b96736e0d5e472afe2fc87df1ac8aa48bf3915'/>
<id>d2b96736e0d5e472afe2fc87df1ac8aa48bf3915</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add SettingsHandler unit tests exercising the edge case in PR #8704</title>
<updated>2024-03-07T06:08:30+00:00</updated>
<author>
<name>Niel Lebeck</name>
<email>niel.lebeck@gmail.com</email>
</author>
<published>2024-03-04T00:43:11+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=9029b7a08283f64f993f87d8378c6d6e285eba06'/>
<id>9029b7a08283f64f993f87d8378c6d6e285eba06</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add simple unit tests for SettingsHandler</title>
<updated>2024-03-02T04:52:45+00:00</updated>
<author>
<name>Niel Lebeck</name>
<email>niel.lebeck@gmail.com</email>
</author>
<published>2024-02-27T04:50:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.dog6.net/dolphin/commit/?id=0344ec6d79c47a9301451c1cf376b02deb2c8fa1'/>
<id>0344ec6d79c47a9301451c1cf376b02deb2c8fa1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
