summaryrefslogtreecommitdiff
path: root/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
diff options
context:
space:
mode:
authorFiloppi <filippotarpini@hotmail.it>2021-05-04 23:50:23 +0300
committerFiloppi <filippotarpini@hotmail.it>2021-05-12 18:27:23 +0300
commitf4fec42165f245e8ad35456a25bfada8428ba1f2 (patch)
treeb0e89930e9767368778c7a4b3cc4da56da243035 /Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
parente9e41b925b6efeac4d3eadf049391ef81483528f (diff)
Add mixed comments to input code, make some tooltip clearer
Diffstat (limited to 'Source/Core/InputCommon/ControlReference/ExpressionParser.cpp')
-rw-r--r--Source/Core/InputCommon/ControlReference/ExpressionParser.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
index c96ea0599c..5e69cc42d9 100644
--- a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
+++ b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
@@ -371,6 +371,7 @@ public:
}
case TOK_ASSIGN:
{
+ // Use this carefully as it's extremely powerful and can end up in unforeseen situations
lhs->SetValue(rhs->GetValue());
return lhs->GetValue();
}
@@ -565,6 +566,9 @@ private:
// This class proxies all methods to its either left-hand child if it has bound controls, or its
// right-hand child. Its intended use is for supporting old-style barewords expressions.
+// Note that if you have a keyboard device as default device and the expression is a single digit
+// number, this will usually resolve in a numerical key instead of a numerical value.
+// Though if this expression belongs to NumericSetting, it will likely be simplifed back to a value.
class CoalesceExpression : public Expression
{
public:
@@ -945,6 +949,7 @@ static std::unique_ptr<Expression> ParseBarewordExpression(const std::string& st
qualifier.control_name = str;
qualifier.has_device = false;
+ // This control expression will only work (find the specified control) with the default device.
return std::make_unique<ControlExpression>(qualifier);
}