diff options
| author | Tillmann Karras <tilkax@gmail.com> | 2024-11-30 21:19:36 +0000 |
|---|---|---|
| committer | Tillmann Karras <tilkax@gmail.com> | 2025-02-08 11:46:49 +0000 |
| commit | 84e72c185afa918b3478e37ccabe87a1309311b2 (patch) | |
| tree | ac68cfce0dcd786cd0c4ba44df4968359ca877bf /Source/Core/VideoCommon/CommandProcessor.cpp | |
| parent | db285b7c877b37d7388756f38bdd75332232cff6 (diff) | |
VideoCommon: drop CP MMIO registers that were probably added in the wrong place
I think someone confused these with the actual token and bounding box
registers in PE, which were added later. In CP they never did anything
and it's suspicious that they have the same addresses as their PE
counterparts. On real hardware they always read as zero.
Diffstat (limited to 'Source/Core/VideoCommon/CommandProcessor.cpp')
| -rw-r--r-- | Source/Core/VideoCommon/CommandProcessor.cpp | 21 |
1 files changed, 0 insertions, 21 deletions
diff --git a/Source/Core/VideoCommon/CommandProcessor.cpp b/Source/Core/VideoCommon/CommandProcessor.cpp index 69b52c5355..857f3239b0 100644 --- a/Source/Core/VideoCommon/CommandProcessor.cpp +++ b/Source/Core/VideoCommon/CommandProcessor.cpp @@ -87,11 +87,6 @@ void CommandProcessorManager::DoState(PointerWrap& p) p.Do(m_cp_status_reg); p.Do(m_cp_ctrl_reg); p.Do(m_cp_clear_reg); - p.Do(m_bbox_left); - p.Do(m_bbox_top); - p.Do(m_bbox_right); - p.Do(m_bbox_bottom); - p.Do(m_token_reg); m_fifo.DoState(p); p.Do(m_interrupt_set); @@ -118,13 +113,6 @@ void CommandProcessorManager::Init() m_cp_clear_reg.Hex = 0; - m_bbox_left = 0; - m_bbox_top = 0; - m_bbox_right = 640; - m_bbox_bottom = 480; - - m_token_reg = 0; - m_fifo.Init(); m_is_fifo_error_seen = false; @@ -138,8 +126,6 @@ void CommandProcessorManager::Init() void CommandProcessorManager::RegisterMMIO(MMIO::Mapping* mmio, u32 base) { - constexpr u16 WMASK_NONE = 0x0000; - constexpr u16 WMASK_ALL = 0xffff; constexpr u16 WMASK_LO_ALIGN_32BIT = 0xffe0; const u16 WMASK_HI_RESTRICT = GetPhysicalAddressMask(m_system.IsWii()) >> 16; @@ -153,13 +139,6 @@ void CommandProcessorManager::RegisterMMIO(MMIO::Mapping* mmio, u32 base) // For _HI registers in this range, only bits 0x03ff can be set on GCN and 0x1fff on Wii u16 wmask; } directly_mapped_vars[] = { - {FIFO_TOKEN_REGISTER, &m_token_reg, false, WMASK_ALL}, - - // Bounding box registers are read only. - {FIFO_BOUNDING_BOX_LEFT, &m_bbox_left, true, WMASK_NONE}, - {FIFO_BOUNDING_BOX_RIGHT, &m_bbox_right, true, WMASK_NONE}, - {FIFO_BOUNDING_BOX_TOP, &m_bbox_top, true, WMASK_NONE}, - {FIFO_BOUNDING_BOX_BOTTOM, &m_bbox_bottom, true, WMASK_NONE}, {FIFO_BASE_LO, MMIO::Utils::LowPart(&m_fifo.CPBase), false, WMASK_LO_ALIGN_32BIT}, {FIFO_BASE_HI, MMIO::Utils::HighPart(&m_fifo.CPBase), false, WMASK_HI_RESTRICT}, {FIFO_END_LO, MMIO::Utils::LowPart(&m_fifo.CPEnd), false, WMASK_LO_ALIGN_32BIT}, |