| Age | Commit message (Collapse) | Author |
|---|
|
This function is unused.
|
|
Aside from being unnecessary, on Windows the flag prevents two instances
of Dolphin (one instance from before 2509-371 when the flag was
introduced and the other after) from running the same ROM
simultaneously.
Attempting to do so generated the false error `"[Rom]" is an invalid
GCM/ISO file, or is not a GC/Wii ISO.` followed by `Failed to init core`
and emulation shutdown on the second instance to start the game. Fixing
the incorrect error message is a task I'm deferring to another PR.
The problem didn't happen when both instances were 2509-371 or later,
but I ran into it while bisecting an issue and it'd be nice to avoid
that problem in the future.
|
|
Common: Treat DirectIOFile as unable to create SAF files
|
|
jordan-woyak/hookable-event-add-remove-inside-trigger
HookableEvent: Allow hooks to be added and removed from within a Trigger callback.
|
|
DolphinQt/QtUtils: Simplify RunOnObject and eliminate Common::Event race. Introduce Common::OneShotEvent class.
|
|
callback. This fixes a deadlock in FIFOFifoRecorder.
|
|
In 405baed805, we made the assumption that whether OpenAndroidContent
is able to create a new file depends on the open mode, the document
provider, and the positions of the celestial bodies. However, I'm
fairly sure that it can't create files at all as currently implemented.
First, ContentResolver.openFileDescriptor is documented as throwing
FileNotFoundException if the file doesn't exist. Now, the SAF
documentation is notoriously unreliable on matters like these, and
document providers can do whatever they want anyway, so we can't
actually trust this to mean that FileNotFoundException will always
be thrown if the file doesn't exist. But second, the Dolphin function
ContentHandler.unmangle is also unable to handle files that don't
already exist (unless the passed-in URI isn't mangled to begin with,
but to the best of my knowledge, there's no way to get a non-mangled URI
for a file that doesn't exist (unless you make assumptions about how the
document provider's URI scheme works, which we don't do in Dolphin)).
Summed up, it looks a lot like OpenAndroidContent can't create files,
or at the very least can't do so reliably.
Therefore I'm making DirectIOFile throw an assertion and return false
in situations where it's being asked to create a file under SAF. For
reference, there's no code in Dolphin that actually tries to create a
file under SAF. In all instances where we use SAF to write to files, the
file is created by the system file picker before it returns the URI of
the file to us.
What does this change gain us? First, if someone in the future tries to
use DirectIOFile to create a file under SAF, they'll be immediately
informed that this isn't supported rather than discovering it doesn't
work and chalking it up to SAF being bad for unpredictable reasons.
Second, we get rid of a call to File::Exists, which is a notable
performance improvement for game list scanning due to SAF and Dolphin's
"unmangling" being bad for reasons that unfortunately are entirely
predictable to those of us who have stared into the SAF void.
I've tested that game list scanning and game conversion still works.
|
|
is safe in situations when being immediately destructed.
|
|
pointers to functor types.
|
|
|
|
warning: definition of implicit copy constructor for 'BitField<2, 2, ColorChannel>' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
Redundant access specifier has the same accessibility as the previous access specifier.
|
|
Common and DiscIO: Introduce a thread safe DirectIOFile and make BlobReader implementations use it.
|
|
JitArm64: Add missing ORR pattern in MOVI2RImpl
|
|
Common/Functional: Fix MoveOnlyFunction from inadvertently creating references from lvalues.
|
|
a read/write position making them effectively not thread-safe.
|
|
conversions from contiguous ranges.
|
|
thread safe.
|
|
Android: Use the shared HTTP analytics backend
|
|
DolphinAnalytics: Reload backend when config changes
|
|
We can now route Android analytics through Common::HttpAnalyticsBackend, drop the Volley sender, and keep the JNI layer limited to only transfer metadata since https://bugs.dolphin-emu.org/issues/11772 has been fixed.
|
|
StringUtil: Cleanups and add some character encoding conversion unit tests.
|
|
ConfigChangedCallbackID
Co-authored-by: OatmealDome <julian@oatmealdome.me>
|
|
Dentomologist/logging_avoid_overwriting_debug_verbosity_in_release_builds
Logging: Don't overwrite LDEBUG level in Release builds
|
|
|
|
ConfigInfo: Cleanups and change mutex to a spin lock.
|
|
These locks are nearly always uncontested and this makes Config::Get faster.
|
|
std::mutex.
|
|
|
|
Co-authored-by: Dentomologist <dentomologist@gmail.com>
|
|
|
|
of deprecated std::codecvt features.
|
|
|
|
JitRegister: Remove OProfile profiler
|
|
|
|
|
|
OProfile is not used at all these days, most major distributions do not ship it anymore (Debian, Fedora, and Alpine to name the few I've checked) and following a discussion on Discord, nobody is apparently using it, most devs not even being aware of it. This removes an optional dependency from Dolphin.
|
|
references from lvalues.
|
|
Externals: Update libiconv to 1.18
|
|
Don't log a warning in GetPropertyHelper when the property isn't
present. The function returns an optional, so any callers that want to
log a warning when nullopt is returned can do so themselves.
This prevents plugged-in devices (an Xbox One controller in my case)
from spamming the message "W[COMMON]: CM_Get_DevNode_Property returned:
37" twice per second (that value being CR_NO_SUCH_VALUE).
|
|
using CfgMgr32.
|
|
Jit64: Dynamic length of regular jump instruction (for known addresses)
|
|
macoS: update QoSSession with SO_NET_SERVICE_TYPE.
|
|
|
|
Conditional jumps already do that, so let's be consistent.
|
|
Dentomologist/deletedirrecursively_dont_report_error_if_directory_is_absent
DeleteDirRecursively: Don't report error for absent directory
|
|
Check if the return value of std::filesystem::remove_all is -1 rather
than 0; the former is the specified return value if there's an error
while 0 just means the directory already didn't exist (which is the end
result we want).
Previously error messages such as the following were possible:
E[COMMON]: DeleteDirRecursively: [path]/User/RedirectSession/ failed The
operation completed successfully.
Also adds a period in the error string to make it look nicer.
|
|
|
|
|
|
an error number.
|
|
|
