| Age | Commit message (Collapse) | Author |
|---|
|
In NandPaths.cpp, the `std::initializer_list<char>` of illegal characters has been turned into a `char[]` (similar to the one in GameList.cpp).
The reverse iteration in ResourcePack.cpp seemed to provide no benefits, and doing without it it seemed to have no ill effects.
|
|
The new `Common::Contains` and `Common::ContainsSubrange` function objects mirror C++23's `std::ranges::contains` and `std::ranges::contains_subrange`, respectively.
|
|
Ranges Algorithms Modernization - Of
|
|
Ranges Algorithms Modernization - Return
|
|
In JitRegCache.cpp, the lambda predicate were replaced by a pointer to member function because ranges algorithms are able to invoke those.
In ConvertDialog.cpp, the `std::mem_fn` helper was removed because ranges algorithms are able to handle pointers to member functions as predicates.
In BoundingBox.cpp, the lambda predicate was returning the bool element unchanged, so `std::identity` was a better fit.
|
|
In WiimoteReal.cpp, JitRegCache.cpp, lambda predicates were replaced by pointers to member functions because ranges algorithms are able invoke those.
In ConvertDialog.cpp, the `std::mem_fn` helper was removed because ranges algorithms are able to handle pointers to member functions as predicates.
|
|
In DITSpecification.cpp, MaterialAsset.cpp, and ShaderAsset.cpp, lambda predicates were replaced by pointers to member functions because ranges algorithms are able invoke those.
In NetPlayClient.cpp, the non-trivial `NetPlay::Player` elements were being passed by value in `NetPlayClient::DoAllPlayersHaveGame()`. This has been fixed.
In WIABlob.cpp, the second example's predicate was returning the `std::optional` by value instead of implicitly converting it to a bool. This has been fixed.
|
|
`Common::IsLower(char)` was omitted as nothing needed it.
|
|
|
|
Split `SettingsHandler` into separate reader and writer classes
|
|
Ranges Algorithms Modernization - Rewrite
|
|
|
|
Fulfilling a certain six-year-old todo.
|
|
A preliminary commit for a cleaner diff and an easier review
|
|
The new return value is `std::ranges::subrange`.
|
|
Ranges Algorithms Modernization - Trivial
|
|
Ranges Algorithms Modernization - Find
|
|
The inequality operator is automatically generated by the compiler if `operator==` is defined.
|
|
|
|
|
|
|
|
In StringUtil.h, the lambdas wrapping `Common::ToLower(char)` and `Common::ToUpper(char)` were only necessary due to the function names being overloaded.
|
|
|
|
|
|
|
|
IniFile: Migrate `Common::CaseInsensitiveLess` to StringUtil
|
|
With 12 uses of `JoinStrings` in the codebase vs 36 uses of `fmt::join`, fmtlib's range adapter for string concatenation with delimiters is clearly the preferred option.
|
|
Migrating `Common::CaseInsensitiveLess` to StringUtil.h will hopefully discourage rolling one's own solution in the future for case-insensitive associative containers when this (quite robust!) solution already exists.
`Common::CaseInsensitiveStringCompare::IsEqual` was removed in favor of using the `Common::CaseInsensitiveEquals` function.
The `a.size() != b.size()` condition in `Common::CaseInsensitiveEquals` can be removed, since `std::ranges::equal` already checks this condition (confirmed in libc++).
|
|
Add support for libfmt-11
|
|
This temporary solution is no longer needed.
|
|
fmt::join was moved into fmt/ranges.h
Signed-off-by: Alfred Wingate <parona@protonmail.com>
|
|
|
|
BitUtils: Constexpr BitCastToArray, Remove BitCastFromArray
|
|
`std::bit_cast` participates in overload resolution only if `sizeof(To) == sizeof(From)` and both `To` and `From` are *TriviallyCopyable* types, so the static assertions here can be removed. `[[nodiscard]]` was added as well.
|
|
|
|
Use 'contains' method
|
|
|
|
|
|
Adjust order and spacing of various #includes
|
|
Move some #includes around to match the Contributing guidelines.
|
|
It now supports variable-sized data payloads and memory range freeing. It's a little faster, too.
|
|
|
|
comply with https://eel.is/c++draft/lex.name#3.1 (fixes compilation under newlib; e.g. devkitPro)
|
|
|
|
|
|
Badges are saved in /User/Cache/RetroAchievements on first download and reused from there instead of redownloaded.
|
|
|
|
|
|
Branch Watch Tool: Optimizations
|
|
Common: add Json helper utilities for loading or saving to a file
|
