| Age | Commit message (Collapse) | Author |
|---|
|
Make netplay's "same game" check more robust
|
|
The new hash check catches essentially all desync problems
that VolumeVerifier can catch, so from the user's perspective,
such problems will result in Dolphin refusing to start the
game on netplay rather than actually getting a desync.
|
|
When I first made VolumeVerifier, I figured that the distinction
between an unsigned ticket and an unsigned TMD was a technical
detail that users would have no reason to care about. However,
while this might be true for discs, it isn't equally true for
WADs, due to the widespread practice of fakesigning tickets to
set the console ID to 0. This practice does not require
fakesigning the TMD (though apparently people do it anyway,
at least sometimes...), and the presence of a correctly signed
TMD is a useful indicator that the contents have not been
tampered with, even if the ticket isn't correctly signed.
|
|
It is my opinion that nobody should use NKit disc images without
being aware of the drawbacks of them. Since it seems like almost
nobody who is using NKit disc images knows what NKit is (hmm, now
how could that have happened...?), I am adding a warning to Dolphin
so that you can't run NKit disc images without finding out about the
drawbacks. In case someone really does want to use NKit disc images,
the warning has a "Don't show this again" option. Unfortunately, I
can't retroactively add the warning where it's most needed:
in Dolphin 5.0, which does not support Wii NKit disc images.
|
|
I forgot to do this in the PR where I added Volume::IsDatelDisc.
|
|
Replacement for the reverted commit
f9705fd1176432755df3dba0ef5c50f505193371.
|
|
|
|
Fixes a false positive for Mario Party 8.
|
|
Replace the compress/uncompress actions with a convert dialog
|
|
|
|
The constant DESIRED_BUFFER_SIZE was determined by multiplying the
old hardcoded value 32 with the default GCZ block size 16 KiB.
Not sure if it actually is the best value, but it seems fine.
|
|
Fix VolumeVerifier not showing a problem for invalid partitions
|
|
Otherwise GetBiggestReferencedOffset might treat garbage data as a valid
large offset, making Dolphin incorrectly say that the disc is too small.
|
|
|
|
Not sure why that was there.
|
|
|
|
|
|
A small, nonexhaustive set of warning fixes. The DiscIO Volume change
is a workaround for a GCC bug [1] that causes returning an unengaged
std::optional to emit annoying -Wmaybe-uninitialized warnings.
This last change alone fixes pages upon pages of warnings since
Volume.h is included from several files.
-Wstringop-truncation is another irrelevant warning for us, but
unfortunately there seems to be no way to disable it without
adding ugly pragmas wherever the warning appears.
|
|
std::binary_sort().
Debug builds only, since this is wrapped in assert().
|
|
string_view is a thin wrapper around C strings, so it's more efficient
for constant strings than C++ strings.
The unordered_set<> also adds extra runtime overhead. For small arrays,
a simple linear search works. For larger arrays, std::binary_search()
works better than linear but without the unordered_set<> overhead.
ShouldBeDualLayer(): Removed a duplicate "SK8X52" entry.
|
|
https://bugs.dolphin-emu.org/issues/11900
|
|
This was completely wrong, but I guess it happened to work correctly
anyway due to timing reasons (MD5 is faster than SHA-1 + AES).
|
|
This happens if someone manually downloads a regular datfile from
redump.org and puts it where Dolphin stores datfiles. Dolphin needs
"special" datfiles that contain fields for serials and versions.
Before this change, all discs (except Datel discs) would show up as
"Unknown disc" when using a regular datfile.
|
|
RedumpVerifier: Fix handling of Datel Wii disc serials
|
|
GC Datel discs have empty serials, but Wii Datel discs have
serials starting with DS followed by some digits.
|
|
|
|
My bad...
|
|
Create necessary folder when using Redump.org integration
|
|
This was making it impossible to use the Redump.org integration
without first manually creating a Redump folder in the Cache folder.
https://bugs.dolphin-emu.org/issues/11885
|
|
|
|
VolumeVerifier: Improve region/game ID mismatch checking
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Re-implement FixCommonKeyIndex for WAD files
|
|
Fix VolumeVerifier considering Wii Menu WADs to have wrong region
|
|
The old implementation of this was not able to distinguish between
a title that had the common key index set to 1 because it actually
was Korean and a title that had the common key index set to 1 due to
fakesigning. This new implementation solves the problem by
decrypting a content with each possible common key and checking
which result matches the provided SHA-1 hash.
The problem that the old implementation causes has only been reported
to affect a certain pirated WAD of Chronos Twins DX (WC6EUP), but it's
possible that the problem would start affecting more WADs if we add
support for the vWii common key (which uses index 2). Adding support
for the vWii common key would also prevent us from using the simpler
solution of always forcing the index to 0 if the title is not Korean.
|
|
|
|
These two classes are very similar, so let's merge them.
|
|
|
|
Closes another gap in the Common library where code isn't being
namespaced under it.
|
|
As indicated by mbedTLS' documentation, all of the relevant functions
have been superseded by _ret-suffixed variants in mbedTLS version
2.7.0.
|
|
The overload taking a partition is already a const member function, so
this one can be turned into one as well.
|
|
Allows providing better names than "first" or "second".
|
|
Removes redundant initializers from the constructor and provides
initializers for all members that don't already have one for consistency
(and deterministic initial state).
|
