| Age | Commit message (Collapse) | Author |
|---|
|
We often use game IDs in paths, so we should try to make sure path
traversal is impossible in game IDs. Admittedly, doing any kind of real
attack using the six bytes available in game IDs is unrealistic, but no
game ID should contain non-alphanumeric or non-ASCII characters anyway.
Might also fix https://bugs.dolphin-emu.org/issues/13982 by skipping
converting between encodings for game IDs.
|
|
This had to be in the header back when it was templated, but 083faa8b
made it not templated.
|
|
|
|
|
|
VolumeDisc: Fix Triforce's GetGameID memcpy by checking MakerID's size
|
|
Fixed a bug caused by static usage of Core::System::GetInstance()
Removed unused headers
Removed unneeded code
Optimised code
Added sanity checks
Added SafeCopyFromEmu/SafeCopyToEmu
Set Triforce buttons to be translatable
|
|
|
|
std::array.
|
|
|
|
|
|
Yellow squiggly lines begone!
Done automatically on .cpp files through `run-clang-tidy`, with manual corrections to the mistakes.
If an import is directly used, but is technically unnecessary since it's recursively imported by something else, it is *not* removed.
The tool doesn't touch .h files, so I did some of them by hand while fixing errors due to old recursive imports.
Not everything is removed, but the cleanup should be substantial enough.
Because this done on Linux, code that isn't used on it is mostly untouched.
(Hopefully no open PR is depending on these imports...)
|
|
|
|
Common: Replace Result with std::expected.
|
|
|
|
|
|
Fix an error generated by Clang from the destructor of
`std::unique_ptr<FileInfo> m_file_info` when setting the standard
version to c++23:
`invalid application of 'sizeof' to an incomplete type 'DiscIO::FileInfo'`
|
|
|
|
Use minizip-ng's CMakeLists instead of relying on our own implementation
|
|
Common/Result: Swap order of template parameters to match C++26's std::expected.
|
|
This is a carry over from back when we used `minizip` and had our own CMakeLists for it.
|
|
CachedBlobReader.
|
|
into memory in the background.
|
|
std::expected, make all member functions constexpr, and add moving "unexpected" conversion constructor for consistency.
|
|
DiscIO: Remove redundant casts
|
|
CopyReader functionality thread safe.
|
|
|
|
Unlike custom banners which work as an override, this mechanism works as
a fallback. The use case is if you have games you don't really play but
want to keep around for testing purposes without filling up your NAND
with lots of saves. For ease of use, the directory structure is the same
but only title/$title_hi/$title_lo/data/banner.bin files are
relevant.
|
|
|
|
tygyh/Enforce-overriding-destructor-style-Core&UnitTests
Core & UnitTests: Make overriding explicit and remove redundant virtual specifiers on overriding destructors
|
|
|
|
Use minizip-ng in non-compatibility mode
|
|
This is a continuation of 552b6da. That commit hid sys/boot.bin, but not
disc/header.bin, which is only present for Wii games.
Fixes https://bugs.dolphin-emu.org/issues/13810.
|
|
|
|
|
|
tygyh/DiscIO-Pass-parameters-by-constant-reference
DiscIO: Pass parameters by constant reference
|
|
Hide DirectoryBlob boot.bin files from game list
|
|
overriding destructors - Core & UnitTests
|
|
Extracted games contain a boot.bin file that contains the disc header.
These boot.bin files are considered valid volumes by Dolphin, since
Dolphin only checks the disc header to determine if something is a valid
GC/Wii disc. Running them doesn't make any sense, though.
boot.bin files used to not be scanned by Dolphin due to their file
extension, but .bin was added to the list of file extensions to scan for
in 494e2c0. To stop them from showing up in the game list, let's update
the ShouldHideFromGameList mechanism.
|
|
find ./Source/ -name '*.cpp' -o -name '*.h' | xargs clang-format-19 -i
|
|
DiscIO: Remove redundant qualifiers
|
|
|
|
|
|
|
|
DiscIO: Make variables constexpr
|
|
tygyh/DiscIO-Use-default-to-define-a-trivial-destructor
DiscIO: Use `= default` to define a trivial destructor
|
|
tygyh/DiscIO-Remove-redundant-zero-initializers-in-aggregate-initializations
DiscIO: Remove redundant zero initializers in aggregate initializations
|
|
|
|
|
|
|
|
|
