summaryrefslogtreecommitdiff
path: root/Source/Core/DolphinQt/NetPlay/NetPlayDialog.cpp
AgeCommit message (Collapse)Author
2024-10-04Partially revert "Revert "Audit uses of IsRunning and GetState""JosJuice
This reverts the revert commit bc67fc97c39628c76a4dbca411b0e8a9bfaf726a, except for the changes in BaseConfigLoader.cpp, which caused the bug that made us revert 72cf2bdb87f09deff22e1085de3290126aa4ad05. PR 12917 contains an improved change to BaseConfigLoader.cpp, which can be merged (or rejected) independently. A few changes have also been made based on review comments.
2024-08-22Add support for libfmt-11Alfred Wingate
fmt::join was moved into fmt/ranges.h Signed-off-by: Alfred Wingate <parona@protonmail.com>
2024-08-14Use 'contains' methodDr. Dystopia
2024-06-26Revert "Audit uses of IsRunning and GetState"JosJuice
This reverts commit 72cf2bdb87f09deff22e1085de3290126aa4ad05. SYSCONF settings are getting cleared when they shouldn't be. Let's revert the change until I get proper time to figure out why it's broken.
2024-06-21Audit uses of IsRunning and GetStateJosJuice
Some pieces of code are calling IsRunning because there's some particular action that only makes sense when emulation is running, for instance showing the state of the emulated CPU. IsRunning is appropriate to use for this. Then there are pieces of code that are calling IsRunning because there's some particular thing they must avoid doing e.g. when the CPU thread is running or IOS is running. IsRunning isn't quite appropriate for this. Such code should also be checking for the states Starting and Stopping. Keep in mind that: * When the state is Starting, the state can asynchronously change to Running at any time. * When we try to stop the core, the state gets set to Stopping before we take any action to actually stop things. This commit adds a new method Core::IsUninitialized, and changes all callers of IsRunning and GetState that look to me like they should be changed.
2024-05-01Core::IsRunning: Avoid Global System Accessormitaclaw
2023-11-30Merge pull request #11382 from skyfloogle/traversal-fix-2Mai
Traversal: Use low TTL for probe packet
2023-11-04DolphinQt: Remove unnecessary qOverloadsDentomologist
qOverload is used to disambiguate pointers to overloaded functions, but most of the usages in the code base were with non-overloaded functions.
2023-08-12DolphinQt: Set window decorations for all top-level QWidgets.Admiral H. Curtiss
2023-05-20Traversal: Notify user of TTL to be usedFloogle
2023-04-24Common/TraversalProto: Move interface into Common namespaceLioncash
Gets the types out of the global namespace.
2023-04-24Common/TraversalClient: Move interface into Common namespaceLioncash
Gets the interface out of the global namespace.
2023-01-31Cleanup headersScott Mansell
2022-09-24Merge pull request #11047 from AdmiralCurtiss/netplay-save-options-reworkAdmiral H. Curtiss
Netplay: Simplify save data options.
2022-09-22Merge pull request #10949 from Zopolis4/reprecatedJMC47
Resolve C++20 deprecation warnings
2022-09-20Netplay: Simplify save data options.Admiral H. Curtiss
2022-09-19Netplay: Rename variable names in NetSettings to match style guide.Admiral H. Curtiss
2022-08-08Resolve "implicit capture of ‘this’ via ‘[=]’ is deprecated in ↵Zopolis4
C++20" warning
2022-08-02NetPlay: rename md5 -> game digestShawn Hoffman
2022-05-24NetPlay: Make messages about non-matching games clearerPokechu22
2022-03-15NetPlayDialog: Display external IP/Port as seen by the traversal server when ↵Jordan Woyak
it's used.
2021-12-14Core/WiiRoot: Handle the combination of NetPlay and savegame redirects.Admiral H. Curtiss
2021-11-22NetPlay: Pass Wii FS sync data directly to game boot logic instead of ↵Admiral H. Curtiss
indirectly through globals.
2021-11-22NetPlay: Refactor game boot code path to allow passing BootSessionData ↵Admiral H. Curtiss
through it.
2021-07-22NetPlay: Split save and SD card write settingsTechjar
This actually eliminates any setting pertaining to SD cards from the NetPlay dialog, as it would effectively just be a duplicate of the setting in the Wii pane, potentially causing confusion. This also enables save data writing by default, as this is probably what most players want, and should avoid them losing hours of progress because they forgot to tick a checkbox.
2021-07-13NetPlay: GBA SupportBonta
2021-07-05treewide: convert GPLv2+ license info to SPDX tagsPierre Bourdon
SPDX standardizes how source code conveys its copyright and licensing information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX tags are adopted in many large projects, including things like the Linux kernel.
2021-05-19NetPlay: Move NetSettings initialization to backendTechjar
It doesn't really belong in frontend code, and this change will make it easier to eventually support NetPlay on other UI frameworks.
2021-04-06Disable ICache emulation for some gamesPokechu22
Specifically, 'Scooby-Doo! Mystery Mayhem', 'Scooby-Doo! Unmasked', 'Ed, Edd n Eddy: The Mis-Edventures', and the Wii version of 'Happy Feet'. The JIT cache causes problems with emulated icache invalidation in these games, resulting in areas failing to load.
2021-03-07NetPlay: Sync more settingsJosJuice
2021-01-27Merge pull request #9440 from lioncash/qt6Léo Lam
DolphinQt: Qt 6.0 forward-compatibility changes
2021-01-20TraversalClient: Convert state enum into an enum classLioncash
Prevents implicit conversions and prevents identifiers from polluting the class scope.
2021-01-13DolphinQt: Explicitly include <QActionGroup> where applicableLioncash
An indirect inclusion scenario that breaks on Qt 6.0
2020-11-25Frontends: Migrate logs over to fmtLioncash
2020-11-21Fix variable shadowing warningsLéo Lam
2020-10-01GameListModel instance ownership transferred back to the GameList instance. ↵Christian Aguilera
The GameListModel instance will be passed as a constructor parameter where needed.
2020-08-02Allow translations and custom names in GameFile::GetNetPlayNameJosJuice
There is no longer any major reason for why this function would need to return the same result for all players.
2020-08-02Make netplay's "same game" check more robustJosJuice
Instead of comparing the game ID, revision, disc number and name, we can compare a hash of important parts of the disc including all the aforementioned data but also additional data such as the FST. The primary reason why I'm making this change is to let us catch more desyncs before they happen, but this should also fix https://bugs.dolphin-emu.org/issues/12115. As a bonus, the UI can now distinguish the case where a client doesn't have the game at all from the case where a client has the wrong version of the game.
2020-05-28Add option to disallow SD card writesTechjar
2020-04-28DolphinQt: Use qOverload where applicableLioncash
Provides the same behvaior, but in a much more concise manner.
2020-04-03DolphinQt: Run tasks that use progress dialogs on separate threadsJosJuice
2020-02-06DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView.Jordan Woyak
2019-08-26NetPlay: Remove 'reduce polling rate' optionTechjar
With the SI poll line count fixed, pretty much all games are polling twice per frame anyways, making this option superfluous. Since it's a bit of a gross hack and makes DTMs incompatible with console, let's just bin it.
2019-08-21Merge pull request #8222 from JosJuice/allow-mismatched-region-settingsAnthony
Replace "Override Language on NTSC Games" with "Allow Mismatched Region Settings"
2019-08-09Replace "Override Language on NTSC Games" with "Allow Mismatched Region ↵JosJuice
Settings" This new setting is like Override Language on NTSC Games, except instead of only applying to the GameCube language setting, it also applies to the Wii language setting. Fixes https://bugs.dolphin-emu.org/issues/11299
2019-07-30Show a message in netplay chat when a player joins or leavesBrandon Rothweiler
2019-05-31Qt/NetPlayDialog: Change network mode options to radio buttonsTechjar
This changes the Host Input Authority and Golf Mode checkboxes into a set of radio buttons, consisting of Fair Input Delay, Host Input Authority, and Golf Mode. This represents the 3 network modes we have. Although Golf Mode is just an extension of Host Input Authority, it's more logical to the user to present it as a separate option, rather than enabling the Golf Mode checkbox only when Host Input Authority is enabled. This also eliminates the need to first enable Host Input Authority before Golf Mode can be enabled. This also adds tooltips to provide brief descriptions of the options, as well as reintroducing tooltips that were previously removed.
2019-05-30Qt/NetPlayDialog: Move settings loading into LoadSettingsTechjar
2019-05-04Qt/NetPlayDialog: Fix checksum menu being visible for everyoneTechjar
The wrong function was used to attempt to hide the menu. Non-hosts will segfault upon trying to use it as they don't have a server instance.
2019-04-23Qt/NetPlayDialog: Move MD5 button into menubarspycrab