| Age | Commit message (Collapse) | Author |
|
always applying 50%.
Make "Clear" button reset "Modifier" "Range" settings to 50%.
|
|
|
|
Removed useless locks to DeviceContainer::m_devices_mutex, as they were all already protected by m_devices_population_mutex.
We have no interest in blocking other threads that were potentially reading devices at the same time so this seems fine.
This simplifies the code, and I've adjusted a few comments which mentioned possible deadlock that should now be totally gone.
The deadlock could have happen if a thread directly called EmulatedController::UpdateReferences(), while another another thread also reached EmulatedController::UpdateReferences() within a call to ControllerInterface::UpdateDevices(), as the mentioned function locked both the DeviceContainer::m_devices_mutex and s_get_state_mutex at the same time.
The deadlock was frequent on game emulation startup on Android, due to the UpdateReferences() call in InputConfig::LoadConfig() and the UI thread triggering calls to ControllerInterface::UpdateDevices().
It could also have happened on Desktop if a user pressed "Refresh Devices" manually in the UI while the input config was loading.
Also brought some UpdateReferences() comments and thread safety fixes from https://github.com/dolphin-emu/dolphin/pull/9489
|
|
SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.
|
|
-add a way to reset their value (from the mappings UI)
-fix "memory leak" where they would never be cleaned,
one would be created every time you wrote a character after a "$"
-fix ability to create variables with an empty string by just writing "$" (+added error for it)
-Add $ operator to the UI operators list, to expose this functionality even more
|
|
clean code
My future PRs will split the UI state from the Emulation State of some of these emulated
controller values and this readies the code for it.
|
|
casting a value to a u32 when it's originally an int, and it's exposed as int to users,
could end up in cases where a negative number would result as a positive one.
This doesn't really affect the value range of the attachment enum,
still I think the code was wrong.
Heavily tested.
|
|
Similar to the guitar, only control[0] was checked, and that felt random.
|
|
Input cleanup
|
|
Works exactly as before by default.
It will be used by my upcoming input PRs.
|
|
NumericSettings support a max, so let's use it.
It might not do much now, but the max and min values will be used to give visual feeback
in the UI in one of my upcoming input PRs
|
|
|
|
The control expression editor allows line breaks, but the serialization was
losing anything after the first line break (/r /n).
Instead of opting to encode them and decode them on serialization
(which I tried but was not safe, as it would lose /n written in the string by users),
I opted to replace them with a space.
|
|
And remove useless include
|
|
fix some related grammar errors
only the ButtonManager required code changes
|
|
to only pitch or only yaw
|
|
only running dynamic input textures once for all controllers
|
|
|
|
[committer note: fixed commit message style]
|
|
|
|
|
|
WiimoteEmu: Expose IR camera FOV to adjust IMU pointing sensitivity.
|
|
InputCommon: Dynamic Input Textures
|
|
ControllerEmu: Improve and simplify UpdateCalibrationData.
|
|
|
|
an emulated input action to an image based on what host key is defined for that emulated input. Specific regions are called out in configuration that mark where to replace an input button with a host key image.
|
|
of regular "Point" settings.
Removed "Total Yaw" from included Wii remote input profile to take on the default value.
|
|
FOV and to reach screen edges in the Wii Menu.
|
|
|
|
|
|
ControllerInterface/Wiimote: Provide fallback values for extensions with bad calibration.
|
|
|
|
calibration data.
|
|
While having motion control emulation of IR enabled by default
makes sense in situations like using a DualShock 4 on a PC,
Android has the additional option of touch emulation of IR
which seems to be better liked, and the default value which
was chosen with PC in mind was carried over to Android
without any particular consideration. This change disables
motion control emulation of IR by default on Android only.
|
|
|
|
|
|
|
|
|
|
|
|
to connect additional Wii Remotes.
|
|
and calibration data to calculate normalized input values.
|
|
|
|
|
|
|
|
InputCommon: Only update setting expressions when the input gate is enabled.
|
|
|
|
|
|
|
|
|
|
|