summaryrefslogtreecommitdiff
path: root/Source/Core
AgeCommit message (Collapse)Author
2024-09-01CachedInterpreterEmitter: Fix `std::memcpy` UBmitaclaw
I wasn't aware that even with a size of zero, it's still not safe to pass a nullptr to `std::memcpy`. When `CachedInterpreterEmitter::PoisonCallback` is written, UB is happening.
2024-08-31Merge pull request #13044 from JosJuice/subfic-carryTilka
Interpreter: Fix subfic carry calculation
2024-08-31Interpreter: Fix subfic carry calculationJosJuice
This was accidentally using the instruction's output instead of the instruction's input when the input and output registers were the same.
2024-08-31Merge pull request #13031 from parona-source/libfmt-11Admiral H. Curtiss
Add support for libfmt-11
2024-08-31Merge pull request #13042 from homeisfar/vk_improve_loggerTilka
vulkan: Add line number to vulkan error logger
2024-08-31Merge pull request #13039 from ↵Tilka
Dentomologist/mainwindow_fix_hidden_confirm_on_stop_dialog MainWindow: Prevent Confirm On Stop dialog from being hidden by the Render window
2024-08-31Merge pull request #13038 from Ferdi265/fix-rvz-clang-ubTilka
RVZ: Fix undefined behaviour when copying 0 bytes to a null pointer
2024-08-28vulkan: Add line number to vulkan error loggerAli Homafar
This is a minor improvement to add line numbers to the LOG_VULKAN_ERROR define. Basically error logs for Vulkan will now look like: ``` // This 25:03:347 VideoBackends/Vulkan/VulkanLoader.cpp:247 E[Video]: (WaitForCommandBufferCompletion:278) vkWaitForFences failed: (2: VK_TIMEOUT) // Instead of 15:45:154 VideoBackends/Vulkan/VulkanLoader.cpp:247 E[Video]: (WaitForCommandBufferCompletion) vkWaitForFences failed: (2: VK_TIMEOUT) ```
2024-08-27MainWindow: Prevent Confirm On Stop dialog from being hiddenDentomologist
Set the Render Window as the parent of the Confirm On Stop confirmation dialog when Keep Window On Top is enabled, ensuring it will always be visible. Previously, when Confirm On Stop and Keep Window On Top were both enabled the Confirm On Stop dialog could be hidden by the render window in the following situations: * Clicking Stop in the Main Window * Clicking the Main Window's close button * Pressing the Stop hotkey while in FullScreen mode This was particularly troublesome because the confirm dialog is modal, preventing the user from moving the render window out of the way if it was obscuring the dialog. Fixes https://bugs.dolphin-emu.org/issues/13247.
2024-08-27Merge pull request #13037 from ↵Tilka
Dentomologist/hotkeyscheduler_handle_wiimote_connections_independently HotkeyScheduler: Handle Wii Remote connections independently
2024-08-27RVZ: Fix undefined behaviour when copying 0 bytes to a null pointerFerdinand Bachmann
A vector of length 0 can have a null data pointer, which causes UB when passed to memcpy, so only copy when we actually have data to copy. This caused crashes in certain cases when compiling Dolphin with Clang and LTO enabled.
2024-08-26HotkeyScheduler: Handle Wii Remote connections independentlyDentomologist
Allow connecting or disconnecting multiple Wii Remotes simultaneously instead of only handling the highest index whose hotkey is pressed. This allows using a single hotkey to toggle multiple remotes.
2024-08-24AX: add analytics quirks for wiimote filtersTillmann Karras
I'm fairly sure the implementation is correct but I've not been able to find a game that actually makes use of these filters.
2024-08-24AX: enable low-pass/biquad filtering of Wiimote audioTillmann Karras
2024-08-24AX: add support for biquad filteringTillmann Karras
This fixes e.g. the overly loud wind in "I SPY: Spooky Mansion".
2024-08-24Merge pull request #13009 from BryanJacobs/masterJosJuice
Graphics: Adapt aspect ratio when SBS/TAB 3D is used
2024-08-23Merge pull request #13033 from mitaclaw/remove-common-fillTilka
TypeUtils: Remove Common::Fill
2024-08-22Skylanders: Fix Hot Head (Sparkle)lycheefox
2024-08-22TypeUtils: Remove Common::Fillmitaclaw
This temporary solution is no longer needed.
2024-08-22Add support for libfmt-11Alfred Wingate
fmt::join was moved into fmt/ranges.h Signed-off-by: Alfred Wingate <parona@protonmail.com>
2024-08-22Graphics: Adapt aspect ratio when SBS/TAB 3D is usedBryan Jacobs
Adds support for choosing to present the full resolution independently to each eye when using side-by-side or top-and-bottom 3D.
2024-08-21Merge pull request #13029 from JosJuice/sddressOatmealDome
DolphinQt: Fix "Sddress" typo
2024-08-21DolphinQt: Fix "Sddress" typoJosJuice
2024-08-21Merge pull request #13028 from lycheefox/skylandersOatmealDome
Skylanders: Add Mobile Hot Streak and fix typo
2024-08-20Skylanders: Add Mobile Hot Streak and fix typolycheefox
2024-08-20Remove redundant semicolonsDr. Dystopia
2024-08-19Add instructive text to disabled RetroAchievements login buttonNivekH
Changes the RetroAchievements "Log In" button's text to "To log in, stop the current emulation." when the button is disabled because an emulation session is active. This allows a user to understand why the button is disabled, and how this state can be resolved. Previously, it could be unclear why this button was disabled without an understanding of the underlying system. Co-Authored-By: JosJuice <josjuice@gmail.com>
2024-08-18DolphinQt: Simplify the Speed Limit descriptionJosJuice
The description of the Speed Limit setting currently uses a lot of complicated terms, like "emulated time" (known to many Dolphin developers, but in my experience not known by even advanced emulator users) and "maximum time scale" (I have never heard it before). The meaning of "sustainable" is also unclear in context. This commit rewords the description to be easier to understand.
2024-08-18Merge pull request #13021 from Pokechu22/stereo-post-processing-uiTilka
Fix postprocessing shader not changing when setting stereo mode
2024-08-17Fix postprocessing shader not changing when setting stereo modePokechu22
Fixes https://bugs.dolphin-emu.org/issues/13593. Before, it would attempt to use the old shader, which did not exist for the new stereo mode. Changing the postprocessing shader afterwards would work properly, although passive 3D only has one option, so it was just broken without restarting Dolphin. This also fixes the UI not updating when using one of the stereo toggle hotkeys.
2024-08-18GameSettings: remove patches for "Wallace & Gromit in Project Zoo"Tillmann Karras
These patches were added in bde9a459cdd7a465cf9c9e275bd4562bb072ae7e and enabled by default in 36ecfdd6b597b0264625d06320a5308147bbc55b. They allowed the game to run in Dolphin but disabled dynamic shadows. The game adds 4 to the start address of otherwise valid display lists for no obvious reason. Now that Dolphin forces 32-byte alignment these patches are no longer needed.
2024-08-18VideoCommon: force 32-byte alignment for display list address and sizeTillmann Karras
2024-08-18Merge pull request #12773 from Tilka/zelda_filtersTilka
DSPHLE/Zelda: Add two missing filters
2024-08-17Merge pull request #13008 from noahpistilli/kd-get-time-triggersTilka
IOS/KD: Implement Get Time Triggers
2024-08-17Merge pull request #12889 from mitaclaw/constexpr-bitutils-1Tilka
BitUtils: Constexpr BitCastToArray, Remove BitCastFromArray
2024-08-16BitUtils: Constexpr BitCastToArray, Remove BitCastFromArraymitaclaw
`std::bit_cast` participates in overload resolution only if `sizeof(To) == sizeof(From)` and both `To` and `From` are *TriviallyCopyable* types, so the static assertions here can be removed. `[[nodiscard]]` was added as well.
2024-08-16DolphinQt: Delete output Sys folder before copying to itJosJuice
For a long time now, we've had a problem where game INIs persist in the copied Sys folder if they've been deleted from the original Sys folder. (I still have hundreds of game INIs locally that only set EmulationStateId, and we removed those game INIs 6 years ago. On the buildbot, we do occasionally clear out the build directories manually, so I'd assume it's not quite as bad there.) This commit fixes the problem by deleting the output Sys folder before copying the original Sys folder to the output Sys folder. This should be a bit slower, but in my testing, the difference seems small. At least if you have an SSD, which I really hope people have nowadays! Operating systems other than Windows have not been touched, because: * Android: Already explicitly deletes the output Sys folder. * macOS: Does some magic to put the Sys folder in the app bundle, which I will simply assume isn't affected by this problem, without testing. * Linux: Expects the person building to manually manage the Sys folder.
2024-08-16MSBuild: Use SkipUnchangedFiles with CopyJosJuice
Just a bit of simplification.
2024-08-16Merge pull request #13015 from tygyh/Use-boolean-literalsTilka
Replace boolean constants with boolean literals
2024-08-16Merge pull request #13010 from OatmealDome/goodbye-steamTilka
Remove Steam support
2024-08-16DolphinTool: print title IDs in hexTillmann Karras
2024-08-16Small wording changes for dump conversionsTillmann Karras
2024-08-16Merge pull request #13012 from mitaclaw/Use-contains-method-2Tilka
Use contains method 2
2024-08-16Merge pull request #10556 from cpba/detectflatpakOatmealDome
Detect when running inside a flatpak sandbox
2024-08-15Fixed missing game badge in achievements dialogLillyJadeKatrin
2024-08-15Misc. Container Find Changesmitaclaw
2024-08-15Use 'contains' methodmitaclaw
2024-08-15DolphinQt: Remove Steam runtime build supportOatmealDome
2024-08-15UICommon: Remove Steam user directory logicOatmealDome
2024-08-15DolphinQt: Remove entitlements for Steam overlayOatmealDome