| Age | Commit message (Collapse) | Author |
|---|
|
MainWindow: Fix sscanf type/width specifiers for DWORD
|
|
ControllerInterface: Turn off SDL's GameCube controller adapter handling when Dolphin is configured to use the adapter.
|
|
This function is unused.
|
|
|
|
|
|
when Dolphin is configured to use the adapter.
|
|
If we're on an x64 CPU that doesn't have the MOVBE extension, trying to
SwapAndStore a host register results in that register's value getting
clobbered with the swapped value. Jit64::stX and Jit64::stXx detect this
case, and if necessary, emit a MOV to a register that's fine to clobber.
This logic was broken by the merge of PR 12134. Jit64::stX and
Jit64::stXx were assuming that if RegCache::IsImm returns true for a
guest register, calling RegCache::Use or RegCache::BindOrImm for that
guest register would result in an immediate. However, PR 12134 made it
possible for a guest register to have both a host register and an
immediate in the register cache at the same time. When this happens,
RegCache::IsImm returns true, yet RegCache::Use and RegCache::BindForImm
return an RCOpArg whose Location returns a host register. (To make it
extra confusing, RCOpArg::IsImm calls RegCache::IsImm if the RCOpArg
came from RegCache, so RCOpArg::IsImm returns true!)
To fix this, in cases where Jit64::stX and Jit64::stXx explicitly need
an immediate to avoid having to emit an extra MOV, let's call
RegCache::Imm32 so that we're certain that we're getting an immediate.
This fixes an issue on older x64 CPUs that manifested as e.g. completely
broken graphics in Spyro: Enter the Dragonfly.
|
|
Dentomologist/jit64_avoid_passing_immediate_to_non_immediate_parameter
Jit64: Avoid passing immediate to non-immediate parameter
|
|
DITConfiguration: Prevent a crash if images fail to load
|
|
Jit64: Flush carry flag in FallBackToInterpreter
|
|
DolphinQt: Use QtUtils::CreateIconWarning to make the RetroAchievements warning size consistent with other warnings.
|
|
GBACore: Fix Pokemon GBA link.
|
|
Recently came across a strange issue where Dolphin would hard crash in most games with this error:
```sh
/usr/include/c++/15.2.1/optional:1165: constexpr const _Tp* std::optional<_Tp>::operator->() const [with _Tp = InputCommon::ImagePixelData]: Assertion 'this->_M_is_engaged()' failed.
```
The culprit turned out to be accessing `host_key_image` which is an `std::optional` thay may return `std::nullopt`. I'm not sure why this issue started occuring for me since I've had no issue with my Dynamic Input Textures in the past? But this fixes a crash if the image fails to load.
|
|
Aside from being unnecessary, on Windows the flag prevents two instances
of Dolphin (one instance from before 2509-371 when the flag was
introduced and the other after) from running the same ROM
simultaneously.
Attempting to do so generated the false error `"[Rom]" is an invalid
GCM/ISO file, or is not a GC/Wii ISO.` followed by `Failed to init core`
and emulation shutdown on the second instance to start the game. Fixing
the incorrect error message is a task I'm deferring to another PR.
The problem didn't happen when both instances were 2509-371 or later,
but I ran into it while bisecting an issue and it'd be nice to avoid
that problem in the future.
|
|
We have an optimization where the guest carry flag is kept in the host
carry flag between certain back-to-back pairs of integer instructions.
If the second instruction falls back to the interpreter, then
FallBackToInterpreter should flush the carry flag to m_ppc_state,
otherwise the interpreter reads a stale carry flag and at some later
point Jit64 trips the "Attempt to modify flags while flags locked!"
assertion.
An alternative solution would be to not store the guest carry flag in
the host carry flag to begin with if we know the next instruction is
going to fall back to the interpreter, but knowing that in advance is
non-trivial. Since interpreter fallbacks aren't exactly intended to be
super optimized, I went for the flushing solution instead, which is how
JitArm64 already works. In most cases, the emitted code shouldn't even
differ between these two solutions.
Note that the problematic situation only happens if the first integer
instruction doesn't fall back to the interpreter but the second one
does. This used to be impossible because there's no "JIT disable"
setting that's granular enough to disable some integer instructions but
not all, but with the constant propagation PR, it's possible if constant
propagation is able to entirely evaluate the first instruction but not
the second.
|
|
LillyJadeKatrin/retroachievements-eternal-darkness-testing-my-sanity
RetroAchievements - Remove Hardcore Check from ApplyMemoryPatch
|
|
This was blocking all memory patches from executing properly in hardcore mode even when contained in the Allowlist.
|
|
"hardcore mode" warning size consistent with the other warnings.
|
|
|
|
Call `UseNoImm` instead of `Use` on parameter `a` of `MultiplyImmediate`
since `Ra` gets passed to `IMUL` which asserts that parameter is not an
immediate.
|
|
This fixes NFL Blitz Pro.
|
|
DolphinQt: Adjust capitalization of "Select A Bluetooth Device"
|
|
IOS: Logitech USB Microphone Basic Support
|
|
|
|
Co-authored by: supermilkdude67 <w.f.s.jazzfyre@gmail.com>
|
|
There was a LINUX check added in b3bdad4, but this should be removed as this change applies to all Qt supported platforms. Simply put, GuiPrivate CMake files were introduced in Qt 6.9 and are now enforced in Qt 6.10 and are not platform-dependent.
|
|
Core: Make s_cpu_thread_job_finished a local variable
|
|
Having it be static leads to a race condition if two different threads
call RunOnCPUThread with wait_for_completion set to true. (There's
currently nobody calling RunOnCPUThread from anything other than the
host thread, so this hasn't led to any consequences yet.)
|
|
Externals: Update mGBA to latest master.
|
|
Bluetooth/RealtekFirmwareLoader: Add Mercusys MA530 to list.
|
|
VideoCommon: update ShaderAsset to use a vector of properties
|
|
Common: Treat DirectIOFile as unable to create SAF files
|
|
jordan-woyak/hookable-event-add-remove-inside-trigger
HookableEvent: Allow hooks to be added and removed from within a Trigger callback.
|
|
DolphinQt/QtUtils: Simplify RunOnObject and eliminate Common::Event race. Introduce Common::OneShotEvent class.
|
|
CoreTiming: Fix percent speed display when "Rush Frame Presentation" is enabled.
|
|
Android Support for RetroAchievements
|
|
|
|
Add "Rush Frame Presentation" and "Smooth Early Presentation" settings.
|
|
HW/SI: Fix CMD_STATUS response lengths.
|
|
callback. This fixes a deadlock in FIFOFifoRecorder.
|
|
ensure the order of these properties match the order of the material
|
|
in the shader source, this just makes it more difficult to iteratively test changes, assume shader devs know what they are doing
|
|
Graphs" and "Show Speed Colors".
|
|
"Performance Sample Window" and don't disable it based on "Show Performance Graphs".
|
|
SDIO: report write lock status
|
|
Common and VideoCommon: Silence a few warnings.
|
|
|
|
|
|
|
|
|
