From 11ba623f267814885c2d69c0f1214c9c576eb916 Mon Sep 17 00:00:00 2001 From: Stenzek Date: Tue, 14 Jan 2020 10:57:35 +1000 Subject: Add an option to present/skip presenting duplicate frames Currently, we do not display every second frame in 25fps/30fps games which run to vsync. This improves performance as there's less rendering for the GPU to perform, but when combined with vsync, could cause frame pacing issues. This commit adds an option to force every frame generated by the console to be displayed to the host, which may improve pacing for these games. --- .../dolphinemu/features/settings/ui/SettingsFragmentPresenter.java | 4 ++++ .../dolphinemu/dolphinemu/features/settings/utils/SettingsFile.java | 1 + 2 files changed, 5 insertions(+) (limited to 'Source/Android/app/src/main/java') diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java index 3c3f2f294f..9bf66e3cbe 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java @@ -585,6 +585,7 @@ public final class SettingsFragmentPresenter Setting gpuTextureDecoding = gfxSection.getSetting(SettingsFile.KEY_GPU_TEXTURE_DECODING); Setting xfbToTexture = hacksSection.getSetting(SettingsFile.KEY_XFB_TEXTURE); Setting immediateXfb = hacksSection.getSetting(SettingsFile.KEY_IMMEDIATE_XFB); + Setting skipDuplicateXfbs = hacksSection.getSetting(SettingsFile.KEY_SKIP_DUPLICATE_XFBS); Setting fastDepth = gfxSection.getSetting(SettingsFile.KEY_FAST_DEPTH); sl.add(new HeaderSetting(null, null, R.string.embedded_frame_buffer, 0)); @@ -613,6 +614,9 @@ public final class SettingsFragmentPresenter R.string.xfb_copy_method, R.string.xfb_copy_method_description, true, xfbToTexture)); sl.add(new CheckBoxSetting(SettingsFile.KEY_IMMEDIATE_XFB, Settings.SECTION_GFX_HACKS, R.string.immediate_xfb, R.string.immediate_xfb_description, false, immediateXfb)); + sl.add(new CheckBoxSetting(SettingsFile.KEY_SKIP_DUPLICATE_XFBS, Settings.SECTION_GFX_HACKS, + R.string.skip_duplicate_xfbs, R.string.skip_duplicate_xfbs_description, true, + skipDuplicateXfbs)); sl.add(new HeaderSetting(null, null, R.string.other, 0)); sl.add(new CheckBoxSetting(SettingsFile.KEY_FAST_DEPTH, Settings.SECTION_GFX_SETTINGS, diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/utils/SettingsFile.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/utils/SettingsFile.java index 8de9bf5281..c4e61b8646 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/utils/SettingsFile.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/utils/SettingsFile.java @@ -89,6 +89,7 @@ public final class SettingsFile public static final String KEY_GPU_TEXTURE_DECODING = "EnableGPUTextureDecoding"; public static final String KEY_XFB_TEXTURE = "XFBToTextureEnable"; public static final String KEY_IMMEDIATE_XFB = "ImmediateXFBEnable"; + public static final String KEY_SKIP_DUPLICATE_XFBS = "SkipDuplicateXFBs"; public static final String KEY_FAST_DEPTH = "FastDepthCalc"; public static final String KEY_ASPECT_RATIO = "AspectRatio"; public static final String KEY_SHADER_COMPILATION_MODE = "ShaderCompilationMode"; -- cgit v1.2.3