From 82f658a28fef217e2270082206a08fed4b579903 Mon Sep 17 00:00:00 2001 From: Simonx22 Date: Sat, 8 Nov 2025 10:47:24 -0500 Subject: Android: Use the shared HTTP analytics backend We can now route Android analytics through Common::HttpAnalyticsBackend, drop the Volley sender, and keep the JNI layer limited to only transfer metadata since https://bugs.dolphin-emu.org/issues/11772 has been fixed. --- .../dolphinemu/dolphinemu/DolphinApplication.java | 2 -- .../org/dolphinemu/dolphinemu/utils/Analytics.kt | 17 --------------- .../dolphinemu/dolphinemu/utils/VolleyUtil.java | 24 ---------------------- 3 files changed, 43 deletions(-) delete mode 100644 Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/VolleyUtil.java (limited to 'Source/Android/app/src/main/java') diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/DolphinApplication.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/DolphinApplication.java index 91200852a1..7978a1165e 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/DolphinApplication.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/DolphinApplication.java @@ -11,7 +11,6 @@ import org.dolphinemu.dolphinemu.utils.ActivityTracker; import org.dolphinemu.dolphinemu.utils.DirectoryInitialization; import org.dolphinemu.dolphinemu.utils.GCAdapter; import org.dolphinemu.dolphinemu.utils.WiimoteAdapter; -import org.dolphinemu.dolphinemu.utils.VolleyUtil; public class DolphinApplication extends Application { @@ -25,7 +24,6 @@ public class DolphinApplication extends Application application = this; sActivityTracker = new ActivityTracker(); registerActivityLifecycleCallbacks(sActivityTracker); - VolleyUtil.init(getApplicationContext()); System.loadLibrary("main"); GCAdapter.manager = (UsbManager) getSystemService(Context.USB_SERVICE); diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Analytics.kt b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Analytics.kt index c265db5945..3138609266 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Analytics.kt +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Analytics.kt @@ -5,8 +5,6 @@ package org.dolphinemu.dolphinemu.utils import android.os.Build import androidx.annotation.Keep import androidx.fragment.app.FragmentActivity -import com.android.volley.Response -import com.android.volley.toolbox.StringRequest import org.dolphinemu.dolphinemu.DolphinApplication import org.dolphinemu.dolphinemu.dialogs.AnalyticsDialog import org.dolphinemu.dolphinemu.features.settings.model.BooleanSetting @@ -37,21 +35,6 @@ object Analytics { } } - @Keep - @JvmStatic - fun sendReport(endpoint: String, data: ByteArray) { - val request: StringRequest = object : StringRequest( - Method.POST, - endpoint, - null, - Response.ErrorListener { Log.debug("Failed to send report") }) { - override fun getBody(): ByteArray { - return data - } - } - VolleyUtil.getQueue().add(request) - } - @Keep @JvmStatic fun getValue(key: String?): String { diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/VolleyUtil.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/VolleyUtil.java deleted file mode 100644 index 2ac6035461..0000000000 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/VolleyUtil.java +++ /dev/null @@ -1,24 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-or-later - -package org.dolphinemu.dolphinemu.utils; - -import android.content.Context; - -import com.android.volley.RequestQueue; -import com.android.volley.toolbox.Volley; - -public class VolleyUtil -{ - private static RequestQueue queue; - - public static void init(Context context) - { - if (queue == null) - queue = Volley.newRequestQueue(context); - } - - public static RequestQueue getQueue() - { - return queue; - } -} -- cgit v1.2.3