From f8703f90e309303fea272a0078abc4e3fa4167ed Mon Sep 17 00:00:00 2001 From: JosJuice Date: Wed, 23 Aug 2017 22:32:23 +0200 Subject: MainAndroid: Remove s_filename This fits better as a function parameter than as global state. --- .../src/main/java/org/dolphinemu/dolphinemu/NativeLibrary.java | 9 +-------- .../org/dolphinemu/dolphinemu/fragments/EmulationFragment.java | 6 ++---- 2 files changed, 3 insertions(+), 12 deletions(-) (limited to 'Source/Android/app/src/main/java') diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/NativeLibrary.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/NativeLibrary.java index bb9a75194b..de821f105c 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/NativeLibrary.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/NativeLibrary.java @@ -246,13 +246,6 @@ public final class NativeLibrary */ public static native void SetConfig(String configFile, String Section, String Key, String Value); - /** - * Sets the filename to be run during emulation. - * - * @param filename The filename to be run during emulation. - */ - public static native void SetFilename(String filename); - /** * Gets the embedded banner within the given ISO/ROM. * @@ -328,7 +321,7 @@ public final class NativeLibrary /** * Begins emulation. */ - public static native void Run(); + public static native void Run(String path); // Surface Handling public static native void SurfaceChanged(Surface surf); diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java index 7066b34c65..5bf1a7d677 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java @@ -66,9 +66,6 @@ public final class EmulationFragment extends Fragment implements SurfaceHolder.C @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { - String path = getArguments().getString(ARGUMENT_GAME_PATH); - NativeLibrary.SetFilename(path); - View contents = inflater.inflate(R.layout.fragment_emulation, container, false); SurfaceView surfaceView = (SurfaceView) contents.findViewById(R.id.surface_emulation); @@ -241,7 +238,8 @@ public final class EmulationFragment extends Fragment implements SurfaceHolder.C Log.info("[EmulationFragment] Starting emulation: " + mSurface); // Start emulation using the provided Surface. - NativeLibrary.Run(); + String path = getArguments().getString(ARGUMENT_GAME_PATH); + NativeLibrary.Run(path); } }; -- cgit v1.2.3