From 0b9351c194c8451576b183971e363ceaf658a448 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Sun, 25 Dec 2022 16:30:51 +0100 Subject: Android: Make more meticulous use of DeleteLocalRef If we're in a function that isn't just going to immediately return to Java, leaking local references can lead to problems eventually. --- Source/Android/jni/GameList/GameFileCache.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'Source/Android/jni/GameList/GameFileCache.cpp') diff --git a/Source/Android/jni/GameList/GameFileCache.cpp b/Source/Android/jni/GameList/GameFileCache.cpp index 061056cc90..280de59bf9 100644 --- a/Source/Android/jni/GameList/GameFileCache.cpp +++ b/Source/Android/jni/GameList/GameFileCache.cpp @@ -52,7 +52,9 @@ Java_org_dolphinemu_dolphinemu_model_GameFileCache_getAllGames(JNIEnv* env, jobj env->NewObjectArray(static_cast(ptr->GetSize()), IDCache::GetGameFileClass(), nullptr); jsize i = 0; GetPointer(env, obj)->ForEach([env, array, &i](const auto& game_file) { - env->SetObjectArrayElement(array, i++, GameFileToJava(env, game_file)); + jobject j_game_file = GameFileToJava(env, game_file); + env->SetObjectArrayElement(array, i++, j_game_file); + env->DeleteLocalRef(j_game_file); }); return array; } -- cgit v1.2.3