From 4fe8bb1ca7fc5092c7f85832c74cd6b5cd097204 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 14 Nov 2014 13:03:51 -0500 Subject: Android: Compress an if statement in FolderBrowser --- .../org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'Source/Android/src/org') diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java b/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java index 97400c23b8..669ffe0094 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/folderbrowser/FolderBrowser.java @@ -144,14 +144,7 @@ public final class FolderBrowser extends ListFragment { String isoPath = NativeLibrary.GetConfig("Dolphin.ini", "General", "ISOPath" + i, ""); - if (isoPath.equals(currentDir.getPath())) - { - pathNotPresent = false; - } - else - { - pathNotPresent = true; - } + pathNotPresent = !isoPath.equals(currentDir.getPath()); } // User doesn't have this path in the config, so add it. -- cgit v1.2.3 From 5b1f734695fa40c0c14237ef4b2106771ed35a28 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 14 Nov 2014 13:21:14 -0500 Subject: Android: Prevent instantiation of utility classes --- Source/Android/src/org/dolphinemu/dolphinemu/NativeLibrary.java | 5 +++++ .../src/org/dolphinemu/dolphinemu/settings/UserPreferences.java | 5 +++++ 2 files changed, 10 insertions(+) (limited to 'Source/Android/src/org') diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/NativeLibrary.java b/Source/Android/src/org/dolphinemu/dolphinemu/NativeLibrary.java index b66aa0a84f..769595c1b4 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/NativeLibrary.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/NativeLibrary.java @@ -53,6 +53,11 @@ public final class NativeLibrary public static final int PRESSED = 1; } + private NativeLibrary() + { + // Disallows instantiation. + } + /** * Default touchscreen device */ diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/settings/UserPreferences.java b/Source/Android/src/org/dolphinemu/dolphinemu/settings/UserPreferences.java index 49ae2bfebd..d2ae56b40f 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/settings/UserPreferences.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/settings/UserPreferences.java @@ -21,6 +21,11 @@ import android.preference.PreferenceManager; */ public final class UserPreferences { + private UserPreferences() + { + // Disallows instantiation. + } + /** * Loads the settings stored in the Dolphin ini config files to the shared preferences of this front-end. * -- cgit v1.2.3 From 7d8248e24fba1f9294d081c66e91297bbc075d0d Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 14 Nov 2014 14:01:11 -0500 Subject: Android: Remove unused imports in GameListItem --- .../Android/src/org/dolphinemu/dolphinemu/gamelist/GameListItem.java | 4 ---- 1 file changed, 4 deletions(-) (limited to 'Source/Android/src/org') diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListItem.java b/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListItem.java index 6459eda8d8..6e25a33804 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListItem.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/gamelist/GameListItem.java @@ -8,12 +8,8 @@ package org.dolphinemu.dolphinemu.gamelist; import android.content.Context; import android.graphics.Bitmap; -import android.graphics.BitmapFactory; -import android.util.Log; import java.io.File; -import java.io.IOException; -import java.io.InputStream; import org.dolphinemu.dolphinemu.NativeLibrary; -- cgit v1.2.3