From 6b2a8eff15bffc1dc6831d236032c751f426eb13 Mon Sep 17 00:00:00 2001 From: Dentomologist Date: Sat, 21 Mar 2026 13:37:22 -0700 Subject: AudioPane: Fix WASAPI default device combo selection Set the default value of `Config::MAIN_WASAPI_DEVICE` to `default` instead of `Default`. This fixes an issue where `AudioPane`'s `Output Device` combo would be blank if `WASAPI` was selected and the user had never changed the value of `Output Device`. We don't have to worry about backward compatibility with users who have `Default` in their config because config values aren't written unless they've been changed at some point from the default, and the combo has always saved `default` instead of `Default`. Audio still worked during emulation in this situation because the fallback for an unrecognized device name is the default device. To help prevent similar situations in the future references to `MAIN_WASAPI_DEVICE`'s default value now call `GetDefaultValue` instead of hardcoding the expected default, or use the new helper function `Config::IsDefaultValue`. --- Source/Core/AudioCommon/WASAPIStream.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/AudioCommon/WASAPIStream.cpp') diff --git a/Source/Core/AudioCommon/WASAPIStream.cpp b/Source/Core/AudioCommon/WASAPIStream.cpp index afd5531ae8..9cbf915e82 100644 --- a/Source/Core/AudioCommon/WASAPIStream.cpp +++ b/Source/Core/AudioCommon/WASAPIStream.cpp @@ -176,7 +176,7 @@ bool WASAPIStream::SetRunning(bool running) HRESULT result; - if (Config::Get(Config::MAIN_WASAPI_DEVICE) == "default") + if (Config::IsDefaultValue(Config::MAIN_WASAPI_DEVICE)) { result = m_enumerator->GetDefaultAudioEndpoint(eRender, eConsole, &device); } -- cgit v1.2.3