From 95dec132030e72b74da6bc46966e4fe5e4e239c0 Mon Sep 17 00:00:00 2001 From: Martino Fontana Date: Mon, 6 Apr 2026 11:37:26 +0200 Subject: Improve usage of std::move and const references parameters Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible. --- Source/Core/Common/FileSearch.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Source/Core/Common/FileSearch.cpp') diff --git a/Source/Core/Common/FileSearch.cpp b/Source/Core/Common/FileSearch.cpp index ebaa9f37b0..a90b385ad9 100644 --- a/Source/Core/Common/FileSearch.cpp +++ b/Source/Core/Common/FileSearch.cpp @@ -71,13 +71,13 @@ std::vector DoFileSearch(std::span director std::error_code error; if (recursive) { - for (auto it = fs::recursive_directory_iterator(std::move(directory_path), error); + for (auto it = fs::recursive_directory_iterator(directory_path, error); it != fs::recursive_directory_iterator(); it.increment(error)) add_filtered(*it); } else { - for (auto it = fs::directory_iterator(std::move(directory_path), error); + for (auto it = fs::directory_iterator(directory_path, error); it != fs::directory_iterator(); it.increment(error)) add_filtered(*it); } -- cgit v1.2.3