From a957f93532bfd2025fe20dd8929866c97b5e4df1 Mon Sep 17 00:00:00 2001 From: Gabriel Corona Date: Mon, 29 Dec 2014 01:09:07 +0100 Subject: Use printf-like format in JitRegister::Register The API is cleaner (no more magic default parameter) and more extensible like this. --- Source/Core/Common/JitRegister.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'Source/Core/Common/JitRegister.cpp') diff --git a/Source/Core/Common/JitRegister.cpp b/Source/Core/Common/JitRegister.cpp index 69ea7e5bba..7475cb6b85 100644 --- a/Source/Core/Common/JitRegister.cpp +++ b/Source/Core/Common/JitRegister.cpp @@ -72,18 +72,17 @@ void Shutdown() } void Register(const void* base_address, u32 code_size, - const char* name, u32 original_address) + const char* format, ...) { #if !(defined USE_OPROFILE && USE_OPROFILE) && !defined(USE_VTUNE) if (!s_perf_map_file.IsOpen()) return; #endif - std::string symbol_name; - if (original_address) - symbol_name = StringFromFormat("%s_%x", name, original_address); - else - symbol_name = name; + va_list args; + va_start(args, format); + std::string symbol_name = StringFromFormatV(format, args); + va_end(args); #if defined USE_OPROFILE && USE_OPROFILE op_write_native_code(s_agent, symbol_name.data(), (u64)base_address, -- cgit v1.2.3 From a4adfe194a5b954bdda80dc6b145e0cf646ccd63 Mon Sep 17 00:00:00 2001 From: Gabriel Corona Date: Mon, 5 Jan 2015 20:24:37 +0100 Subject: JitRegister: overload Register with a [start,end) variant --- Source/Core/Common/JitRegister.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'Source/Core/Common/JitRegister.cpp') diff --git a/Source/Core/Common/JitRegister.cpp b/Source/Core/Common/JitRegister.cpp index 7475cb6b85..964a88b214 100644 --- a/Source/Core/Common/JitRegister.cpp +++ b/Source/Core/Common/JitRegister.cpp @@ -71,18 +71,15 @@ void Shutdown() s_perf_map_file.Close(); } -void Register(const void* base_address, u32 code_size, - const char* format, ...) +void RegisterV(const void* base_address, u32 code_size, + const char* format, va_list args) { #if !(defined USE_OPROFILE && USE_OPROFILE) && !defined(USE_VTUNE) if (!s_perf_map_file.IsOpen()) return; #endif - va_list args; - va_start(args, format); std::string symbol_name = StringFromFormatV(format, args); - va_end(args); #if defined USE_OPROFILE && USE_OPROFILE op_write_native_code(s_agent, symbol_name.data(), (u64)base_address, -- cgit v1.2.3