From 95dec132030e72b74da6bc46966e4fe5e4e239c0 Mon Sep 17 00:00:00 2001 From: Martino Fontana Date: Mon, 6 Apr 2026 11:37:26 +0200 Subject: Improve usage of std::move and const references parameters Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible. --- Source/Core/Common/TraversalClient.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'Source/Core/Common/TraversalClient.cpp') diff --git a/Source/Core/Common/TraversalClient.cpp b/Source/Core/Common/TraversalClient.cpp index 44b8390f90..2e0fb8e2ad 100644 --- a/Source/Core/Common/TraversalClient.cpp +++ b/Source/Core/Common/TraversalClient.cpp @@ -5,6 +5,7 @@ #include #include #include +#include #include "Common/CommonTypes.h" #include "Common/Logging/Log.h" @@ -14,9 +15,9 @@ namespace Common { -TraversalClient::TraversalClient(ENetHost* netHost, const std::string& server, const u16 port, +TraversalClient::TraversalClient(ENetHost* netHost, std::string server, const u16 port, const u16 port_alt) - : m_NetHost(netHost), m_Server(server), m_port(port), m_portAlt(port_alt) + : m_NetHost(netHost), m_Server(std::move(server)), m_port(port), m_portAlt(port_alt) { netHost->intercept = TraversalClient::InterceptCallback; -- cgit v1.2.3