From b470fa5454088effae64377f147db3e213947cd0 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Sun, 12 Feb 2017 13:02:57 +0100 Subject: FileMonitor redesign Advantages: * Simpler code in general * No extra volume objects created * Now actually notices if the disc or partition gets changed while the core is running * No longer picks up on disc access done by the GUI (it used to do so as long as the core was running) * Gets rid of a Core dependency in DiscIO There are two performance disadvantages: * FileMonitor is now a bit slower when used with VolumeDirectory because FileMonitor now always uses the FileSystemGCWii code for finding filenames instead of VolumeDirectory finding the filename on its own and directly hooking into FileMonitor. But this isn't such a big deal, because it's happening on the DVD thread, and my currently unmerged file system PR will make FileSystemGCWii's file finding code about as fast as VolumeDirectory's. * FileMonitor's creation of the file system object is now done on the CPU thread instead of the DVD thread, and it will be done even if FileMonitor logging is disabled. This will be fixed in the next commit. --- Source/Core/DiscIO/FileMonitor.h | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 Source/Core/DiscIO/FileMonitor.h (limited to 'Source/Core/DiscIO/FileMonitor.h') diff --git a/Source/Core/DiscIO/FileMonitor.h b/Source/Core/DiscIO/FileMonitor.h deleted file mode 100644 index 0e73152947..0000000000 --- a/Source/Core/DiscIO/FileMonitor.h +++ /dev/null @@ -1,18 +0,0 @@ -// Copyright 2008 Dolphin Emulator Project -// Licensed under GPLv2+ -// Refer to the license.txt file included. - -#pragma once - -#include - -#include "Common/CommonTypes.h" - -namespace FileMon -{ -bool IsSoundFile(const std::string& filename); -void ReadFileSystem(const std::string& file); -void CheckFile(const std::string& file, u64 size); -void FindFilename(u64 offset); -void Close(); -} -- cgit v1.2.3