From 5e3c98af1dc06e9530e8c290a43bb702274e6ec3 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Wed, 7 Jun 2017 11:49:34 +0200 Subject: DiscIO: Add a Volume::ReadSwappedAndShifted function This is a fairly common operation, so let's make a utility function for it to cut down on code duplication. --- Source/Core/DiscIO/FileSystemGCWii.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'Source/Core/DiscIO/FileSystemGCWii.cpp') diff --git a/Source/Core/DiscIO/FileSystemGCWii.cpp b/Source/Core/DiscIO/FileSystemGCWii.cpp index 9a7e24c288..c7cd7115cc 100644 --- a/Source/Core/DiscIO/FileSystemGCWii.cpp +++ b/Source/Core/DiscIO/FileSystemGCWii.cpp @@ -185,15 +185,16 @@ bool FileInfoGCWii::IsValid(u64 fst_size, const FileInfoGCWii& parent_directory) } FileSystemGCWii::FileSystemGCWii(const Volume* volume, const Partition& partition) - : FileSystem(volume, partition), m_valid(false), m_offset_shift(0), m_root(nullptr, 0, 0, 0) + : FileSystem(volume, partition), m_valid(false), m_root(nullptr, 0, 0, 0) { + u8 offset_shift; // Check if this is a GameCube or Wii disc if (m_volume->ReadSwapped(0x18, m_partition) == u32(0x5D1C9EA3)) - m_offset_shift = 2; // Wii file system + offset_shift = 2; // Wii file system else if (m_volume->ReadSwapped(0x1c, m_partition) == u32(0xC2339F3D)) - m_offset_shift = 0; // GameCube file system + offset_shift = 0; // GameCube file system else - return; + return; // Invalid partition (maybe someone removed its data but not its partition table entry) const std::optional fst_offset = GetFSTOffset(*m_volume, m_partition); const std::optional fst_size = GetFSTSize(*m_volume, m_partition); @@ -226,7 +227,7 @@ FileSystemGCWii::FileSystemGCWii(const Volume* volume, const Partition& partitio } // Create the root object - m_root = FileInfoGCWii(m_file_system_table.data(), m_offset_shift); + m_root = FileInfoGCWii(m_file_system_table.data(), offset_shift); if (!m_root.IsDirectory()) { ERROR_LOG(DISCIO, "File system root is not a directory"); -- cgit v1.2.3