From afe2bc60f634cf1d417680cefc51b3caeb3cfbf2 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Fri, 31 Jul 2015 13:36:28 +0200 Subject: Filesystem: Initialize everything in constructor Not initializing until the filesystem is used is good when a filesystem is constructed and then never used, but nobody does that. This simplifies the code a little and lets all methods be const. --- Source/Core/DiscIO/Filesystem.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) (limited to 'Source/Core/DiscIO/Filesystem.h') diff --git a/Source/Core/DiscIO/Filesystem.h b/Source/Core/DiscIO/Filesystem.h index 99d89f110a..2f1fe2c82d 100644 --- a/Source/Core/DiscIO/Filesystem.h +++ b/Source/Core/DiscIO/Filesystem.h @@ -39,16 +39,17 @@ public: virtual ~FileSystem(); virtual bool IsValid() const = 0; // TODO: Should only return FileInfo, not FileInfoGCWii - virtual const std::vector& GetFileList() = 0; - virtual const FileInfo* FindFileInfo(const std::string& path) = 0; - virtual const FileInfo* FindFileInfo(u64 disc_offset) = 0; + virtual const std::vector& GetFileList() const = 0; + virtual const FileInfo* FindFileInfo(const std::string& path) const = 0; + virtual const FileInfo* FindFileInfo(u64 disc_offset) const = 0; virtual u64 ReadFile(const FileInfo* file_info, u8* _pBuffer, u64 _MaxBufferSize, - u64 _OffsetInFile = 0) = 0; - virtual bool ExportFile(const FileInfo* file_info, const std::string& _rExportFilename) = 0; + u64 _OffsetInFile = 0) const = 0; + virtual bool ExportFile(const FileInfo* file_info, + const std::string& _rExportFilename) const = 0; virtual bool ExportApploader(const std::string& _rExportFolder) const = 0; virtual bool ExportDOL(const std::string& _rExportFolder) const = 0; - virtual std::string GetPath(u64 _Address) = 0; - virtual std::string GetPathFromFSTOffset(size_t file_info_offset) = 0; + virtual std::string GetPath(u64 _Address) const = 0; + virtual std::string GetPathFromFSTOffset(size_t file_info_offset) const = 0; virtual std::optional GetBootDOLOffset() const = 0; virtual std::optional GetBootDOLSize(u64 dol_offset) const = 0; -- cgit v1.2.3