From 9a01c3fb9f137b666f27fcf8f1bfc3ac9c42346b Mon Sep 17 00:00:00 2001 From: JosJuice Date: Mon, 16 Nov 2020 13:28:11 +0100 Subject: Use positional arguments in all translatable fmt strings We want to use positional arguments in translatable strings that have more than one argument so that translators can change the order of them, but the question is: Should we also use positional arguments in translatable strings with only one argument? I think it makes most sense that way, partially so that translators don't even have to be aware of the non-positional syntax and partially because "translatable strings use positional arguments" is an easier rule for us to remember than "transitional strings which have more than one argument use positional arguments". But let me know if you have a different opinion. --- Source/Core/DiscIO/VolumeVerifier.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'Source/Core/DiscIO/VolumeVerifier.cpp') diff --git a/Source/Core/DiscIO/VolumeVerifier.cpp b/Source/Core/DiscIO/VolumeVerifier.cpp index 860709448e..c1c9a8ae3b 100644 --- a/Source/Core/DiscIO/VolumeVerifier.cpp +++ b/Source/Core/DiscIO/VolumeVerifier.cpp @@ -312,11 +312,11 @@ std::vector RedumpVerifier::ScanDatfile(const st // so show a panic alert rather than just using ERROR_LOG // i18n: "Serial" refers to serial numbers, e.g. RVL-RSBE-USA - PanicAlertFmtT("Serial and/or version data is missing from {}\n" - "Please append \"{}\" (without the quotes) to the datfile URL when downloading\n" - "Example: {}", - GetPathForSystem(system), "serial,version", - "http://redump.org/datfile/gc/serial,version"); + PanicAlertFmtT( + "Serial and/or version data is missing from {0}\n" + "Please append \"{1}\" (without the quotes) to the datfile URL when downloading\n" + "Example: {2}", + GetPathForSystem(system), "serial,version", "http://redump.org/datfile/gc/serial,version"); m_result = {Status::Error, Common::GetStringT("Failed to parse Redump.org data")}; return {}; } -- cgit v1.2.3