From 83c5446d852178794450f7c5833f7a047490ff31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Fri, 14 Jan 2022 00:04:22 +0100 Subject: Fix static initialisation order fiasco issue for Version variables Fixes a crash that could occur if the static constructor function for the MainSettings.cpp TU happened to run before the variables in Common/Version.cpp are initialised. (This is known as the static initialisation order fiasco.) By using wrapper functions, those variables are now guaranteed to be constructed on first use. --- Source/Core/DiscIO/VolumeVerifier.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/DiscIO/VolumeVerifier.cpp') diff --git a/Source/Core/DiscIO/VolumeVerifier.cpp b/Source/Core/DiscIO/VolumeVerifier.cpp index 0a17864290..252cf427b6 100644 --- a/Source/Core/DiscIO/VolumeVerifier.cpp +++ b/Source/Core/DiscIO/VolumeVerifier.cpp @@ -125,7 +125,7 @@ RedumpVerifier::DownloadStatus RedumpVerifier::DownloadDatfile(const std::string const std::optional> result = request.Get("http://redump.org/datfile/" + system + "/serial,version", - {{"User-Agent", Common::scm_rev_str}}); + {{"User-Agent", Common::GetScmRevStr()}}); const std::string output_path = GetPathForSystem(system); -- cgit v1.2.3