From d1946aded69928f4bd32f45297ec4cac22313686 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Sat, 20 Mar 2021 11:50:00 +0100 Subject: Avoid using panic alerts in DiscIO Panic alerts in DiscIO can potentially be very annoying since large amounts of them can pop up when loading the game list if you have some particularly weird files in your game list. This was a much bigger problem back in 5.0 with its "Tried to decrypt data from a non-Wii volume" panic alert, but I figured I would take it all the way and remove the remaining panic alerts that can show up when loading the game list. I have exempted uses of ASSERT/ASSERT_MSG since they indicate a bug in Dolphin rather than a malformed file. --- Source/Core/DiscIO/VolumeWii.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'Source/Core/DiscIO/VolumeWii.cpp') diff --git a/Source/Core/DiscIO/VolumeWii.cpp b/Source/Core/DiscIO/VolumeWii.cpp index bad4509b5c..63e20ec1e6 100644 --- a/Source/Core/DiscIO/VolumeWii.cpp +++ b/Source/Core/DiscIO/VolumeWii.cpp @@ -24,7 +24,6 @@ #include "Common/Assert.h" #include "Common/CommonTypes.h" #include "Common/Logging/Log.h" -#include "Common/MsgHandler.h" #include "Common/Swap.h" #include "DiscIO/Blob.h" @@ -92,7 +91,7 @@ VolumeWii::VolumeWii(std::unique_ptr reader) { // This check is normally done by ES in ES_DiVerify, but that would happen too late // (after allocating the buffer), so we do the check here. - PanicAlertFmt("Invalid TMD size"); + ERROR_LOG_FMT(DISCIO, "Invalid TMD size"); return INVALID_TMD; } std::vector tmd_buffer(*tmd_size); -- cgit v1.2.3