From 6914eca167d35b4ffb3e1979bb690b378bb8448a Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Sun, 23 Feb 2014 15:14:27 +0100 Subject: Fix various warnings reported by clang - mostly remove unused variables - rename some generic JIT identifiers --- Source/Core/DiscIO/WbfsBlob.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'Source/Core/DiscIO') diff --git a/Source/Core/DiscIO/WbfsBlob.cpp b/Source/Core/DiscIO/WbfsBlob.cpp index b51c14ae9a..4e77d9e959 100644 --- a/Source/Core/DiscIO/WbfsBlob.cpp +++ b/Source/Core/DiscIO/WbfsBlob.cpp @@ -14,10 +14,9 @@ namespace DiscIO { -const u64 wii_sector_size = 0x8000; -const u64 wii_sector_count = 143432 * 2; -const u64 wii_sector_log2 = 15; -const u64 wii_disc_header_size = 256; +static const u64 wii_sector_size = 0x8000; +static const u64 wii_sector_count = 143432 * 2; +static const u64 wii_disc_header_size = 256; static inline u64 align(u64 value, u64 bounds) { -- cgit v1.2.3 From 315a8ba1c04bf8cffd9b04096be898ac462fa89e Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Sun, 23 Feb 2014 23:03:39 +0100 Subject: Various changes suggested by cppcheck - remove unused variables - reduce the scope where it makes sense - correct limits (did you know that strcat()'s last parameter does not include the \0 that is always added?) - set some free()'d pointers to NULL --- Source/Core/DiscIO/NANDContentLoader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/DiscIO') diff --git a/Source/Core/DiscIO/NANDContentLoader.cpp b/Source/Core/DiscIO/NANDContentLoader.cpp index 1e3be46c70..673c2878d4 100644 --- a/Source/Core/DiscIO/NANDContentLoader.cpp +++ b/Source/Core/DiscIO/NANDContentLoader.cpp @@ -374,9 +374,9 @@ void CNANDContentLoader::RemoveTitle() const // remove tmd? for (u32 i = 0; i < m_numEntries; i++) { - char szFilename[1024]; if (!(m_Content[i].m_Type & 0x8000)) // skip shared apps { + char szFilename[1024]; sprintf(szFilename, "%s%08x.app", Common::GetTitleContentPath(m_TitleID).c_str(), m_Content[i].m_ContentID); INFO_LOG(DISCIO, "Delete %s", szFilename); File::Delete(szFilename); -- cgit v1.2.3