From fef1b84f0a587dc285af6659cb64042e34e54223 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 30 Jul 2019 07:57:06 -0400 Subject: DolphinQt: Replace QStringLiteral with alternatives where applicable QStringLiterals generate a buffer so that during runtime there's very little cost to constructing a QString. However, this also means that duplicated strings cannot be optimized out into a single entry that gets referenced everywhere, taking up space in the binary. Rather than use QStringLiteral(""), we can just use QString{} (the default constructor) to signify the empty string. This gets rid of an unnecessary string buffer from being created, saving a tiny bit of space. While we're at it, we can just use the character overloads of particular functions when they're available instead of using a QString overload. The characters in this case are Latin-1 to begin with, so we can just specify the characters as QLatin1Char instances to use those overloads. These will automatically convert to QChar if needed, so this is safe. --- Source/Core/DolphinQt/Config/FilesystemWidget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Source/Core/DolphinQt/Config/FilesystemWidget.cpp') diff --git a/Source/Core/DolphinQt/Config/FilesystemWidget.cpp b/Source/Core/DolphinQt/Config/FilesystemWidget.cpp index 65caa17bf9..461a83ccc6 100644 --- a/Source/Core/DolphinQt/Config/FilesystemWidget.cpp +++ b/Source/Core/DolphinQt/Config/FilesystemWidget.cpp @@ -263,7 +263,7 @@ DiscIO::Partition FilesystemWidget::GetPartitionFromID(int id) void FilesystemWidget::ExtractPartition(const DiscIO::Partition& partition, const QString& out) { - ExtractDirectory(partition, QStringLiteral(""), out + QStringLiteral("/files")); + ExtractDirectory(partition, QString{}, out + QStringLiteral("/files")); ExtractSystemData(partition, out); } -- cgit v1.2.3