From 9bb85ca70619f08d9349f798f9c204c08df5b2d9 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Sat, 2 Oct 2021 11:09:36 +0200 Subject: DolphinQt/Android: Add warning when converting NKit files Yes, that's right! It's time to add even more NKit warnings, because users still don't understand what NKit is or how it works! More specifically, some users seem to be under the impression that converting an NKit file to for instance RVZ using Dolphin's convert feature will result in a normal RVZ file, when it in fact results in an NKit RVZ file (since NKit is not a container format in the sense that GCZ/WIA/RVZ/WBFS/CISO is, but rather a kind of trimmed ISO). I can hardly blame users for not knowing this, because it's not intuitive unless you know the technical details of how NKit works. --- Source/Core/DolphinQt/ConvertDialog.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'Source/Core/DolphinQt/ConvertDialog.cpp') diff --git a/Source/Core/DolphinQt/ConvertDialog.cpp b/Source/Core/DolphinQt/ConvertDialog.cpp index b7bf614291..097ca87a39 100644 --- a/Source/Core/DolphinQt/ConvertDialog.cpp +++ b/Source/Core/DolphinQt/ConvertDialog.cpp @@ -329,6 +329,21 @@ void ConvertDialog::Convert() } } + if (std::any_of(m_files.begin(), m_files.end(), std::mem_fn(&UICommon::GameFile::IsNKit))) + { + if (!ShowAreYouSureDialog( + tr("Dolphin can't convert NKit files to non-NKit files. Converting an NKit file in " + "Dolphin will result in another NKit file.\n" + "\n" + "If you want to convert an NKit file to a non-NKit file, you can use the same " + "program as you originally used when converting the file to the NKit format.\n" + "\n" + "Do you want to continue anyway?"))) + { + return; + } + } + QString extension; QString filter; switch (format) -- cgit v1.2.3