From 92a655c8b90c62255bcd3fcc160e240c98f79217 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Sat, 6 Jul 2019 10:50:11 +0200 Subject: DolphinQt: Don't update debug widgets when hidden Saves on CPU usage when pausing/unpausing with the debugger disabled. This is especially important when using frame advance rapidly. --- Source/Core/DolphinQt/Debugger/CodeWidget.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'Source/Core/DolphinQt/Debugger/CodeWidget.cpp') diff --git a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp index 443da54042..def631f87e 100644 --- a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp @@ -64,8 +64,6 @@ CodeWidget::CodeWidget(QWidget* parent) : QDockWidget(parent) settings.value(QStringLiteral("codewidget/codesplitter")).toByteArray()); m_box_splitter->restoreState( settings.value(QStringLiteral("codewidget/boxsplitter")).toByteArray()); - - Update(); } CodeWidget::~CodeWidget() @@ -83,6 +81,11 @@ void CodeWidget::closeEvent(QCloseEvent*) Settings::Instance().SetCodeVisible(false); } +void CodeWidget::showEvent(QShowEvent* event) +{ + Update(); +} + void CodeWidget::CreateWidgets() { auto* layout = new QGridLayout; @@ -265,6 +268,9 @@ void CodeWidget::SetAddress(u32 address, CodeViewWidget::SetAddressUpdate update void CodeWidget::Update() { + if (!isVisible()) + return; + const Common::Symbol* symbol = g_symbolDB.GetSymbolFromAddr(m_code_view->GetAddress()); UpdateCallstack(); -- cgit v1.2.3