From fef1b84f0a587dc285af6659cb64042e34e54223 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 30 Jul 2019 07:57:06 -0400 Subject: DolphinQt: Replace QStringLiteral with alternatives where applicable QStringLiterals generate a buffer so that during runtime there's very little cost to constructing a QString. However, this also means that duplicated strings cannot be optimized out into a single entry that gets referenced everywhere, taking up space in the binary. Rather than use QStringLiteral(""), we can just use QString{} (the default constructor) to signify the empty string. This gets rid of an unnecessary string buffer from being created, saving a tiny bit of space. While we're at it, we can just use the character overloads of particular functions when they're available instead of using a QString overload. The characters in this case are Latin-1 to begin with, so we can just specify the characters as QLatin1Char instances to use those overloads. These will automatically convert to QChar if needed, so this is safe. --- Source/Core/DolphinQt/Debugger/CodeWidget.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Source/Core/DolphinQt/Debugger/CodeWidget.cpp') diff --git a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp index def631f87e..d158af2793 100644 --- a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp @@ -314,9 +314,9 @@ void CodeWidget::UpdateCallstack() void CodeWidget::UpdateSymbols() { - QString selection = m_symbols_list->selectedItems().isEmpty() ? - QStringLiteral("") : - m_symbols_list->selectedItems()[0]->text(); + const QString selection = m_symbols_list->selectedItems().isEmpty() ? + QString{} : + m_symbols_list->selectedItems()[0]->text(); m_symbols_list->clear(); for (const auto& symbol : g_symbolDB.Symbols()) -- cgit v1.2.3