From 061da1300a67833b75b41db247729844b4ab6cd0 Mon Sep 17 00:00:00 2001 From: Michael M Date: Mon, 21 Aug 2017 17:56:51 -0700 Subject: GameFile: handle missing banners in UI instead Currently, GameFile returns a generic banner if the file didn't have one available (either because the file format doesn't support it, or because it's a Wii file without an associated save). It makes more sense to handle the lack of banner in the UI layer. The game list will use the generic missing banner explicitly (no change from before), and the game info window now omits the banner display entirely if the file didn't have one (since it's not useful to display/allow the user to save the "missing banner" banner). --- Source/Core/DolphinQt2/GameList/GameFile.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'Source/Core/DolphinQt2/GameList/GameFile.cpp') diff --git a/Source/Core/DolphinQt2/GameList/GameFile.cpp b/Source/Core/DolphinQt2/GameList/GameFile.cpp index 9797dcb31a..9e4e0f1dc2 100644 --- a/Source/Core/DolphinQt2/GameList/GameFile.cpp +++ b/Source/Core/DolphinQt2/GameList/GameFile.cpp @@ -99,8 +99,6 @@ void GameFile::ReadBanner(const DiscIO::Volume& volume) if (!banner.isNull()) m_banner = QPixmap::fromImage(banner); - else - m_banner = Resources::GetMisc(Resources::BANNER_MISSING); } bool GameFile::LoadFileInfo(const QString& path) @@ -197,7 +195,6 @@ bool GameFile::TryLoadElfDol() m_country = DiscIO::Country::COUNTRY_UNKNOWN; m_blob_type = DiscIO::BlobType::DIRECTORY; m_raw_size = m_size; - m_banner = Resources::GetMisc(Resources::BANNER_MISSING); m_rating = 0; return true; -- cgit v1.2.3